QUIC - Android - Fix the bug in QuicServerInfoMap iteration when server

QUIC - Android - Fix the bug in QuicServerInfoMap iteration when server
configs are loaded from properties file. Iteration can go into an
infinite loop if there is more than one entry. During iteration, Get()
method of MRUCache was being called which would modify the map that is
being iterated.

BUG=600864
R=rch@chromium.org

Committed: https://crrev.com/ee679d531c757121a83ee0f919b7af9a30e86ee7
Cr-Commit-Position: refs/heads/master@{#385484}

[Ryan Hamilton, 2016-04-06 04:25:54]

lgtm

thanks for the quick fix

https://codereview.chromium.org/1866613002/diff/1/net/quic/quic_stream_factor...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/1866613002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:1724: server_list.insert(server_list.begin(),
key_value.first);
It looks like this is going to be O(n^2) since it adds to the front of the list
each time and then has to move the remaining elements. I wonder if it might be
faster do do something like:

  sever_list[i++] = key_value.first;

When n is 5 n^2 isn't that big, so this isn't a big deal.

[ramant (doing other things), 2016-04-06 04:56:07]

PTAL

https://codereview.chromium.org/1866613002/diff/1/net/quic/quic_stream_factor...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/1866613002/diff/1/net/quic/quic_stream_factor...
net/quic/quic_stream_factory.cc:1724: server_list.insert(server_list.begin(),
key_value.first);
On 2016/04/06 04:25:54, Ryan Hamilton wrote:
> It looks like this is going to be O(n^2) since it adds to the front of the
list
> each time and then has to move the remaining elements. I wonder if it might be
> faster do do something like:
> 
>   sever_list[i++] = key_value.first;
> 
> When n is 5 n^2 isn't that big, so this isn't a big deal.

facepalm (thanks for catching this). Used push_back and iterated over the list
in the reverse order.

Done.

[ramant (doing other things), 2016-04-06 04:56:17]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 04:56:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866613002/20001

[commit-bot: I haz the power, 2016-04-06 06:12:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 06:12:20]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-04-06 13:39:45]

lgtm

[ramant (doing other things), 2016-04-06 16:43:14]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-04-06 16:43:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1866613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1866613002/20001

[commit-bot: I haz the power, 2016-04-06 17:01:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-06 17:03:16]

Description was changed from

==========
QUIC - Android - Fix the bug in QuicServerInfoMap iteration when server
configs are loaded from properties file. Iteration can go into an
infinite loop if there is more than one entry. During iteration, Get()
method of MRUCache was being called which would modify the map that is
being iterated.

BUG=600864
R=rch@chromium.org
==========

to

==========
QUIC - Android - Fix the bug in QuicServerInfoMap iteration when server
configs are loaded from properties file. Iteration can go into an
infinite loop if there is more than one entry. During iteration, Get()
method of MRUCache was being called which would modify the map that is
being iterated.

BUG=600864
R=rch@chromium.org

Committed: https://crrev.com/ee679d531c757121a83ee0f919b7af9a30e86ee7
Cr-Commit-Position: refs/heads/master@{#385484}
==========

[commit-bot: I haz the power, 2016-04-06 17:03:17]

Patchset 2 (id:??) landed as
https://crrev.com/ee679d531c757121a83ee0f919b7af9a30e86ee7
Cr-Commit-Position: refs/heads/master@{#385484}