Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2071373002: QUIC - Delete Net.QuicStreamFactory.TSVIPCliIsLoaded histogram. We have (Closed)

Created:
4 years, 6 months ago by ramant (doing other things)
Modified:
4 years, 6 months ago
Reviewers:
rkaplow, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Delete Net.QuicStreamFactory.TSVIPCliIsLoaded histogram. We have fixed the crash bug when TSVIPCli DLL is loaded. Cleaning up the code that is not needed. BUG=471986 R=rkaplow@chromium.org, rch@chromium.org Committed: https://crrev.com/5a38f3b112479570bb7ad1efc560ae885ce2dfce Cr-Commit-Position: refs/heads/master@{#400795}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M net/quic/quic_stream_factory.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (6 generated)
ramant (doing other things)
4 years, 6 months ago (2016-06-17 18:39:39 UTC) #1
Ryan Hamilton
lgtm
4 years, 6 months ago (2016-06-18 15:00:25 UTC) #2
ramant (doing other things)
Hi rkaplow@, Can you please take a look? thanks raman
4 years, 6 months ago (2016-06-20 16:44:27 UTC) #5
rkaplow
https://codereview.chromium.org/2071373002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2071373002/diff/1/tools/metrics/histograms/histograms.xml#oldcode29902 tools/metrics/histograms/histograms.xml:29902: - <owner>rtenneti@chromium.org</owner> can you instead mark it as obsolete
4 years, 6 months ago (2016-06-20 20:17:49 UTC) #6
rkaplow
4 years, 6 months ago (2016-06-20 20:17:50 UTC) #7
ramant (doing other things)
https://codereview.chromium.org/2071373002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2071373002/diff/1/tools/metrics/histograms/histograms.xml#oldcode29902 tools/metrics/histograms/histograms.xml:29902: - <owner>rtenneti@chromium.org</owner> On 2016/06/20 20:17:49, rkaplow wrote: > can ...
4 years, 6 months ago (2016-06-20 20:26:16 UTC) #8
rkaplow
lgtm
4 years, 6 months ago (2016-06-20 20:28:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071373002/20001
4 years, 6 months ago (2016-06-20 20:33:23 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 21:44:13 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 21:45:35 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a38f3b112479570bb7ad1efc560ae885ce2dfce
Cr-Commit-Position: refs/heads/master@{#400795}

Powered by Google App Engine
This is Rietveld 408576698