Landing Recent QUIC changes until 01/31/2016 05:22 UTC

Landing Recent QUIC changes until 01/31/2016 05:22 UTC

Replace QuicEncryptedPacket's fields with equivalents in SerializedPacket.
No functional change.

Merge internal change: 113458293
https://codereview.chromium.org/1667003002/

Refactor the QuicPacketCreatorTest to make it easier to flatten
QuicEncryptedPacket into SerializedPacket.

n/a(Test Only)

Merge internal change: 113395732
https://codereview.chromium.org/1665973003/

Refactor QuicCryptoClientStream to use QuicSession directly.

Merge internal change: 113372125
https://codereview.chromium.org/1665743003/

Move the check for QUIC silent close from SendConnectionClosePacket, to
CheckForTimeout.

Merge internal change: 113297234
https://codereview.chromium.org/1664973002/

Rename QUIC connection timeout error codes to be more descriptive.
No behavior change.

Renames:

QUIC_CONNECTION_TIMED_OUT -> QUIC_NETWORK_IDLE_TIMEOUT
QUIC_CONNECTION_OVERALL_TIMED_OUT -> QUIC_HANDSHAKE_TIMEOUT

To future Chromium merger: You will need to update histograms.xml in
Chromium, for the mapping from error code -> UMA string.

Merge internal change: 113294280
https://codereview.chromium.org/1664763003/

Change server push unit tests of quic toy server session to make tests
pass when FLAGS_quic_cede_correctly is true.

Since cl/112799471 changes quic priority behavior of connection level
flow control blocked streams, and currently the server push unit tests
uses connection level flow control to keep push streams open, the tests
failed when new behavior is introduced. This CL changes the tests to use
stream level flow control instead of connection level.

Merge internal change: 113275797
https://codereview.chromium.org/1662083003/

R=rch@chromium.org,  eroman@chromium.org, ttuttle@chromium.org,

Committed: https://crrev.com/2cae207e31716451b665dd11b3a21262e3e7a2e3
Cr-Commit-Position: refs/heads/master@{#373723}

[ramant (doing other things), 2016-02-04 05:17:16]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-04 05:17:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667583004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667583004/1

[Ryan Hamilton, 2016-02-04 05:24:07]

lgtm

[ramant (doing other things), 2016-02-04 05:26:38]

On 2016/02/04 05:24:07, Ryan Hamilton wrote:
> lgtm

All merged for this week are complete.

Thanks much Ryan.

[ramant (doing other things), 2016-02-04 05:26:46]

The CQ bit was unchecked by rtenneti@chromium.org

[ramant (doing other things), 2016-02-04 05:26:47]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-02-04 05:26:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667583004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667583004/1

[commit-bot: I haz the power, 2016-02-04 05:32:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 05:32:44]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[ramant (doing other things), 2016-02-04 05:55:49]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-02-04 05:55:49]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1667583004/#ps20001
(title: "compile fix")

[commit-bot: I haz the power, 2016-02-04 05:56:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667583004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667583004/20001

[commit-bot: I haz the power, 2016-02-04 06:04:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 06:04:30]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[ramant (doing other things), 2016-02-04 07:23:30]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-04 07:23:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667583004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667583004/40001

[ramant (doing other things), 2016-02-04 07:24:13]

Description was changed from

==========
Landing Recent QUIC changes until 01/31/2016 05:22 UTC


Replace QuicEncryptedPacket's fields with equivalents in SerializedPacket.
No functional change.

Merge internal change: 113458293
https://codereview.chromium.org/1667003002/


Refactor the QuicPacketCreatorTest to make it easier to flatten
QuicEncryptedPacket into SerializedPacket.

n/a(Test Only)

Merge internal change: 113395732
https://codereview.chromium.org/1665973003/


Refactor QuicCryptoClientStream to use QuicSession directly.

Merge internal change: 113372125
https://codereview.chromium.org/1665743003/


Move the check for QUIC silent close from SendConnectionClosePacket, to
CheckForTimeout.

Merge internal change: 113297234
https://codereview.chromium.org/1664973002/


Rename QUIC connection timeout error codes to be more descriptive.
No behavior change.

Renames:

QUIC_CONNECTION_TIMED_OUT -> QUIC_NETWORK_IDLE_TIMEOUT
QUIC_CONNECTION_OVERALL_TIMED_OUT -> QUIC_HANDSHAKE_TIMEOUT

To future Chromium merger: You will need to update histograms.xml in
Chromium, for the mapping from error code -> UMA string.

Merge internal change: 113294280
https://codereview.chromium.org/1664763003/


Change server push unit tests of quic toy server session to make tests
pass when FLAGS_quic_cede_correctly is true.

Since cl/112799471 changes quic priority behavior of connection level
flow control blocked streams, and currently the server push unit tests
uses connection level flow control to keep push streams open, the tests
failed when new behavior is introduced. This CL changes the tests to use
stream level flow control instead of connection level.

Merge internal change: 113275797
https://codereview.chromium.org/1662083003/

R=rch@chromium.org
==========

to

==========
Landing Recent QUIC changes until 01/31/2016 05:22 UTC


Replace QuicEncryptedPacket's fields with equivalents in SerializedPacket.
No functional change.

Merge internal change: 113458293
https://codereview.chromium.org/1667003002/


Refactor the QuicPacketCreatorTest to make it easier to flatten
QuicEncryptedPacket into SerializedPacket.

n/a(Test Only)

Merge internal change: 113395732
https://codereview.chromium.org/1665973003/


Refactor QuicCryptoClientStream to use QuicSession directly.

Merge internal change: 113372125
https://codereview.chromium.org/1665743003/


Move the check for QUIC silent close from SendConnectionClosePacket, to
CheckForTimeout.

Merge internal change: 113297234
https://codereview.chromium.org/1664973002/


Rename QUIC connection timeout error codes to be more descriptive.
No behavior change.

Renames:

QUIC_CONNECTION_TIMED_OUT -> QUIC_NETWORK_IDLE_TIMEOUT
QUIC_CONNECTION_OVERALL_TIMED_OUT -> QUIC_HANDSHAKE_TIMEOUT

To future Chromium merger: You will need to update histograms.xml in
Chromium, for the mapping from error code -> UMA string.

Merge internal change: 113294280
https://codereview.chromium.org/1664763003/


Change server push unit tests of quic toy server session to make tests
pass when FLAGS_quic_cede_correctly is true.

Since cl/112799471 changes quic priority behavior of connection level
flow control blocked streams, and currently the server push unit tests
uses connection level flow control to keep push streams open, the tests
failed when new behavior is introduced. This CL changes the tests to use
stream level flow control instead of connection level.

Merge internal change: 113275797
https://codereview.chromium.org/1662083003/

R=rch@chromium.org,  eroman@chromium.org, ttuttle@chromium.org,
==========

[ramant (doing other things), 2016-02-04 07:24:13]

rtenneti@chromium.org changed reviewers:
+ eroman@chromium.org, ttuttle@chromium.org

[ramant (doing other things), 2016-02-04 07:30:49]

Hi Eric and Julia,
  Would appreciate if you could take a look at the name change of QUIC error
codes and give OWNERS approval for the following changes.

+ eroman for chrome/test/data/webui/net_internals/log_view_painter.js

+ Julia for domain reliability changes
 
  Porting the cl from internal
to chromium, need to keep quic_error_map in util.cc in sync with quic_protocol.

  The following is the internal CL that did the renaming.

      https://codereview.chromium.org/1664763003/

Thanks much
raman

[eroman, 2016-02-04 07:42:05]

log_view_painter.js LGTM

[commit-bot: I haz the power, 2016-02-04 08:14:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 08:14:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ramant (doing other things), 2016-02-04 19:11:09]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-04 19:13:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667583004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667583004/60001

[ramant (doing other things), 2016-02-04 19:47:19]

rtenneti@chromium.org changed reviewers:
+ davidben@chromium.org

[ramant (doing other things), 2016-02-04 19:48:42]

Hi David and Julia,
  Could you give OWNERS approval for components/domain_reliability/util.cc?

Thanks

[commit-bot: I haz the power, 2016-02-04 21:06:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 21:06:38]

Dry run: This issue passed the CQ dry run.

[Deprecated (see juliatuttle), 2016-02-04 22:35:38]

On 2016/02/04 21:06:38, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

lgtm

[ramant (doing other things), 2016-02-04 22:56:06]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-02-04 22:56:07]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org,
eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1667583004/#ps60001
(title: "fix unittests")

[commit-bot: I haz the power, 2016-02-04 22:58:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667583004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667583004/60001

[commit-bot: I haz the power, 2016-02-04 23:12:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-04 23:12:54]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ramant (doing other things), 2016-02-05 00:34:29]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-02-05 00:34:29]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org,
ttuttle@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1667583004/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-02-05 00:39:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1667583004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1667583004/80001

[commit-bot: I haz the power, 2016-02-05 02:21:40]

Description was changed from

==========
Landing Recent QUIC changes until 01/31/2016 05:22 UTC


Replace QuicEncryptedPacket's fields with equivalents in SerializedPacket.
No functional change.

Merge internal change: 113458293
https://codereview.chromium.org/1667003002/


Refactor the QuicPacketCreatorTest to make it easier to flatten
QuicEncryptedPacket into SerializedPacket.

n/a(Test Only)

Merge internal change: 113395732
https://codereview.chromium.org/1665973003/


Refactor QuicCryptoClientStream to use QuicSession directly.

Merge internal change: 113372125
https://codereview.chromium.org/1665743003/


Move the check for QUIC silent close from SendConnectionClosePacket, to
CheckForTimeout.

Merge internal change: 113297234
https://codereview.chromium.org/1664973002/


Rename QUIC connection timeout error codes to be more descriptive.
No behavior change.

Renames:

QUIC_CONNECTION_TIMED_OUT -> QUIC_NETWORK_IDLE_TIMEOUT
QUIC_CONNECTION_OVERALL_TIMED_OUT -> QUIC_HANDSHAKE_TIMEOUT

To future Chromium merger: You will need to update histograms.xml in
Chromium, for the mapping from error code -> UMA string.

Merge internal change: 113294280
https://codereview.chromium.org/1664763003/


Change server push unit tests of quic toy server session to make tests
pass when FLAGS_quic_cede_correctly is true.

Since cl/112799471 changes quic priority behavior of connection level
flow control blocked streams, and currently the server push unit tests
uses connection level flow control to keep push streams open, the tests
failed when new behavior is introduced. This CL changes the tests to use
stream level flow control instead of connection level.

Merge internal change: 113275797
https://codereview.chromium.org/1662083003/

R=rch@chromium.org,  eroman@chromium.org, ttuttle@chromium.org,
==========

to

==========
Landing Recent QUIC changes until 01/31/2016 05:22 UTC


Replace QuicEncryptedPacket's fields with equivalents in SerializedPacket.
No functional change.

Merge internal change: 113458293
https://codereview.chromium.org/1667003002/


Refactor the QuicPacketCreatorTest to make it easier to flatten
QuicEncryptedPacket into SerializedPacket.

n/a(Test Only)

Merge internal change: 113395732
https://codereview.chromium.org/1665973003/


Refactor QuicCryptoClientStream to use QuicSession directly.

Merge internal change: 113372125
https://codereview.chromium.org/1665743003/


Move the check for QUIC silent close from SendConnectionClosePacket, to
CheckForTimeout.

Merge internal change: 113297234
https://codereview.chromium.org/1664973002/


Rename QUIC connection timeout error codes to be more descriptive.
No behavior change.

Renames:

QUIC_CONNECTION_TIMED_OUT -> QUIC_NETWORK_IDLE_TIMEOUT
QUIC_CONNECTION_OVERALL_TIMED_OUT -> QUIC_HANDSHAKE_TIMEOUT

To future Chromium merger: You will need to update histograms.xml in
Chromium, for the mapping from error code -> UMA string.

Merge internal change: 113294280
https://codereview.chromium.org/1664763003/


Change server push unit tests of quic toy server session to make tests
pass when FLAGS_quic_cede_correctly is true.

Since cl/112799471 changes quic priority behavior of connection level
flow control blocked streams, and currently the server push unit tests
uses connection level flow control to keep push streams open, the tests
failed when new behavior is introduced. This CL changes the tests to use
stream level flow control instead of connection level.

Merge internal change: 113275797
https://codereview.chromium.org/1662083003/

R=rch@chromium.org,  eroman@chromium.org, ttuttle@chromium.org,
==========

[commit-bot: I haz the power, 2016-02-05 02:21:41]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-05 02:22:47]

Description was changed from

==========
Landing Recent QUIC changes until 01/31/2016 05:22 UTC


Replace QuicEncryptedPacket's fields with equivalents in SerializedPacket.
No functional change.

Merge internal change: 113458293
https://codereview.chromium.org/1667003002/


Refactor the QuicPacketCreatorTest to make it easier to flatten
QuicEncryptedPacket into SerializedPacket.

n/a(Test Only)

Merge internal change: 113395732
https://codereview.chromium.org/1665973003/


Refactor QuicCryptoClientStream to use QuicSession directly.

Merge internal change: 113372125
https://codereview.chromium.org/1665743003/


Move the check for QUIC silent close from SendConnectionClosePacket, to
CheckForTimeout.

Merge internal change: 113297234
https://codereview.chromium.org/1664973002/


Rename QUIC connection timeout error codes to be more descriptive.
No behavior change.

Renames:

QUIC_CONNECTION_TIMED_OUT -> QUIC_NETWORK_IDLE_TIMEOUT
QUIC_CONNECTION_OVERALL_TIMED_OUT -> QUIC_HANDSHAKE_TIMEOUT

To future Chromium merger: You will need to update histograms.xml in
Chromium, for the mapping from error code -> UMA string.

Merge internal change: 113294280
https://codereview.chromium.org/1664763003/


Change server push unit tests of quic toy server session to make tests
pass when FLAGS_quic_cede_correctly is true.

Since cl/112799471 changes quic priority behavior of connection level
flow control blocked streams, and currently the server push unit tests
uses connection level flow control to keep push streams open, the tests
failed when new behavior is introduced. This CL changes the tests to use
stream level flow control instead of connection level.

Merge internal change: 113275797
https://codereview.chromium.org/1662083003/

R=rch@chromium.org,  eroman@chromium.org, ttuttle@chromium.org,
==========

to

==========
Landing Recent QUIC changes until 01/31/2016 05:22 UTC

Replace QuicEncryptedPacket's fields with equivalents in SerializedPacket.
No functional change.

Merge internal change: 113458293
https://codereview.chromium.org/1667003002/

Refactor the QuicPacketCreatorTest to make it easier to flatten
QuicEncryptedPacket into SerializedPacket.

n/a(Test Only)

Merge internal change: 113395732
https://codereview.chromium.org/1665973003/

Refactor QuicCryptoClientStream to use QuicSession directly.

Merge internal change: 113372125
https://codereview.chromium.org/1665743003/

Move the check for QUIC silent close from SendConnectionClosePacket, to
CheckForTimeout.

Merge internal change: 113297234
https://codereview.chromium.org/1664973002/

Rename QUIC connection timeout error codes to be more descriptive.
No behavior change.

Renames:

QUIC_CONNECTION_TIMED_OUT -> QUIC_NETWORK_IDLE_TIMEOUT
QUIC_CONNECTION_OVERALL_TIMED_OUT -> QUIC_HANDSHAKE_TIMEOUT

To future Chromium merger: You will need to update histograms.xml in
Chromium, for the mapping from error code -> UMA string.

Merge internal change: 113294280
https://codereview.chromium.org/1664763003/

Change server push unit tests of quic toy server session to make tests
pass when FLAGS_quic_cede_correctly is true.

Since cl/112799471 changes quic priority behavior of connection level
flow control blocked streams, and currently the server push unit tests
uses connection level flow control to keep push streams open, the tests
failed when new behavior is introduced. This CL changes the tests to use
stream level flow control instead of connection level.

Merge internal change: 113275797
https://codereview.chromium.org/1662083003/

R=rch@chromium.org,  eroman@chromium.org, ttuttle@chromium.org,

Committed: https://crrev.com/2cae207e31716451b665dd11b3a21262e3e7a2e3
Cr-Commit-Position: refs/heads/master@{#373723}
==========

[commit-bot: I haz the power, 2016-02-05 02:22:48]

Patchset 5 (id:??) landed as
https://crrev.com/2cae207e31716451b665dd11b3a21262e3e7a2e3
Cr-Commit-Position: refs/heads/master@{#373723}