Revert "Revert of QUIC - Race Cert Verification with host resolution if

Revert "Revert of QUIC - Race Cert Verification with host resolution if
certs are (patchset #4 id:100001 of
https://codereview.chromium.org/2120703003/ )"

This reverts commit 379ab0ffcbdfe9012f972a44ca42cb84b9789fa1.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Reason for revert: Relanding with a minor fix to cronet unit tests.

Original issue's description:
> QUIC - Race Cert Verification with host resolution if certs are
> availiable when race_cert_verification network session param is enabled.
>
> This experiment is not enabled in chromium.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
> TBR=eroman@chromium.org (for net-internals changes)
>
> Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
> Cr-Commit-Position: refs/heads/master@{#404296}

TBR=eroman@chromium.org,mef@chromium.org,rch@chromium.org,rtenneti@chromium.org

[ramant (doing other things), 2016-07-08 18:01:56]

Description was changed from

==========
Revert "Revert of QUIC - Race Cert Verification with host resolution if
certs are (patchset #4 id:100001 of
https://codereview.chromium.org/2120703003/ )"

This reverts commit 379ab0ffcbdfe9012f972a44ca42cb84b9789fa1.
==========

to

==========
Revert "Revert of QUIC - Race Cert Verification with host resolution if
certs are (patchset #4 id:100001 of
https://codereview.chromium.org/2120703003/ )"

This reverts commit 379ab0ffcbdfe9012f972a44ca42cb84b9789fa1.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[ramant (doing other things), 2016-07-08 18:04:04]

Description was changed from

==========
Revert "Revert of QUIC - Race Cert Verification with host resolution if
certs are (patchset #4 id:100001 of
https://codereview.chromium.org/2120703003/ )"

This reverts commit 379ab0ffcbdfe9012f972a44ca42cb84b9789fa1.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Revert "Revert of QUIC - Race Cert Verification with host resolution if
certs are (patchset #4 id:100001 of
https://codereview.chromium.org/2120703003/ )"

This reverts commit 379ab0ffcbdfe9012f972a44ca42cb84b9789fa1.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Original issue's description:
> QUIC - Race Cert Verification with host resolution if certs are
> availiable when race_cert_verification network session param is enabled.
>
> This experiment is not enabled in chromium.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
> TBR=eroman@chromium.org (for net-internals changes)
>
> Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
> Cr-Commit-Position: refs/heads/master@{#404296}

TBR=eroman@chromium.org,mef@chromium.org,rch@chromium.org,rtenneti@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

[ramant (doing other things), 2016-07-08 18:04:05]

rtenneti@chromium.org changed reviewers:
+ eroman@chromium.org, mef@chromium.org, rch@chromium.org

[ramant (doing other things), 2016-07-08 18:05:32]

Description was changed from

==========
Revert "Revert of QUIC - Race Cert Verification with host resolution if
certs are (patchset #4 id:100001 of
https://codereview.chromium.org/2120703003/ )"

This reverts commit 379ab0ffcbdfe9012f972a44ca42cb84b9789fa1.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Original issue's description:
> QUIC - Race Cert Verification with host resolution if certs are
> availiable when race_cert_verification network session param is enabled.
>
> This experiment is not enabled in chromium.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
> TBR=eroman@chromium.org (for net-internals changes)
>
> Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
> Cr-Commit-Position: refs/heads/master@{#404296}

TBR=eroman@chromium.org,mef@chromium.org,rch@chromium.org,rtenneti@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert "Revert of QUIC - Race Cert Verification with host resolution if
certs are (patchset #4 id:100001 of
https://codereview.chromium.org/2120703003/ )"

This reverts commit 379ab0ffcbdfe9012f972a44ca42cb84b9789fa1.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Reason for revert: Relanding with a minor fix to cronet unit tests.

Original issue's description:
> QUIC - Race Cert Verification with host resolution if certs are
> availiable when race_cert_verification network session param is enabled.
>
> This experiment is not enabled in chromium.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
> TBR=eroman@chromium.org (for net-internals changes)
>
> Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
> Cr-Commit-Position: refs/heads/master@{#404296}

TBR=eroman@chromium.org,mef@chromium.org,rch@chromium.org,rtenneti@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

[ramant (doing other things), 2016-07-08 18:06:12]

Description was changed from

==========
Revert "Revert of QUIC - Race Cert Verification with host resolution if
certs are (patchset #4 id:100001 of
https://codereview.chromium.org/2120703003/ )"

This reverts commit 379ab0ffcbdfe9012f972a44ca42cb84b9789fa1.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Reason for revert: Relanding with a minor fix to cronet unit tests.

Original issue's description:
> QUIC - Race Cert Verification with host resolution if certs are
> availiable when race_cert_verification network session param is enabled.
>
> This experiment is not enabled in chromium.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
> TBR=eroman@chromium.org (for net-internals changes)
>
> Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
> Cr-Commit-Position: refs/heads/master@{#404296}

TBR=eroman@chromium.org,mef@chromium.org,rch@chromium.org,rtenneti@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert "Revert of QUIC - Race Cert Verification with host resolution if
certs are (patchset #4 id:100001 of
https://codereview.chromium.org/2120703003/ )"

This reverts commit 379ab0ffcbdfe9012f972a44ca42cb84b9789fa1.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Reason for revert: Relanding with a minor fix to cronet unit tests.

Original issue's description:
> QUIC - Race Cert Verification with host resolution if certs are
> availiable when race_cert_verification network session param is enabled.
>
> This experiment is not enabled in chromium.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
> TBR=eroman@chromium.org (for net-internals changes)
>
> Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
> Cr-Commit-Position: refs/heads/master@{#404296}

TBR=eroman@chromium.org,mef@chromium.org,rch@chromium.org,rtenneti@chromium.org
==========

[ramant (doing other things), 2016-07-08 18:06:22]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 18:06:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2016-07-08 19:18:37]

https://codereview.chromium.org/2129263002/diff/1/components/cronet/url_reque...
File components/cronet/url_request_context_config_unittest.cc (right):

https://codereview.chromium.org/2129263002/diff/1/components/cronet/url_reque...
components/cronet/url_request_context_config_unittest.cc:50:
"\"race_cert_verification\":true,"
Hrm, I think this should still fail, right?

[commit-bot: I haz the power, 2016-07-08 19:21:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 19:21:18]

Dry run: This issue passed the CQ dry run.

[ramant (doing other things), 2016-07-08 21:10:10]

Thanks Misha fixed cronet test failure.

https://codereview.chromium.org/2129263002/diff/1/components/cronet/url_reque...
File components/cronet/url_request_context_config_unittest.cc (right):

https://codereview.chromium.org/2129263002/diff/1/components/cronet/url_reque...
components/cronet/url_request_context_config_unittest.cc:50:
"\"race_cert_verification\":true,"
On 2016/07/08 19:18:37, mef wrote:
> Hrm, I think this should still fail, right?

You are right. Moved line#50 to after line#48. Was working on chromium builds
before. Verified this test passes cronet_unittests

[ramant (doing other things), 2016-07-08 21:12:08]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-07-08 21:12:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2016-07-08 22:06:55]

I assume that net/quic/* changes are result of sync, right?

Also, would it make sense to rather re-land original CL?

[ramant (doing other things), 2016-07-08 22:12:57]

The CQ bit was unchecked by rtenneti@chromium.org

[ramant (doing other things), 2016-07-08 22:13:41]

On 2016/07/08 22:06:55, mef wrote:
> I assume that net/quic/* changes are result of sync, right?

Right.

> 
> Also, would it make sense to rather re-land original CL?

Will do.

thanks
raman

[ramant (doing other things), 2016-07-09 00:29:30]

Closed this issued. Submitting the original CL:
https://codereview.chromium.org/2120703003/