Cronet/QUIC - Added histograms to measure the time spent to seriliaze

Cronet/QUIC - Added histograms to measure the time spent to seriliaze
and deserialize CachingCertVerifier's cache.

BUG=636492
R=mef@chromium.org, rkaplow@chromium.org,

Committed: https://crrev.com/674177e3bb34ea0747b877e2ce11e41e9a1adfcd
Cr-Commit-Position: refs/heads/master@{#411463}

[ramant (doing other things), 2016-08-10 19:15:08]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 19:15:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ramant (doing other things), 2016-08-10 19:19:18]

Description was changed from

==========
Cronet/QUIC - Added histograms to measure the time spent to seriliaze
and deserialize CachingCertVerifier's cache.

BUG=636492
==========

to

==========
Cronet/QUIC - Added histograms to measure the time spent to seriliaze
and deserialize CachingCertVerifier's cache.

BUG=636492
R=mef@chromium.org, rkaplow@chromium.org,
==========

[ramant (doing other things), 2016-08-10 19:19:18]

rtenneti@chromium.org changed reviewers:
+ mef@chromium.org, rkaplow@chromium.org

[ramant (doing other things), 2016-08-10 20:20:07]

Hi Misha,
  Each app of cronet will have their own histograms. What do you think of adding
the histogram at this layer? (every app which uses cronet, we will have their
own histograms data).

thanks
raman

[rkaplow, 2016-08-10 20:22:26]

rkaplow@chromium.org changed reviewers:
+ gayane@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:24:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:24:06]

Dry run: This issue passed the CQ dry run.

[gayane -on leave until 09-2017, 2016-08-11 15:37:02]

lgtm

[gayane -on leave until 09-2017, 2016-08-11 15:37:06]

lgtm

[mef, 2016-08-11 15:49:23]

lgtm

[ramant (doing other things), 2016-08-11 17:03:39]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-08-11 17:04:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ramant (doing other things), 2016-08-11 17:04:09]

The CQ bit was unchecked by rtenneti@chromium.org

[ramant (doing other things), 2016-08-11 17:05:08]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-08-11 17:05:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 17:11:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 17:11:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ramant (doing other things), 2016-08-11 17:13:37]

On 2016/08/11 17:11:46, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Will wait for rkaplow's approval. Thought gayne@ was in the OWNERS. Thanks
gayne@ for the review.

[rkaplow, 2016-08-11 17:14:23]

lgtm

https://codereview.chromium.org/2237603002/diff/1/components/cronet/android/c...
File components/cronet/android/cronet_url_request_context_adapter.cc (right):

https://codereview.chromium.org/2237603002/diff/1/components/cronet/android/c...
components/cronet/android/cronet_url_request_context_adapter.cc:817:
UMA_HISTOGRAM_TIMES("Net.Cronet.CertVerifierCache.SerializeTime",
you can simplify this using a SCOPED_UMA_HISTOGRAM_TIMER

[ramant (doing other things), 2016-08-11 17:21:15]

https://codereview.chromium.org/2237603002/diff/1/components/cronet/android/c...
File components/cronet/android/cronet_url_request_context_adapter.cc (right):

https://codereview.chromium.org/2237603002/diff/1/components/cronet/android/c...
components/cronet/android/cronet_url_request_context_adapter.cc:817:
UMA_HISTOGRAM_TIMES("Net.Cronet.CertVerifierCache.SerializeTime",
On 2016/08/11 17:14:23, rkaplow wrote:
> you can simplify this using a SCOPED_UMA_HISTOGRAM_TIMER

Done.

[ramant (doing other things), 2016-08-11 17:21:29]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-08-11 17:21:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org,
rkaplow@chromium.org, gayane@chromium.org
Link to the patchset: https://codereview.chromium.org/2237603002/#ps20001
(title: "Use SCOPED_UMA_HISTOGRAM_TIMER.")

[commit-bot: I haz the power, 2016-08-11 17:22:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 17:37:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 17:37:47]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[ramant (doing other things), 2016-08-11 17:50:22]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-08-11 17:50:22]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org,
rkaplow@chromium.org, gayane@chromium.org
Link to the patchset: https://codereview.chromium.org/2237603002/#ps40001
(title: "rebase TOT")

[commit-bot: I haz the power, 2016-08-11 17:50:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 19:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 19:02:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ramant (doing other things), 2016-08-11 19:07:02]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-08-11 19:07:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 21:34:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 21:35:00]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ramant (doing other things), 2016-08-11 22:52:45]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-08-11 22:54:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 00:10:43]

Description was changed from

==========
Cronet/QUIC - Added histograms to measure the time spent to seriliaze
and deserialize CachingCertVerifier's cache.

BUG=636492
R=mef@chromium.org, rkaplow@chromium.org,
==========

to

==========
Cronet/QUIC - Added histograms to measure the time spent to seriliaze
and deserialize CachingCertVerifier's cache.

BUG=636492
R=mef@chromium.org, rkaplow@chromium.org,
==========

[commit-bot: I haz the power, 2016-08-12 00:10:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-12 00:14:02]

Description was changed from

==========
Cronet/QUIC - Added histograms to measure the time spent to seriliaze
and deserialize CachingCertVerifier's cache.

BUG=636492
R=mef@chromium.org, rkaplow@chromium.org,
==========

to

==========
Cronet/QUIC - Added histograms to measure the time spent to seriliaze
and deserialize CachingCertVerifier's cache.

BUG=636492
R=mef@chromium.org, rkaplow@chromium.org,

Committed: https://crrev.com/674177e3bb34ea0747b877e2ce11e41e9a1adfcd
Cr-Commit-Position: refs/heads/master@{#411463}
==========

[commit-bot: I haz the power, 2016-08-12 00:14:03]

Patchset 3 (id:??) landed as
https://crrev.com/674177e3bb34ea0747b877e2ce11e41e9a1adfcd
Cr-Commit-Position: refs/heads/master@{#411463}