Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1998863002:
QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection (Closed)
|
Created:
4 years, 7 months ago by ramant (doing other things) Modified:
4 years, 7 months ago Reviewers:
Ryan Hamilton CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionQUIC - added disable_delay_tcp_race field trial param to disable
delaying of racing TCP connection.
When this param is set to true, TCP and QUIC connections will be raced
without any delay.
BUG=613259
R=rch@chromium.org
Committed: https://crrev.com/977b13bbcc96e7dd1cf500909e29c677e8257776
Cr-Commit-Position: refs/heads/master@{#395688}
Patch Set 1 #
Total comments: 3
Patch Set 2 : added disable_delay_tcp_race field trial param #Patch Set 3 : Rebase with TOT - moved the code to components #
Depends on Patchset: Messages
Total messages: 25 (12 generated)
The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998863002/1
https://codereview.chromium.org/1998863002/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/1998863002/diff/1/chrome/browser/io_thread.cc... chrome/browser/io_thread.cc:1454: std::string delay_tcp_race = GetVariationParam(quic_trial_params, Hi Ryan, Another option is to rename this parameter to "disable_delay_tcp_race" and change all the code accordingly. What do you think? thanks raman
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
https://codereview.chromium.org/1998863002/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/1998863002/diff/1/chrome/browser/io_thread.cc... chrome/browser/io_thread.cc:1454: std::string delay_tcp_race = GetVariationParam(quic_trial_params, Yeah, it seems like that would be a better idea.
Description was changed from ========== QUIC - delay_tcp_race should default to true if delay_tcp_race field trail param is not set. BUG=613259 R=rch@chromium.org ========== to ========== QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection. When this param is set to true, TCP and QUIC connections will be raced without any delay. BUG=613259 R=rch@chromium.org ==========
The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998863002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection. When this param is set to true, TCP and QUIC connections will be raced without any delay. BUG=613259 R=rch@chromium.org ========== to ========== QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection. When this param is set to true, TCP and QUIC connections will be raced without any delay. BUG=613259 R=rch@chromium.org ==========
PTAL. Thanks Ryan. https://codereview.chromium.org/1998863002/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/1998863002/diff/1/chrome/browser/io_thread.cc... chrome/browser/io_thread.cc:1454: std::string delay_tcp_race = GetVariationParam(quic_trial_params, On 2016/05/20 03:17:27, Ryan Hamilton wrote: > Yeah, it seems like that would be a better idea. Done.
lgtm
The CQ bit was checked by rtenneti@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998863002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by rtenneti@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org Link to the patchset: https://codereview.chromium.org/1998863002/#ps40001 (title: "Rebase with TOT - moved the code to components")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1998863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1998863002/40001
Message was sent while issue was closed.
Description was changed from ========== QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection. When this param is set to true, TCP and QUIC connections will be raced without any delay. BUG=613259 R=rch@chromium.org ========== to ========== QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection. When this param is set to true, TCP and QUIC connections will be raced without any delay. BUG=613259 R=rch@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection. When this param is set to true, TCP and QUIC connections will be raced without any delay. BUG=613259 R=rch@chromium.org ========== to ========== QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection. When this param is set to true, TCP and QUIC connections will be raced without any delay. BUG=613259 R=rch@chromium.org Committed: https://crrev.com/977b13bbcc96e7dd1cf500909e29c677e8257776 Cr-Commit-Position: refs/heads/master@{#395688} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/977b13bbcc96e7dd1cf500909e29c677e8257776 Cr-Commit-Position: refs/heads/master@{#395688} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
