Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1523543002:
SPDY Servers - Servers that are restored from preferences maintain MRU order (Closed)
|
Created:
5 years ago by ramant (doing other things) Modified:
5 years ago CC:
chromium-reviews, cbentzel+watch_chromium.org, ianswett Base URL:
https://chromium.googlesource.com/chromium/src.git@mru_cache_swap Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSPDY Servers - Servers that are restored from preferences maintain MRU order
relative to the entries that are already in memory.
If an entry from Preferences is not in the memory, it will be added to
the end of MRU list.
If an entry from Preferences is already in the memory, it will be
updated and its MRU order is maintained.
Entries in the memory that are not in Preferences, maintain their
recency.
BUG=568386
R=bnc@chromium.org, rch@chromium.org
Committed: https://crrev.com/6dd347458f4bdcc934ac91092eacce2dfa3ee097
Cr-Commit-Position: refs/heads/master@{#366154}
Patch Set 1 #Patch Set 2 : Preferences data from disk cache updates memory cache #Patch Set 3 : rebase #
Depends on Patchset: Messages
Total messages: 33 (19 generated)
The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run
Description was changed from ========== SPDY Servers - Servers that are restored from disk are given lower order in the MRUCache than the servers that are already in the memory (because they are the MRU servers). BUG=568386 R=bnc@chromium.org, rch@chromium.org ========== to ========== SPDY Servers - Servers that are restored from disk are given lower order in the MRUCache than the servers that are already in the memory (because they are the MRU servers). BUG=568386 R=bnc@chromium.org, rch@chromium.org ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please hold off reviewing this change. Would like to keep the old logic, in case of conflict, data read from the disk wins (which would allow system administrators to push a change to their users). During my tests, we read HttpServerProperties from disk in the beginning and prefs hasn't called HttpServerProperties to parse from disk again. The above change will impact enterprise customers only (it at all).
Removing myself as a reviewer since this is not ready for review. Happy to be added back when it's ready.
Description was changed from ========== SPDY Servers - Servers that are restored from disk are given lower order in the MRUCache than the servers that are already in the memory (because they are the MRU servers). BUG=568386 R=bnc@chromium.org, rch@chromium.org ========== to ========== SPDY Servers - Servers that are restored from preferences maintain MRU order. If an entry from disk cache is already in the memory it will be updated and its MRU order is maintained. Entries in the memory that are not in disk (Preferences file) maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ==========
Description was changed from ========== SPDY Servers - Servers that are restored from preferences maintain MRU order. If an entry from disk cache is already in the memory it will be updated and its MRU order is maintained. Entries in the memory that are not in disk (Preferences file) maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ========== to ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory If an entry from disk cache is already in the memory it will be updated and ts MRU order is maintained. Entries in the memory that are not in disk (Preferences file) maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ==========
Description was changed from ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory If an entry from disk cache is already in the memory it will be updated and ts MRU order is maintained. Entries in the memory that are not in disk (Preferences file) maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ========== to ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ==========
Description was changed from ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ========== to ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory. If an entry from Preferences is not in the memory, it will be added to the end MRU list. If an entry from Preferences is not in the memory, it will be added to the end MRU list. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ==========
Description was changed from ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory. If an entry from Preferences is not in the memory, it will be added to the end MRU list. If an entry from Preferences is not in the memory, it will be added to the end MRU list. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ========== to ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory. If an entry from Preferences is not in the memory, it will be added to the end of MRU list. If an entry from Preferences is not in the memory, it will be added to the end MRU list. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ==========
Description was changed from ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory. If an entry from Preferences is not in the memory, it will be added to the end of MRU list. If an entry from Preferences is not in the memory, it will be added to the end MRU list. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ========== to ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory. If an entry from Preferences is not in the memory, it will be added to the end of MRU list. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ==========
The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523543002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by rtenneti@chromium.org
The CQ bit was unchecked by rtenneti@chromium.org
PTAL. thanks
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523543002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523543002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by rtenneti@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523543002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523543002/60001
Message was sent while issue was closed.
Description was changed from ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory. If an entry from Preferences is not in the memory, it will be added to the end of MRU list. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ========== to ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory. If an entry from Preferences is not in the memory, it will be added to the end of MRU list. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory. If an entry from Preferences is not in the memory, it will be added to the end of MRU list. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org ========== to ========== SPDY Servers - Servers that are restored from preferences maintain MRU order relative to the entries that are already in memory. If an entry from Preferences is not in the memory, it will be added to the end of MRU list. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org Committed: https://crrev.com/6dd347458f4bdcc934ac91092eacce2dfa3ee097 Cr-Commit-Position: refs/heads/master@{#366154} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6dd347458f4bdcc934ac91092eacce2dfa3ee097 Cr-Commit-Position: refs/heads/master@{#366154} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
