Landing Recent QUIC changes until Sat Aug 13 04:32:36 2016 UTC-0

Landing Recent QUIC changes until Sat Aug 13 04:32:36 2016 UTC-0

Disable QUIC versions less than v32, protected by --FLAGS_quic_disable_pre_32.

Merge internal change: 130168897
https://codereview.chromium.org/2242423002/

chromium relnote: Making QuicTestClient reads mockable.

Internal relnote: Droping expired TTL correctly for outbound packets.

When we switched to doing proper backend picking for UDP proxy sessions,
we also stopped using ProcessPacket for outbound packets, but still left
all the handling code in place, obfuscating the new code path.

This CL removes the lingering code, applies TTL correctly on the
outbound path. This also removes reaping connections during the outbound
path or during write failures, but that simply means we only apply
connection timeouts when getting new incoming traffic which seems
sufficient.

Not flag protected because it's a big messy change.

Merge internal change: 130124951
https://codereview.chromium.org/2242143004/

Stop using next_packet_sequence_number_length in QuicPacketCreator.
ENABLED FLAGS_quic_simple_packet_number_length_2.

There's no functional change here.
We rolled back FLAGS_quic_simple_packet_number_length
because it didn't pick up the fix to b/29095779
cr/129995365 fixes that, so as that fix rolls out it's safe to turn
FLAGS_quic_simple_packet_number_length on again.

Merge internal change: 130113504
https://codereview.chromium.org/2242413002/

Use the new error code QUIC_UNSUPPORTED_PROOF_DEMAND instead of
QUIC_INVALID_CRYPTO_MESSAGE_PARAMETER when an invalid proof demand is
encountered.

Merge internal change: 130098258
https://codereview.chromium.org/2246203003/

Log info about QUIC inchoate rejects, since we expect to "never" generate
them.

Merge internal change: 130066892
https://codereview.chromium.org/2246253002/

Remove QuicUtils::ListTags and use ToDebugString() instead.

Merge internal change: 130064080
https://codereview.chromium.org/2246843005/

Convert a few lingering DFATALs to QUIC_BUG. Not flag protected.

Merge internal change: 129676537
https://codereview.chromium.org/2252513002/

Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. Test-only
change, not flag protected.

Merge internal change: 129661292
https://codereview.chromium.org/2249813002/

R=rch@chromium.org

Committed: https://crrev.com/69a9bcd7462dbdf9677202438a7c3f33b7d286b3
Cr-Commit-Position: refs/heads/master@{#412281}

[ramant (doing other things), 2016-08-15 23:22:32]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 23:22:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-08-15 23:25:31]

lgtm

[ramant (doing other things), 2016-08-15 23:27:14]

The CQ bit was unchecked by rtenneti@chromium.org

[ramant (doing other things), 2016-08-15 23:27:20]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-08-15 23:27:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 23:41:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 23:41:49]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[ramant (doing other things), 2016-08-16 16:54:42]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-08-16 16:54:42]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2241183004/#ps20001
(title: "Fix compiler error.")

[commit-bot: I haz the power, 2016-08-16 16:55:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 17:49:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-16 17:52:11]

Description was changed from

==========
Landing Recent QUIC changes until Sat Aug 13 04:32:36 2016 UTC-0

Disable QUIC versions less than v32, protected by --FLAGS_quic_disable_pre_32.

Merge internal change: 130168897
https://codereview.chromium.org/2242423002/


chromium relnote: Making QuicTestClient reads mockable.

Internal relnote: Droping expired TTL correctly for outbound packets.

When we switched to doing proper backend picking for UDP proxy sessions,
we also stopped using ProcessPacket for outbound packets, but still left
all the handling code in place, obfuscating the new code path.

This CL removes the lingering code, applies TTL correctly on the
outbound path. This also removes reaping connections during the outbound
path or during write failures, but that simply means we only apply
connection timeouts when getting new incoming traffic which seems
sufficient.

Not flag protected because it's a big messy change.

Merge internal change: 130124951
https://codereview.chromium.org/2242143004/


Stop using next_packet_sequence_number_length in QuicPacketCreator.
ENABLED FLAGS_quic_simple_packet_number_length_2.

There's no functional change here.
We rolled back FLAGS_quic_simple_packet_number_length
because it didn't pick up the fix to b/29095779
cr/129995365 fixes that, so as that fix rolls out it's safe to turn
FLAGS_quic_simple_packet_number_length on again.

Merge internal change: 130113504
https://codereview.chromium.org/2242413002/


Use the new error code QUIC_UNSUPPORTED_PROOF_DEMAND instead of
QUIC_INVALID_CRYPTO_MESSAGE_PARAMETER when an invalid proof demand is
encountered.

Merge internal change: 130098258
https://codereview.chromium.org/2246203003/


Log info about QUIC inchoate rejects, since we expect to "never" generate
them.

Merge internal change: 130066892
https://codereview.chromium.org/2246253002/


Remove QuicUtils::ListTags and use ToDebugString() instead.

Merge internal change: 130064080
https://codereview.chromium.org/2246843005/


Convert a few lingering DFATALs to QUIC_BUG. Not flag protected.

Merge internal change: 129676537
https://codereview.chromium.org/2252513002/


Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. Test-only
change, not flag protected.

Merge internal change: 129661292
https://codereview.chromium.org/2249813002/

R=rch@chromium.org
==========

to

==========
Landing Recent QUIC changes until Sat Aug 13 04:32:36 2016 UTC-0

Disable QUIC versions less than v32, protected by --FLAGS_quic_disable_pre_32.

Merge internal change: 130168897
https://codereview.chromium.org/2242423002/

chromium relnote: Making QuicTestClient reads mockable.

Internal relnote: Droping expired TTL correctly for outbound packets.

When we switched to doing proper backend picking for UDP proxy sessions,
we also stopped using ProcessPacket for outbound packets, but still left
all the handling code in place, obfuscating the new code path.

This CL removes the lingering code, applies TTL correctly on the
outbound path. This also removes reaping connections during the outbound
path or during write failures, but that simply means we only apply
connection timeouts when getting new incoming traffic which seems
sufficient.

Not flag protected because it's a big messy change.

Merge internal change: 130124951
https://codereview.chromium.org/2242143004/

Stop using next_packet_sequence_number_length in QuicPacketCreator.
ENABLED FLAGS_quic_simple_packet_number_length_2.

There's no functional change here.
We rolled back FLAGS_quic_simple_packet_number_length
because it didn't pick up the fix to b/29095779
cr/129995365 fixes that, so as that fix rolls out it's safe to turn
FLAGS_quic_simple_packet_number_length on again.

Merge internal change: 130113504
https://codereview.chromium.org/2242413002/

Use the new error code QUIC_UNSUPPORTED_PROOF_DEMAND instead of
QUIC_INVALID_CRYPTO_MESSAGE_PARAMETER when an invalid proof demand is
encountered.

Merge internal change: 130098258
https://codereview.chromium.org/2246203003/

Log info about QUIC inchoate rejects, since we expect to "never" generate
them.

Merge internal change: 130066892
https://codereview.chromium.org/2246253002/

Remove QuicUtils::ListTags and use ToDebugString() instead.

Merge internal change: 130064080
https://codereview.chromium.org/2246843005/

Convert a few lingering DFATALs to QUIC_BUG. Not flag protected.

Merge internal change: 129676537
https://codereview.chromium.org/2252513002/

Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. Test-only
change, not flag protected.

Merge internal change: 129661292
https://codereview.chromium.org/2249813002/

R=rch@chromium.org

Committed: https://crrev.com/69a9bcd7462dbdf9677202438a7c3f33b7d286b3
Cr-Commit-Position: refs/heads/master@{#412281}
==========

[commit-bot: I haz the power, 2016-08-16 17:52:12]

Patchset 2 (id:??) landed as
https://crrev.com/69a9bcd7462dbdf9677202438a7c3f33b7d286b3
Cr-Commit-Position: refs/heads/master@{#412281}