Landing Recent QUIC changes until 01/26/2016 18:14 UTC

Landing Recent QUIC changes until 01/26/2016 18:14 UTC

Per-packet options now passed through to QuicPacketWriter, instead of
through PerConnectionPacketWriter side channels. No functional change.
Guarded by FLAGS_quic_connection_use_shared_writer (this flag is not
used in chromium code base).

This is being done mostly to avoid a few cache misses, though in
practice the performance improvement is in the noise. If nothing else,
all of the costs associated with ???PerConnectionPacketWriter are now
gone from the profile.

Merge internal change: 113068996
https://codereview.chromium.org/1662433002/

Improve loggging to debug invalid acks.  No functional change.

Merge internal change: 113054959
https://codereview.chromium.org/1658923003/

Remove the flag which disables non NAT address migration.

Deprecate FLAGS_quic_disable_non_nat_address_migration

Merge internal change: 113053115
https://codereview.chromium.org/1656943004/

changes QUIC negotiation about max open streams which effects server
create outgoing stream and client create incoming stream behaviors which
are not in use yet.Flag protected by FLAGS_quic_different_max_num_open_streams.

Seperate max_open_stream_ to be max_open_incoming/outgoing_stream_ to
make creating outgoing stream strickly below max open stream limit but
creating incoming stream a little above limit in case of race condition.
This cl is to make server push to work in the same way as client sending
requests.

Merge internal change: 113049250
https://codereview.chromium.org/1651153005/

Fix an incorrect QUIC connection close value introduced in internal
change: 85584634.

Very small functional change.

Merge internal change: 113042237
https://codereview.chromium.org/1651423002/

Deprecate FLAGS_quic_track_single_retransmission.

Merge internal change: 112992608
https://codereview.chromium.org/1658993002/

QuicCryptoProof now takes a ref to the Config instead of its SCID

Merge internal change: 112982932
https://codereview.chromium.org/1660443002/

Remove VisitorShim and move shim behavior into QuicConnection.
No functional change. Not flag protected.

This is part of a broader attempt to remove spurious cache misses,
pointer dereferences, and memory allocations.

Merge internal change: 112982328
https://codereview.chromium.org/1659733003/

Deprecate FLAGS_quic_enable_arena_allocation.

Merge internal change: 112975672
https://codereview.chromium.org/1652383002/

Avoid an allocation and cache miss per QuicDispatcher. No functional
change. Not flag protected.

This moves what was in QuicDispatcher::QuicFramerVisitor directly into
QuicDispatcher, removing the need for a scoped_ptr to QuicFramerVisitor.

Merge internal change: 112975578
https://codereview.chromium.org/1652133005/

Deprecate FLAGS_quic_ack_decimation.

Merge internal change: 112965585
https://codereview.chromium.org/1657123002/

R=rch@chromium.org

Committed: https://crrev.com/9f41c0ae5b1e491a33e736d36dc68cc7be532098
Cr-Commit-Position: refs/heads/master@{#373085}

[ramant (doing other things), 2016-02-02 17:42:45]

On 2016/02/02 17:41:03, ramant wrote:

Hi Ryan,
  This CL merges all CL's you have LGTM'ed so far. PTAL.

thanks
raman

[ramant (doing other things), 2016-02-02 17:42:53]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-02 17:43:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1660533002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1660533002/1

[commit-bot: I haz the power, 2016-02-02 19:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 19:13:35]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-02-02 23:16:53]

lgtm

[ramant (doing other things), 2016-02-02 23:40:13]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-02-02 23:46:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1660533002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1660533002/1

[commit-bot: I haz the power, 2016-02-02 23:59:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-03 00:01:57]

Description was changed from

==========
Landing Recent QUIC changes until 01/26/2016 18:14 UTC

Per-packet options now passed through to QuicPacketWriter, instead of
through PerConnectionPacketWriter side channels. No functional change.
Guarded by FLAGS_quic_connection_use_shared_writer (this flag is not
used in chromium code base).

This is being done mostly to avoid a few cache misses, though in
practice the performance improvement is in the noise. If nothing else,
all of the costs associated with ???PerConnectionPacketWriter are now
gone from the profile.

Merge internal change: 113068996
https://codereview.chromium.org/1662433002/


Improve loggging to debug invalid acks.  No functional change.

Merge internal change: 113054959
https://codereview.chromium.org/1658923003/


Remove the flag which disables non NAT address migration.

Deprecate FLAGS_quic_disable_non_nat_address_migration

Merge internal change: 113053115
https://codereview.chromium.org/1656943004/


changes QUIC negotiation about max open streams which effects server
create outgoing stream and client create incoming stream behaviors which
are not in use yet.Flag protected by FLAGS_quic_different_max_num_open_streams.

Seperate max_open_stream_ to be max_open_incoming/outgoing_stream_ to
make creating outgoing stream strickly below max open stream limit but
creating incoming stream a little above limit in case of race condition.
This cl is to make server push to work in the same way as client sending
requests.

Merge internal change: 113049250
https://codereview.chromium.org/1651153005/


Fix an incorrect QUIC connection close value introduced in internal
change: 85584634.

Very small functional change.

Merge internal change: 113042237
https://codereview.chromium.org/1651423002/


Deprecate FLAGS_quic_track_single_retransmission.

Merge internal change: 112992608
https://codereview.chromium.org/1658993002/


QuicCryptoProof now takes a ref to the Config instead of its SCID

Merge internal change: 112982932
https://codereview.chromium.org/1660443002/


Remove VisitorShim and move shim behavior into QuicConnection.
No functional change. Not flag protected.

This is part of a broader attempt to remove spurious cache misses,
pointer dereferences, and memory allocations.

Merge internal change: 112982328
https://codereview.chromium.org/1659733003/


Deprecate FLAGS_quic_enable_arena_allocation.

Merge internal change: 112975672
https://codereview.chromium.org/1652383002/


Avoid an allocation and cache miss per QuicDispatcher. No functional
change. Not flag protected.

This moves what was in QuicDispatcher::QuicFramerVisitor directly into
QuicDispatcher, removing the need for a scoped_ptr to QuicFramerVisitor.

Merge internal change: 112975578
https://codereview.chromium.org/1652133005/


Deprecate FLAGS_quic_ack_decimation.

Merge internal change: 112965585
https://codereview.chromium.org/1657123002/

R=rch@chromium.org
==========

to

==========
Landing Recent QUIC changes until 01/26/2016 18:14 UTC

Per-packet options now passed through to QuicPacketWriter, instead of
through PerConnectionPacketWriter side channels. No functional change.
Guarded by FLAGS_quic_connection_use_shared_writer (this flag is not
used in chromium code base).

This is being done mostly to avoid a few cache misses, though in
practice the performance improvement is in the noise. If nothing else,
all of the costs associated with ???PerConnectionPacketWriter are now
gone from the profile.

Merge internal change: 113068996
https://codereview.chromium.org/1662433002/

Improve loggging to debug invalid acks.  No functional change.

Merge internal change: 113054959
https://codereview.chromium.org/1658923003/

Remove the flag which disables non NAT address migration.

Deprecate FLAGS_quic_disable_non_nat_address_migration

Merge internal change: 113053115
https://codereview.chromium.org/1656943004/

changes QUIC negotiation about max open streams which effects server
create outgoing stream and client create incoming stream behaviors which
are not in use yet.Flag protected by FLAGS_quic_different_max_num_open_streams.

Seperate max_open_stream_ to be max_open_incoming/outgoing_stream_ to
make creating outgoing stream strickly below max open stream limit but
creating incoming stream a little above limit in case of race condition.
This cl is to make server push to work in the same way as client sending
requests.

Merge internal change: 113049250
https://codereview.chromium.org/1651153005/

Fix an incorrect QUIC connection close value introduced in internal
change: 85584634.

Very small functional change.

Merge internal change: 113042237
https://codereview.chromium.org/1651423002/

Deprecate FLAGS_quic_track_single_retransmission.

Merge internal change: 112992608
https://codereview.chromium.org/1658993002/

QuicCryptoProof now takes a ref to the Config instead of its SCID

Merge internal change: 112982932
https://codereview.chromium.org/1660443002/

Remove VisitorShim and move shim behavior into QuicConnection.
No functional change. Not flag protected.

This is part of a broader attempt to remove spurious cache misses,
pointer dereferences, and memory allocations.

Merge internal change: 112982328
https://codereview.chromium.org/1659733003/

Deprecate FLAGS_quic_enable_arena_allocation.

Merge internal change: 112975672
https://codereview.chromium.org/1652383002/

Avoid an allocation and cache miss per QuicDispatcher. No functional
change. Not flag protected.

This moves what was in QuicDispatcher::QuicFramerVisitor directly into
QuicDispatcher, removing the need for a scoped_ptr to QuicFramerVisitor.

Merge internal change: 112975578
https://codereview.chromium.org/1652133005/

Deprecate FLAGS_quic_ack_decimation.

Merge internal change: 112965585
https://codereview.chromium.org/1657123002/

R=rch@chromium.org

Committed: https://crrev.com/9f41c0ae5b1e491a33e736d36dc68cc7be532098
Cr-Commit-Position: refs/heads/master@{#373085}
==========

[commit-bot: I haz the power, 2016-02-03 00:01:57]

Patchset 1 (id:??) landed as
https://crrev.com/9f41c0ae5b1e491a33e736d36dc68cc7be532098
Cr-Commit-Position: refs/heads/master@{#373085}