HttpServerProperties - maintain the MRU order (across browser sessions)

HttpServerProperties - maintain the MRU order (across browser sessions)
when server properties are persisted to disk.

Bumped up the version number. Added code to read the old data and
persist in the new format. Servers are persisted in a vector and each
entry is similar to the old server entry.

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443" : {...}},
              {"0.client-channel.google.com:443" : {...}},
              {"0-edge-chat.facebook.com:443" : {...}},
              ...
          ], ...
     },

BUG=568386
R=rch@chromium.org, bnc@chromium.org

Committed: https://crrev.com/0947b295f71723c990cae276490c708caf6b4642
Cr-Commit-Position: refs/heads/master@{#367621}

[ramant (doing other things), 2015-12-23 03:24:46]

Description was changed from

==========
HttpServerProperties - maintain the MRU order (across browser sessions)
when server properties are persisted to disk.

Bumped up the version number. Added code to read the old data and
persist in the new format. Servers are persisted in a vector and each
entry is similar to the old server entry.

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443", {...}},
              {"0.client-channel.google.com:443", {...}},
              {"0-edge-chat.facebook.com:443", {...}},
              ...
          ], ...
     },


BUG=568386
==========

to

==========
HttpServerProperties - maintain the MRU order (across browser sessions)
when server properties are persisted to disk.

Bumped up the version number. Added code to read the old data and
persist in the new format. Servers are persisted in a vector and each
entry is similar to the old server entry.

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443", {...}},
              {"0.client-channel.google.com:443", {...}},
              {"0-edge-chat.facebook.com:443", {...}},
              ...
          ], ...
     },


BUG=568386
R=rch@chromium.org
==========

[ramant (doing other things), 2015-12-23 03:24:57]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-23 03:25:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545883002/1

[commit-bot: I haz the power, 2015-12-23 04:48:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-23 04:48:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ramant (doing other things), 2016-01-04 19:23:31]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 19:24:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545883002/20001

[ramant (doing other things), 2016-01-04 19:24:55]

Patchset #1 (id:1) has been deleted

[ramant (doing other things), 2016-01-04 19:46:55]

Description was changed from

==========
HttpServerProperties - maintain the MRU order (across browser sessions)
when server properties are persisted to disk.

Bumped up the version number. Added code to read the old data and
persist in the new format. Servers are persisted in a vector and each
entry is similar to the old server entry.

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443", {...}},
              {"0.client-channel.google.com:443", {...}},
              {"0-edge-chat.facebook.com:443", {...}},
              ...
          ], ...
     },


BUG=568386
R=rch@chromium.org
==========

to

==========
HttpServerProperties - maintain the MRU order (across browser sessions)
when server properties are persisted to disk.

Bumped up the version number. Added code to read the old data and
persist in the new format. Servers are persisted in a vector and each
entry is similar to the old server entry.

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443", {...}},
              {"0.client-channel.google.com:443", {...}},
              {"0-edge-chat.facebook.com:443", {...}},
              ...
          ], ...
     },


BUG=568386
R=rch@chromium.org, bnc@chromium.org
==========

[ramant (doing other things), 2016-01-04 19:46:55]

rtenneti@chromium.org changed reviewers:
+ bnc@chromium.org, rch@chromium.org

[commit-bot: I haz the power, 2016-01-04 20:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 20:51:28]

Dry run: This issue passed the CQ dry run.

[ramant (doing other things), 2016-01-04 23:45:57]

Hi Ryan and Bence,
  base::Values don't support persisting std::pair,m thus used list of
dictionaries instead of list of std::pairs.

  Could you take a look at the first cut of this change?

thanks much
raman

https://codereview.chromium.org/1545883002/diff/20001/net/http/http_server_pr...
File net/http/http_server_properties_manager_unittest.cc (right):

https://codereview.chromium.org/1545883002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager_unittest.cc:325:
EXPECT_EQ("mail.google.com", map_it->first.host());
mail.google.com is MRU server. In version 3, MRU order wasn't maintained.

[Ryan Hamilton, 2016-01-05 00:15:42]

The CL description has:

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443", {...}},
              {"0.client-channel.google.com:443", {...}},
              {"0-edge-chat.facebook.com:443", {...}},
              ...
          ], ...
     },


Should it be:

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443": {...}},
              {"0.client-channel.google.com:443": {...}},
              {"0-edge-chat.facebook.com:443": {...}},
              ...
          ], ...
     },

Namely ":" instead of "," in the servers elements?

[Ryan Hamilton, 2016-01-05 00:18:20]

I think this LGTM

https://codereview.chromium.org/1545883002/diff/20001/net/http/http_server_pr...
File net/http/http_server_properties_manager_unittest.cc (right):

https://codereview.chromium.org/1545883002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager_unittest.cc:325:
EXPECT_EQ("mail.google.com", map_it->first.host());
On 2016/01/04 23:45:57, ramant wrote:
> http://mail.google.com is MRU server. In version 3, MRU order wasn't
maintained.

Woo hoo!

[ramant (doing other things), 2016-01-05 00:20:52]

Description was changed from

==========
HttpServerProperties - maintain the MRU order (across browser sessions)
when server properties are persisted to disk.

Bumped up the version number. Added code to read the old data and
persist in the new format. Servers are persisted in a vector and each
entry is similar to the old server entry.

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443", {...}},
              {"0.client-channel.google.com:443", {...}},
              {"0-edge-chat.facebook.com:443", {...}},
              ...
          ], ...
     },


BUG=568386
R=rch@chromium.org, bnc@chromium.org
==========

to

==========
HttpServerProperties - maintain the MRU order (across browser sessions)
when server properties are persisted to disk.

Bumped up the version number. Added code to read the old data and
persist in the new format. Servers are persisted in a vector and each
entry is similar to the old server entry.

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443" : {...}},
              {"0.client-channel.google.com:443" : {...}},
              {"0-edge-chat.facebook.com:443" : {...}},
              ...
          ], ...
     },


BUG=568386
R=rch@chromium.org, bnc@chromium.org
==========

[ramant (doing other things), 2016-01-05 01:41:40]

Thanks Ryan. Fixed the comments.

[Bence, 2016-01-05 18:45:33]

LGTM.

[Bence, 2016-01-05 18:45:47]

https://codereview.chromium.org/1545883002/diff/40001/net/http/http_server_pr...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/1545883002/diff/40001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:449: const base::ListValue*
servers_list = NULL;
Optional: change |NULL| to |nullptr| in both lines.

[ramant (doing other things), 2016-01-05 18:52:58]

Thanks Bence and Ryan. Hopefully, we will see performance improvements.

https://codereview.chromium.org/1545883002/diff/40001/net/http/http_server_pr...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/1545883002/diff/40001/net/http/http_server_pr...
net/http/http_server_properties_manager.cc:449: const base::ListValue*
servers_list = NULL;
On 2016/01/05 18:45:47, Bence wrote:
> Optional: change |NULL| to |nullptr| in both lines.

Done.

[ramant (doing other things), 2016-01-05 18:53:04]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-01-05 18:53:05]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org,
bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/1545883002/#ps60001
(title: "Change NULL to nullptr")

[commit-bot: I haz the power, 2016-01-05 18:54:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545883002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545883002/60001

[commit-bot: I haz the power, 2016-01-05 20:08:50]

Description was changed from

==========
HttpServerProperties - maintain the MRU order (across browser sessions)
when server properties are persisted to disk.

Bumped up the version number. Added code to read the old data and
persist in the new format. Servers are persisted in a vector and each
entry is similar to the old server entry.

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443" : {...}},
              {"0.client-channel.google.com:443" : {...}},
              {"0-edge-chat.facebook.com:443" : {...}},
              ...
          ], ...
     },


BUG=568386
R=rch@chromium.org, bnc@chromium.org
==========

to

==========
HttpServerProperties - maintain the MRU order (across browser sessions)
when server properties are persisted to disk.

Bumped up the version number. Added code to read the old data and
persist in the new format. Servers are persisted in a vector and each
entry is similar to the old server entry.

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443" : {...}},
              {"0.client-channel.google.com:443" : {...}},
              {"0-edge-chat.facebook.com:443" : {...}},
              ...
          ], ...
     },


BUG=568386
R=rch@chromium.org, bnc@chromium.org
==========

[commit-bot: I haz the power, 2016-01-05 20:08:51]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-01-05 20:09:48]

Description was changed from

==========
HttpServerProperties - maintain the MRU order (across browser sessions)
when server properties are persisted to disk.

Bumped up the version number. Added code to read the old data and
persist in the new format. Servers are persisted in a vector and each
entry is similar to the old server entry.

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443" : {...}},
              {"0.client-channel.google.com:443" : {...}},
              {"0-edge-chat.facebook.com:443" : {...}},
              ...
          ], ...
     },


BUG=568386
R=rch@chromium.org, bnc@chromium.org
==========

to

==========
HttpServerProperties - maintain the MRU order (across browser sessions)
when server properties are persisted to disk.

Bumped up the version number. Added code to read the old data and
persist in the new format. Servers are persisted in a vector and each
entry is similar to the old server entry.

     "http_server_properties": {
          "servers": [
              {"yt3.ggpht.com:443" : {...}},
              {"0.client-channel.google.com:443" : {...}},
              {"0-edge-chat.facebook.com:443" : {...}},
              ...
          ], ...
     },

BUG=568386
R=rch@chromium.org, bnc@chromium.org

Committed: https://crrev.com/0947b295f71723c990cae276490c708caf6b4642
Cr-Commit-Position: refs/heads/master@{#367621}
==========

[commit-bot: I haz the power, 2016-01-05 20:09:49]

Patchset 3 (id:??) landed as
https://crrev.com/0947b295f71723c990cae276490c708caf6b4642
Cr-Commit-Position: refs/heads/master@{#367621}