Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1618443002: QUIC - track the time it takes for OnStreamReadyCallback() to be called. (Closed)

Created:
4 years, 11 months ago by ramant (doing other things)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - track the time it takes for OnStreamReadyCallback() to be called. This times tells when a QUIC stream could have been bound to the request vs when it was actually bound. Net.HttpStreamFactory.Job.StreamReadyCallbackTime Will revert this change after getting some real world data. R=asvitkine@chromium.org, rch@chromium.org Committed: https://crrev.com/91e60f1b060cd5cf9720f009181804486dc5aec8 Cr-Commit-Position: refs/heads/master@{#370725}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M net/http/http_stream_factory_impl_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
ramant (doing other things)
4 years, 11 months ago (2016-01-21 00:56:37 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618443002/20001
4 years, 11 months ago (2016-01-21 00:59:46 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 03:17:04 UTC) #8
Ryan Hamilton
lgtm
4 years, 11 months ago (2016-01-21 14:52:11 UTC) #9
Alexei Svitkine (slow)
lgtm
4 years, 11 months ago (2016-01-21 15:45:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618443002/20001
4 years, 11 months ago (2016-01-21 17:33:09 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-21 17:38:40 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 17:40:53 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91e60f1b060cd5cf9720f009181804486dc5aec8
Cr-Commit-Position: refs/heads/master@{#370725}

Powered by Google App Engine
This is Rietveld 408576698