QUIC - minor debugging logic to see why SCT verification is failing when

QUIC - minor debugging logic to see why SCT verification is failing when
QUIC is accessed from home.

Will delete this code asap.

R=rch@chromium.org

Committed: https://crrev.com/3903514d7dda980ff099152f69bdfb4964c6c707
Cr-Commit-Position: refs/heads/master@{#391950}

[Ryan Hamilton, 2016-05-05 03:55:32]

https://codereview.chromium.org/1949333002/diff/1/net/quic/crypto/proof_verif...
File net/quic/crypto/proof_verifier_chromium.cc (right):

https://codereview.chromium.org/1949333002/diff/1/net/quic/crypto/proof_verif...
net/quic/crypto/proof_verifier_chromium.cc:229: DVLOG(1) <<
"cert_transparency_verifier_ is null";
Since these are *D*VLOGs, will they be removed from release builds? Will that
help you?

[ramant (doing other things), 2016-05-05 17:48:08]

Thanks Ryan. PTAL.

https://codereview.chromium.org/1949333002/diff/1/net/quic/crypto/proof_verif...
File net/quic/crypto/proof_verifier_chromium.cc (right):

https://codereview.chromium.org/1949333002/diff/1/net/quic/crypto/proof_verif...
net/quic/crypto/proof_verifier_chromium.cc:229: DVLOG(1) <<
"cert_transparency_verifier_ is null";
On 2016/05/05 03:55:32, Ryan Hamilton wrote:
> Since these are *D*VLOGs, will they be removed from release builds? Will that
> help you?

Was brain dead. Thanks much for catching this. Used VLOG.

Done.

[ramant (doing other things), 2016-05-05 17:58:02]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 17:59:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949333002/20001

[commit-bot: I haz the power, 2016-05-05 19:56:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 19:57:00]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-05-05 23:28:58]

lgtm

[ramant (doing other things), 2016-05-05 23:30:57]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-05-05 23:31:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949333002/20001

[commit-bot: I haz the power, 2016-05-05 23:36:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-05 23:38:22]

Description was changed from

==========
QUIC - minor debugging logic to see why SCT verification is failing when
QUIC is accessed from home.

Will delete this code asap.

R=rch@chromium.org
==========

to

==========
QUIC - minor debugging logic to see why SCT verification is failing when
QUIC is accessed from home.

Will delete this code asap.

R=rch@chromium.org

Committed: https://crrev.com/3903514d7dda980ff099152f69bdfb4964c6c707
Cr-Commit-Position: refs/heads/master@{#391950}
==========

[commit-bot: I haz the power, 2016-05-05 23:38:22]

Patchset 2 (id:??) landed as
https://crrev.com/3903514d7dda980ff099152f69bdfb4964c6c707
Cr-Commit-Position: refs/heads/master@{#391950}

[ramant (doing other things), 2016-05-20 01:27:10]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1999573002/ by rtenneti@chromium.org.

The reason for reverting is: Reverting debugging logic..

[ramant (doing other things), 2016-06-17 19:18:26]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2079843004/ by rtenneti@chromium.org.

The reason for reverting is: Reverting the Debugging code..