Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2232313004: Revert of QUIC - track the time it takes for OnStreamReadyCallback() to (Closed)

Created:
4 years, 4 months ago by ramant (doing other things)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - track the time it takes for OnStreamReadyCallback() to be called. (patchset #1 of https://codereview.chromium.org/1618443002/ ) Reason for revert: We have collected the data. Manaually reverted the following CL that collected data on jank on the IOThread - when we post a OnStreamReadyCallback task and when it gets run. Original issue's description: >QUIC - track the time it takes for OnStreamReadyCallback() to be called. >This times tells when a QUIC stream could have been bound to the request >vs when it was actually bound. > > Net.HttpStreamFactory.Job.StreamReadyCallbackTime > >Will revert this change after getting some real world data. > >R=asvitkine@chromium.org, rch@chromium.org > >Committed: https://crrev.com/91e60f1b060cd5cf9720f009181804486dc5aec8 >Cr-Commit-Position: refs/heads/master@{#370725} BUG=610404 R=rkaplow@chromium.org, rch@chromium.org Committed: https://crrev.com/5d565d4671801a3db93cf71adf01d20e3a39fa9a Cr-Commit-Position: refs/heads/master@{#411830}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Marked it as obsolete. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M net/http/http_stream_factory_impl_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
ramant (doing other things)
4 years, 4 months ago (2016-08-12 22:44:18 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/2232313004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2232313004/diff/1/tools/metrics/histograms/histograms.xml#oldcode28820 tools/metrics/histograms/histograms.xml:28820: -<histogram name="Net.HttpStreamFactoryJob.StreamReadyCallbackTime" units="ms"> Please mark this as <obsolete> instead ...
4 years, 4 months ago (2016-08-12 22:45:35 UTC) #5
ramant (doing other things)
Thanks Alexei for the quick review. Marked the histogram as obsolete. PTAL. https://codereview.chromium.org/2232313004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml ...
4 years, 4 months ago (2016-08-12 22:50:04 UTC) #6
Ryan Hamilton
lgtm
4 years, 4 months ago (2016-08-12 22:50:53 UTC) #7
Alexei Svitkine (slow)
lgtm
4 years, 4 months ago (2016-08-12 22:58:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232313004/20001
4 years, 4 months ago (2016-08-12 22:59:53 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-13 00:26:40 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 00:29:28 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d565d4671801a3db93cf71adf01d20e3a39fa9a
Cr-Commit-Position: refs/heads/master@{#411830}

Powered by Google App Engine
This is Rietveld 408576698