Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1498983004: CT Verify test utilities change - Moved the following common functions (Closed)

Created:
5 years ago by ramant (doing other things)
Modified:
5 years ago
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CT Verify test utilities change - Moved the following common functions between ProofVerifierChromiumTest and MultiLogCTVerifierTest into ct_test_utils.cc. GetSCTListForTesting() GetSCTListWithInvalidSCT() CheckForSingleVerifiedSCTInResult(...) CheckForSCTOrigin(...) R=eranm@chromium.org, rch@chromium.org Committed: https://crrev.com/6486d0d7c119576d0ead5e55c41b2269a4b01cfc Cr-Commit-Position: refs/heads/master@{#363494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -74 lines) Patch
M net/cert/multi_log_ct_verifier_unittest.cc View 5 chunks +10 lines, -41 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium_test.cc View 3 chunks +5 lines, -31 lines 0 comments Download
M net/test/ct_test_util.h View 2 chunks +19 lines, -1 line 0 comments Download
M net/test/ct_test_util.cc View 2 chunks +33 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
ramant (doing other things)
5 years ago (2015-12-05 01:49:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498983004/1
5 years ago (2015-12-05 01:53:31 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-12-05 03:58:19 UTC) #6
Ryan Hamilton
lgtm Thanks!
5 years ago (2015-12-05 04:19:57 UTC) #7
Eran Messeri
lgtm Thanks again!
5 years ago (2015-12-07 15:01:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498983004/1
5 years ago (2015-12-07 15:06:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 16:27:13 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6486d0d7c119576d0ead5e55c41b2269a4b01cfc Cr-Commit-Position: refs/heads/master@{#363494}
5 years ago (2015-12-07 16:28:20 UTC) #14
ramant (doing other things)
5 years ago (2015-12-09 23:14:40 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1517593002/ by rtenneti@chromium.org.

The reason for reverting is: net_unittests fails half the time on Android Cronet
Builder (dbg).

BUG=568282.

Powered by Google App Engine
This is Rietveld 408576698