Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2249813002: Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. (Closed)

Created:
4 years, 4 months ago by ramant (doing other things)
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create EXPECT_QUIC_BUG macro, and modify QUIC tests to use it. Test-only change, not flag protected. Merge internal change: 129661292 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -91 lines) Patch
M net/quic/core/quic_config_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M net/quic/core/quic_flow_controller_test.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_multipath_received_packet_manager_test.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M net/quic/core/quic_multipath_sent_packet_manager_test.cc View 7 chunks +15 lines, -16 lines 0 comments Download
M net/quic/core/quic_one_block_arena_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/core/quic_packet_creator_test.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M net/quic/core/quic_packet_generator_test.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/quic/core/quic_spdy_stream_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/core/reliable_quic_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
4 years, 4 months ago (2016-08-15 19:54:57 UTC) #1
Ryan Hamilton
4 years, 4 months ago (2016-08-15 23:24:17 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698