Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1525993004: AlternativeService - change the expiration time from 1 day to 30 days. (Closed)

Created:
5 years ago by ramant (doing other things)
Modified:
5 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AlternativeService - change the expiration time from 1 day to 30 days. BUG=570105 R=rch@chromium.org Committed: https://crrev.com/b41ede54ee4a60faae7567349eab4b84a5cd0061 Cr-Commit-Position: refs/heads/master@{#365435}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/http/http_stream_factory.cc View 1 chunk +1 line, -1 line 1 comment Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
ramant (doing other things)
5 years ago (2015-12-15 23:45:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525993004/1
5 years ago (2015-12-15 23:47:12 UTC) #3
ramant (doing other things)
https://codereview.chromium.org/1525993004/diff/1/net/http/http_stream_factory.cc File net/http/http_stream_factory.cc (right): https://codereview.chromium.org/1525993004/diff/1/net/http/http_stream_factory.cc#newcode156 net/http/http_stream_factory.cc:156: base::Time::Now() + base::TimeDelta::FromDays(30)); Hi Ryan, We are setting 1 ...
5 years ago (2015-12-16 00:06:34 UTC) #4
Ryan Hamilton
lgtm
5 years ago (2015-12-16 00:56:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525993004/1
5 years ago (2015-12-16 02:45:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 04:17:37 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-16 04:18:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b41ede54ee4a60faae7567349eab4b84a5cd0061
Cr-Commit-Position: refs/heads/master@{#365435}

Powered by Google App Engine
This is Rietveld 408576698