Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1531943003: Changes to AlternativeServices initialization to maintain MRU order. (Closed)

Created:
5 years ago by ramant (doing other things)
Modified:
5 years ago
Reviewers:
Bence, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, ianswett
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_spdy_settings_mru_cache
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes to AlternativeServices initialization to maintain MRU order. If an entry from Preferences is not in the memory, it will be added to the end of MRU list. If an entry from Preferences is already in the memory, it will be updated and its MRU order is maintained. Entries in the memory that are not in Preferences, maintain their recency. BUG=568386 R=bnc@chromium.org, rch@chromium.org Committed: https://crrev.com/59fa432a5cd6569f5b5b9077d3c4c70d69cacb09 Cr-Commit-Position: refs/heads/master@{#366032}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M net/http/http_server_properties_impl.cc View 1 1 chunk +15 lines, -1 line 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 5 chunks +14 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
ramant (doing other things)
5 years ago (2015-12-17 01:36:35 UTC) #1
ramant (doing other things)
Hi Bence and Ryan, AlternativeService unittests were already testing whether disk will overwrite memory entries ...
5 years ago (2015-12-17 01:42:23 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531943003/1
5 years ago (2015-12-17 02:36:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-17 03:57:32 UTC) #7
Bence
LGTM.
5 years ago (2015-12-17 13:51:07 UTC) #8
Ryan Hamilton
lgtm
5 years ago (2015-12-18 00:13:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531943003/20001
5 years ago (2015-12-18 05:28:58 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-18 06:37:50 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-18 06:38:52 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59fa432a5cd6569f5b5b9077d3c4c70d69cacb09
Cr-Commit-Position: refs/heads/master@{#366032}

Powered by Google App Engine
This is Rietveld 408576698