Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1979133002:
QUIC - Collect histogram data to see how may users have TSVIPCli.dll (Closed)
|
Created:
4 years, 7 months ago by ramant (doing other things) Modified:
4 years, 7 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, ananta Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionQUIC - Collect histogram data to see how may users have TSVIPCli.dll
loaded. Added the following temporary histogram and will delete after
getting some data.
Net.QuicStreamFactory.TSVIPCliIsLoaded
BUG=471986
R=rch@chromium.org, rkaplow@chromium.org
Committed: https://crrev.com/157fdf6f4f847f37e9eb72b41da0fe6b780f6120
Cr-Commit-Position: refs/heads/master@{#393900}
Patch Set 1 #
Total comments: 3
Patch Set 2 : deleted BooleanDLLLoaded used Boolean #
Depends on Patchset: Messages
Total messages: 21 (9 generated)
Description was changed from ========== QUIC - Collect histogram data to see how may users have TSVIPCli.dll loaded. Added the following temporary histogram and will delete after getting some data. Net.QuicStreamFactory.TSVIPCliIsLoaded BUG=471986 R=rch@chromium.org, rkaplow@chromium.org ========== to ========== QUIC - Collect histogram data to see how may users have TSVIPCli.dll loaded. Added the following temporary histogram and will delete after getting some data. Net.QuicStreamFactory.TSVIPCliIsLoaded BUG=471986 R=rch@chromium.org, rkaplow@chromium.org ==========
The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979133002/1
https://codereview.chromium.org/1979133002/diff/1/net/quic/quic_stream_factor... File net/quic/quic_stream_factory.cc (right): https://codereview.chromium.org/1979133002/diff/1/net/quic/quic_stream_factor... net/quic/quic_stream_factory.cc:1481: bool tsvipcli_loaded = ::GetModuleHandle(L"TSVIPCli.dll") != NULL; DLL could be loaded after chrome has been working and QUIC is being used. Thus we (Ananta and I) thought it is safer to check every time a socket is created/connected (crashes were happening in CryptoConnect in M50).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rch@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979133002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm https://codereview.chromium.org/1979133002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1979133002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:63675: +<enum name="BooleanDLLLoaded" type="int"> don't think you really need a custom histogram, just regular Boolean answers the questions in the histogram name (since it is names isLoaded)
https://codereview.chromium.org/1979133002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1979133002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:63675: +<enum name="BooleanDLLLoaded" type="int"> On 2016/05/16 14:53:12, rkaplow wrote: > don't think you really need a custom histogram, just regular Boolean answers the > questions in the histogram name (since it is names isLoaded) Done.
The CQ bit was checked by rtenneti@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org, rch@chromium.org Link to the patchset: https://codereview.chromium.org/1979133002/#ps20001 (title: "deleted BooleanDLLLoaded used Boolean")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979133002/20001
Message was sent while issue was closed.
Description was changed from ========== QUIC - Collect histogram data to see how may users have TSVIPCli.dll loaded. Added the following temporary histogram and will delete after getting some data. Net.QuicStreamFactory.TSVIPCliIsLoaded BUG=471986 R=rch@chromium.org, rkaplow@chromium.org ========== to ========== QUIC - Collect histogram data to see how may users have TSVIPCli.dll loaded. Added the following temporary histogram and will delete after getting some data. Net.QuicStreamFactory.TSVIPCliIsLoaded BUG=471986 R=rch@chromium.org, rkaplow@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== QUIC - Collect histogram data to see how may users have TSVIPCli.dll loaded. Added the following temporary histogram and will delete after getting some data. Net.QuicStreamFactory.TSVIPCliIsLoaded BUG=471986 R=rch@chromium.org, rkaplow@chromium.org ========== to ========== QUIC - Collect histogram data to see how may users have TSVIPCli.dll loaded. Added the following temporary histogram and will delete after getting some data. Net.QuicStreamFactory.TSVIPCliIsLoaded BUG=471986 R=rch@chromium.org, rkaplow@chromium.org Committed: https://crrev.com/157fdf6f4f847f37e9eb72b41da0fe6b780f6120 Cr-Commit-Position: refs/heads/master@{#393900} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/157fdf6f4f847f37e9eb72b41da0fe6b780f6120 Cr-Commit-Position: refs/heads/master@{#393900} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
