QUIC - Persist "Hash of the CHLO message" and "Signed timestamp of the

QUIC - Persist "Hash of the CHLO message" and "Signed timestamp of the
leaf cert".

Bumped up the version number of the persisted data. We will not load
server config's from disk cache if they have prior version.

R=rch@chromium.org

Committed: https://crrev.com/61de368f64f49bea82a22c429f16b19ece352fbd
Cr-Commit-Position: refs/heads/master@{#382996}

[ramant (doing other things), 2016-03-23 01:21:46]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 01:22:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818393003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818393003/1

[ramant (doing other things), 2016-03-23 01:39:01]

Description was changed from

==========
QUIC - Persist "Hash of the CHLO message" and "Signed timestamp of the
leaf cert" with QUIC speaking version 30.

Bumped up the version number of the persisted data. We will not load
server config's from disk cache if they have prior version (based on
the assumption, server will reject the CHLO if it doesn't have hash of
CHLO message).

R=rch@chromium.org
==========

to

==========
QUIC - Persist "Hash of the CHLO message" and "Signed timestamp of the
leaf cert" with QUIC speaking version 30.

Bumped up the version number of the persisted data. We will not load
server config's from disk cache if they have prior version.

R=rch@chromium.org
==========

[ramant (doing other things), 2016-03-23 01:50:15]

Description was changed from

==========
QUIC - Persist "Hash of the CHLO message" and "Signed timestamp of the
leaf cert" with QUIC speaking version 30.

Bumped up the version number of the persisted data. We will not load
server config's from disk cache if they have prior version.

R=rch@chromium.org
==========

to

==========
QUIC - Persist "Hash of the CHLO message" and "Signed timestamp of the
leaf cert".

Bumped up the version number of the persisted data. We will not load
server config's from disk cache if they have prior version.

R=rch@chromium.org
==========

[ramant (doing other things), 2016-03-23 01:56:02]

A small question about loading old versions of server configs from disk.
Wondering if we should initialize the new fields to empty strings for older
version of server config.

thanks
raman

https://codereview.chromium.org/1818393003/diff/1/net/quic/crypto/quic_server...
File net/quic/crypto/quic_server_info.cc (right):

https://codereview.chromium.org/1818393003/diff/1/net/quic/crypto/quic_server...
net/quic/crypto/quic_server_info.cc:88: if (!iter.ReadString(&state->cert_sct))
{
Hi Ryan,
  Should we load older versions and initialize cert_sct and chlo_hash as empty
strings for older versions (kQuicCryptoConfigVersion = 1)?

[commit-bot: I haz the power, 2016-03-23 02:33:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 02:33:33]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-03-23 13:55:44]

lgtm

https://codereview.chromium.org/1818393003/diff/1/net/quic/crypto/quic_server...
File net/quic/crypto/quic_server_info.cc (right):

https://codereview.chromium.org/1818393003/diff/1/net/quic/crypto/quic_server...
net/quic/crypto/quic_server_info.cc:88: if (!iter.ReadString(&state->cert_sct))
{
On 2016/03/23 01:56:02, ramant wrote:
> Hi Ryan,
>   Should we load older versions and initialize cert_sct and chlo_hash as empty
> strings for older versions (kQuicCryptoConfigVersion = 1)?

That sounds fine, since that's what we're doing today, right?

[ramant (doing other things), 2016-03-23 22:41:40]

Patchset #2 (id:20001) has been deleted

[ramant (doing other things), 2016-03-23 22:43:19]

Patchset #2 (id:40001) has been deleted

[ramant (doing other things), 2016-03-23 22:43:42]

https://codereview.chromium.org/1818393003/diff/1/net/quic/crypto/quic_server...
File net/quic/crypto/quic_server_info.cc (right):

https://codereview.chromium.org/1818393003/diff/1/net/quic/crypto/quic_server...
net/quic/crypto/quic_server_info.cc:88: if (!iter.ReadString(&state->cert_sct))
{
On 2016/03/23 13:55:44, Ryan Hamilton wrote:
> On 2016/03/23 01:56:02, ramant wrote:
> > Hi Ryan,
> >   Should we load older versions and initialize cert_sct and chlo_hash as
empty
> > strings for older versions (kQuicCryptoConfigVersion = 1)?
> 
> That sounds fine, since that's what we're doing today, right?

Done.

[ramant (doing other things), 2016-03-23 22:43:51]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 22:44:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818393003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818393003/60001

[ramant (doing other things), 2016-03-23 23:35:59]

Hi Ryan,
  PTAL. Will remove the code to pass empty chlo_hash when we decide it is safe
to do (I am guessing that would be when we make QUIC version 31 as the default).

thanks
raman

[commit-bot: I haz the power, 2016-03-24 00:01:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 00:02:00]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-03-24 00:23:14]

On 2016/03/23 23:35:59, ramant wrote:
> Hi Ryan,
>   PTAL. Will remove the code to pass empty chlo_hash when we decide it is safe
> to do (I am guessing that would be when we make QUIC version 31 as the
default).
> 
> thanks
> raman

SGTM!

[ramant (doing other things), 2016-03-24 00:44:40]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-03-24 00:44:40]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1818393003/#ps60001
(title: "Default chlo_hash to empty string for old disk cache data")

[commit-bot: I haz the power, 2016-03-24 00:44:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818393003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818393003/60001

[commit-bot: I haz the power, 2016-03-24 00:50:10]

Description was changed from

==========
QUIC - Persist "Hash of the CHLO message" and "Signed timestamp of the
leaf cert".

Bumped up the version number of the persisted data. We will not load
server config's from disk cache if they have prior version.

R=rch@chromium.org
==========

to

==========
QUIC - Persist "Hash of the CHLO message" and "Signed timestamp of the
leaf cert".

Bumped up the version number of the persisted data. We will not load
server config's from disk cache if they have prior version.

R=rch@chromium.org
==========

[commit-bot: I haz the power, 2016-03-24 00:50:11]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-03-24 00:51:23]

Description was changed from

==========
QUIC - Persist "Hash of the CHLO message" and "Signed timestamp of the
leaf cert".

Bumped up the version number of the persisted data. We will not load
server config's from disk cache if they have prior version.

R=rch@chromium.org
==========

to

==========
QUIC - Persist "Hash of the CHLO message" and "Signed timestamp of the
leaf cert".

Bumped up the version number of the persisted data. We will not load
server config's from disk cache if they have prior version.

R=rch@chromium.org

Committed: https://crrev.com/61de368f64f49bea82a22c429f16b19ece352fbd
Cr-Commit-Position: refs/heads/master@{#382996}
==========

[commit-bot: I haz the power, 2016-03-24 00:51:24]

Patchset 2 (id:??) landed as
https://crrev.com/61de368f64f49bea82a22c429f16b19ece352fbd
Cr-Commit-Position: refs/heads/master@{#382996}