Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1566623002: QUIC - Track how long proof verification takes when cached server config (Closed)

Created:
4 years, 11 months ago by ramant (doing other things)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Track how long proof verification takes when cached server config is used. R=asvitkine@chromium.org, rch@chromium.org Committed: https://crrev.com/68eb6ee038911b4c0c51a671cdf6d2accc325b6c Cr-Commit-Position: refs/heads/master@{#367900}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M net/quic/quic_crypto_client_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +12 lines, -9 lines 0 comments Download

Depends on Patchset:

Issue 1244073002 Patch 20001

Messages

Total messages: 14 (5 generated)
ramant (doing other things)
4 years, 11 months ago (2016-01-06 02:27:58 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566623002/1
4 years, 11 months ago (2016-01-06 02:29:31 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 03:43:17 UTC) #5
Ryan Hamilton
lgtm
4 years, 11 months ago (2016-01-06 04:51:18 UTC) #6
Alexei Svitkine (slow)
lgtm % nit https://codereview.chromium.org/1566623002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1566623002/diff/1/tools/metrics/histograms/histograms.xml#newcode26099 tools/metrics/histograms/histograms.xml:26099: + <summary>Time spent verifying the signature ...
4 years, 11 months ago (2016-01-06 18:59:02 UTC) #7
ramant (doing other things)
Thanks Alexei and Ryan. https://codereview.chromium.org/1566623002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1566623002/diff/1/tools/metrics/histograms/histograms.xml#newcode26099 tools/metrics/histograms/histograms.xml:26099: + <summary>Time spent verifying the ...
4 years, 11 months ago (2016-01-06 19:20:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1566623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1566623002/20001
4 years, 11 months ago (2016-01-06 19:29:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-06 20:51:35 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 20:52:23 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/68eb6ee038911b4c0c51a671cdf6d2accc325b6c
Cr-Commit-Position: refs/heads/master@{#367900}

Powered by Google App Engine
This is Rietveld 408576698