Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 1716453002: relnote: Make QUIC version negotiation stateless. The QUIC dispatcher (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: Make QUIC version negotiation stateless. The QUIC dispatcher now detects version mismatch before creating a QUIC session and sends out a version negotiation packet at that point. Protected by FLAGS_quic_stateless_version_negotiation Relands https://critique.corp.google.com/#review/107151491 which was rolledback. Merge internal change: 114144970 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -8 lines) Patch
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +23 lines, -6 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 2 chunks +42 lines, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/mock_quic_time_wait_list_manager.h View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
ramant (doing other things)
4 years, 10 months ago (2016-02-18 20:25:58 UTC) #1
ramant (doing other things)
Hi Ryan, Just saw that it was rolled back on internal code base. Will not ...
4 years, 10 months ago (2016-02-18 20:27:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716453002/1
4 years, 10 months ago (2016-02-18 20:31:26 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-18 21:52:06 UTC) #8
ramant (doing other things)
Hi Ryan, This CL works ok in chromium.
4 years, 10 months ago (2016-02-18 23:10:28 UTC) #10
Ryan Hamilton
FWIW, this was rolled back. I recommend skipping it, or else also landing the revert ...
4 years, 10 months ago (2016-02-19 03:03:33 UTC) #11
ramant (doing other things)
4 years, 10 months ago (2016-02-19 18:41:09 UTC) #12
On 2016/02/19 03:03:33, Ryan Hamilton wrote:
> FWIW, this was rolled back. I recommend skipping it, or else also landing the
> revert in the same final CL.
> 
> lgtm

I have never made this CL part of Final Landing CL (used the git branching magic
you had taught me few years back). :-).

https://codereview.chromium.org/1714713002/ doesn't have this CL. 

I just wanted to test this CL. Will close this CL.

Thanks Ryan.

Powered by Google App Engine
This is Rietveld 408576698