Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1700353002: Revert "QUIC - check for null stream_ before calling stream_'s IsDoneReading" (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "QUIC - check for null stream_ before calling stream_'s IsDoneReading" This reverts commit 98f200dee65e6d75bd75f3884255b1a920db5e47. BUG=585591 TBR=rch@chromium.org,asvitkine@chromium.org Committed: https://crrev.com/4937af0e28fb73a4e6c8bb088cf1be8575ca761d Cr-Commit-Position: refs/heads/master@{#375789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M net/quic/quic_http_stream.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700353002/1
4 years, 10 months ago (2016-02-16 23:46:35 UTC) #6
ramant (doing other things)
Reverting the CL and will land instrumentation CL that will try to find why |stream_| ...
4 years, 10 months ago (2016-02-16 23:47:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/116875)
4 years, 10 months ago (2016-02-17 00:39:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1700353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1700353002/1
4 years, 10 months ago (2016-02-17 02:07:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 04:19:29 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 04:20:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4937af0e28fb73a4e6c8bb088cf1be8575ca761d
Cr-Commit-Position: refs/heads/master@{#375789}

Powered by Google App Engine
This is Rietveld 408576698