QUIC - Race Cert Verification with host resolution if certs are

QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d073dd2ac386ae7893f03cd7659abb66f045e5fa
Cr-Commit-Position: refs/heads/master@{#409701}

[ramant (doing other things), 2016-07-01 23:08:06]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[ramant (doing other things), 2016-07-01 23:08:35]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 23:08:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ramant (doing other things), 2016-07-01 23:11:19]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
==========

[ramant (doing other things), 2016-07-01 23:11:19]

rtenneti@chromium.org changed reviewers:
+ eroman@chromium.org, mef@chromium.org, rch@chromium.org

[commit-bot: I haz the power, 2016-07-01 23:11:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 23:11:31]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ramant (doing other things), 2016-07-01 23:25:50]

Patchset #1 (id:1) has been deleted

[ramant (doing other things), 2016-07-01 23:26:01]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 23:26:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-02 00:40:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-02 00:41:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ramant (doing other things), 2016-07-02 02:19:42]

Patchset #1 (id:20001) has been deleted

[ramant (doing other things), 2016-07-02 02:19:51]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-02 02:20:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-02 03:22:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-02 03:22:57]

Dry run: This issue passed the CQ dry run.

[ramant (doing other things), 2016-07-06 15:27:19]

Hi Ryan,
  This is a cut at racing host resolution with certificate verification. Would
appreciate comments and will implement if there is a better way to implement it.

thanks much
raman

https://codereview.chromium.org/2120703003/diff/40001/net/quic/crypto/proof_v...
File net/quic/crypto/proof_verifier_chromium.cc (right):

https://codereview.chromium.org/2120703003/diff/40001/net/quic/crypto/proof_v...
net/quic/crypto/proof_verifier_chromium.cc:231: if (!signature.empty() &&
Hi Ryan,
  Is it better to pass "verify_cert_only" as a param to ProofVerify and skip the
signature check if "verify_cert_only" argument is true?

thanks
raman

[Ryan Hamilton, 2016-07-07 00:24:36]

https://codereview.chromium.org/2120703003/diff/40001/net/quic/crypto/proof_v...
File net/quic/crypto/proof_verifier_chromium.cc (right):

https://codereview.chromium.org/2120703003/diff/40001/net/quic/crypto/proof_v...
net/quic/crypto/proof_verifier_chromium.cc:231: if (!signature.empty() &&
>   Is it better to pass "verify_cert_only" as a param to ProofVerify and skip
the
> signature check if "verify_cert_only" argument is true?

Yeah, I think being more explicit would be better. It seems like this code might
allow for the server to supply an empty signature and that would trick the
verifier into accepting it.

https://codereview.chromium.org/2120703003/diff/40001/net/quic/quic_stream_fa...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/2120703003/diff/40001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory.cc:173: class ProofVerifierCallbackImpl : public
ProofVerifierCallback {
Hm. I'm surprised this is using the ProofVerifier instead of the using the
CertVerifier directly. Looking at the code, I guess it's non-trivial to get the
certs into the right form and then there are a bunch of check we need to do. OK,
makes sense.

https://codereview.chromium.org/2120703003/diff/40001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory.cc:219: QUIC_VERSION_25, /*chlo_hash=*/"",
cached->certs(),
hard-coding a quic version here seems scary.

https://codereview.chromium.org/2120703003/diff/40001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory.cc:221: &verify_error_details_, &verify_details_,
verify_callback);
Wow, there are a lot of empty arguments. I'd be inclined to add a new method to
the ProofVerifier just for this purpose.

https://codereview.chromium.org/2120703003/diff/40001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory.cc:840:
active_cert_verifier_jobs_.erase(active_cert_verifier_jobs_.begin());
I wonder if the value in the map could be an std::unique_ptr?

[ramant (doing other things), 2016-07-07 03:43:22]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 03:43:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 04:56:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 04:56:49]

Dry run: This issue passed the CQ dry run.

[ramant (doing other things), 2016-07-07 16:18:20]

Hi Ryan,
  Made all the changes. PTAL.

thanks
raman

https://codereview.chromium.org/2120703003/diff/40001/net/quic/crypto/proof_v...
File net/quic/crypto/proof_verifier_chromium.cc (right):

https://codereview.chromium.org/2120703003/diff/40001/net/quic/crypto/proof_v...
net/quic/crypto/proof_verifier_chromium.cc:231: if (!signature.empty() &&
On 2016/07/07 00:24:36, Ryan Hamilton wrote:
> >   Is it better to pass "verify_cert_only" as a param to ProofVerify and skip
> the
> > signature check if "verify_cert_only" argument is true?
> 
> Yeah, I think being more explicit would be better. It seems like this code
might
> allow for the server to supply an empty signature and that would trick the
> verifier into accepting it.

Added a new method.

https://codereview.chromium.org/2120703003/diff/40001/net/quic/quic_stream_fa...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/2120703003/diff/40001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory.cc:173: class ProofVerifierCallbackImpl : public
ProofVerifierCallback {
On 2016/07/07 00:24:36, Ryan Hamilton wrote:
> Hm. I'm surprised this is using the ProofVerifier instead of the using the
> CertVerifier directly. Looking at the code, I guess it's non-trivial to get
the
> certs into the right form and then there are a bunch of check we need to do.
OK,
> makes sense.

Wondered about the same (whether to duplicate some of the ProofVerifierChromium
code or not).
Acknowledged.

https://codereview.chromium.org/2120703003/diff/40001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory.cc:219: QUIC_VERSION_25, /*chlo_hash=*/"",
cached->certs(),
On 2016/07/07 00:24:36, Ryan Hamilton wrote:
> hard-coding a quic version here seems scary.

Deleted it.

Done.

https://codereview.chromium.org/2120703003/diff/40001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory.cc:221: &verify_error_details_, &verify_details_,
verify_callback);
On 2016/07/07 00:24:36, Ryan Hamilton wrote:
> Wow, there are a lot of empty arguments. I'd be inclined to add a new method
to
> the ProofVerifier just for this purpose.

Done.

https://codereview.chromium.org/2120703003/diff/40001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory.cc:840:
active_cert_verifier_jobs_.erase(active_cert_verifier_jobs_.begin());
On 2016/07/07 00:24:36, Ryan Hamilton wrote:
> I wonder if the value in the map could be an std::unique_ptr?

Done.

[ramant (doing other things), 2016-07-07 19:31:49]

https://codereview.chromium.org/2120703003/diff/80001/net/quic/crypto/proof_v...
File net/quic/crypto/proof_verifier_chromium.cc (right):

https://codereview.chromium.org/2120703003/diff/80001/net/quic/crypto/proof_v...
net/quic/crypto/proof_verifier_chromium.cc:153: bool enforce_policy_checking_;
Hi Ryan,
  As we had discussed offline, added this flag. It is enabled by default and in
VerifyProof added a check. When we do cert verification only (for pre-caching
cert verify result) during racing with host resolution, disabled policy
checking.

  Quic code will be calling VerifyProof and during that call we perform all the
checks.

thanks
raman

[ramant (doing other things), 2016-07-07 19:31:58]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 19:32:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 21:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 21:34:14]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-07-07 21:36:12]

a couple nits, but LGTM otherwise. I assume you'll merge the changes to the
shared code back to google3?

https://codereview.chromium.org/2120703003/diff/80001/net/quic/crypto/proof_v...
File net/quic/crypto/proof_verifier.h (right):

https://codereview.chromium.org/2120703003/diff/80001/net/quic/crypto/proof_v...
net/quic/crypto/proof_verifier.h:105: const uint16_t port,
nit: I wonder if |port| is actually needed?

https://codereview.chromium.org/2120703003/diff/80001/net/quic/crypto/proof_v...
File net/quic/crypto/proof_verifier_chromium.cc (right):

https://codereview.chromium.org/2120703003/diff/80001/net/quic/crypto/proof_v...
net/quic/crypto/proof_verifier_chromium.cc:616: }
nit: no {}s

https://codereview.chromium.org/2120703003/diff/80001/net/quic/quic_stream_fa...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/2120703003/diff/80001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory.cc:171: class QuicStreamFactory::CertVerifierJob {
nit: comment, please.

[mef, 2016-07-07 21:56:25]

components/cronet lgtm

[ramant (doing other things), 2016-07-07 22:15:26]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 22:16:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ramant (doing other things), 2016-07-07 22:17:34]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org, 
TBR=eroman@chromium.org (for net-internals changes)
==========

[ramant (doing other things), 2016-07-07 22:18:28]

Thanks very much Ryan for the comments. 

Made all the changes. Would appreciate if you could take a quick look at the
comments I have added. PTAL.

-raman

https://codereview.chromium.org/2120703003/diff/80001/net/quic/crypto/proof_v...
File net/quic/crypto/proof_verifier.h (right):

https://codereview.chromium.org/2120703003/diff/80001/net/quic/crypto/proof_v...
net/quic/crypto/proof_verifier.h:105: const uint16_t port,
On 2016/07/07 21:36:12, Ryan Hamilton wrote:
> nit: I wonder if |port| is actually needed?

+1. Because we are not enforcing policy checking when we just verify certs, we
don't need port. Deleted it.

Done.

https://codereview.chromium.org/2120703003/diff/80001/net/quic/crypto/proof_v...
File net/quic/crypto/proof_verifier_chromium.cc (right):

https://codereview.chromium.org/2120703003/diff/80001/net/quic/crypto/proof_v...
net/quic/crypto/proof_verifier_chromium.cc:616: }
On 2016/07/07 21:36:12, Ryan Hamilton wrote:
> nit: no {}s

Done. Used no {}s in chromium specific files. They are all consistent.

https://codereview.chromium.org/2120703003/diff/80001/net/quic/quic_stream_fa...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/2120703003/diff/80001/net/quic/quic_stream_fa...
net/quic/quic_stream_factory.cc:171: class QuicStreamFactory::CertVerifierJob {
On 2016/07/07 21:36:12, Ryan Hamilton wrote:
> nit: comment, please.

My fault.

Done.

[ramant (doing other things), 2016-07-07 22:20:20]

Will merge the changes to the common files into the internal source tree. Thanks
Ryan.

[Ryan Hamilton, 2016-07-07 22:22:56]

lgtm

[ramant (doing other things), 2016-07-07 22:59:21]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-07-07 22:59:22]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org
Link to the patchset: https://codereview.chromium.org/2120703003/#ps100001
(title: "Fix comments.")

[commit-bot: I haz the power, 2016-07-07 23:00:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 00:18:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 00:18:11]

Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[ramant (doing other things), 2016-07-08 00:50:18]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-07-08 00:50:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 01:14:25]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org, 
TBR=eroman@chromium.org (for net-internals changes)
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org, 
TBR=eroman@chromium.org (for net-internals changes)
==========

[commit-bot: I haz the power, 2016-07-08 01:14:26]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-07-08 01:14:31]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 01:17:03]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org, 
TBR=eroman@chromium.org (for net-internals changes)
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
Cr-Commit-Position: refs/heads/master@{#404296}
==========

[commit-bot: I haz the power, 2016-07-08 01:17:05]

Patchset 4 (id:??) landed as
https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
Cr-Commit-Position: refs/heads/master@{#404296}

[hush (inactive), 2016-07-08 02:22:41]

A revert of this CL (patchset #4 id:100001) has been created in
https://codereview.chromium.org/2131813002/ by hush@chromium.org.

The reason for reverting is: Failed cronet unit test and net unit test
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Dat...

https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Dat....

[1543, 2016-07-08 06:29:32]

rn31543@gmail.com changed reviewers:
+ rn31543@gmail.com

[1543, 2016-07-08 06:29:33]

lgtm

hyhyhyhy

[1543, 2016-07-08 06:29:41]

lgtm

lgtm

hyhyhyhy

[1543, 2016-07-08 06:29:44]

lgtm

lgtm

lgtm

hyhyhyhy

[mef, 2016-07-08 13:23:50]

https://codereview.chromium.org/2120703003/diff/100001/components/cronet/url_...
File components/cronet/url_request_context_config_unittest.cc (right):

https://codereview.chromium.org/2120703003/diff/100001/components/cronet/url_...
components/cronet/url_request_context_config_unittest.cc:50:
"\"race_cert_verification\":true,"
I think test below fails because this line is NOT inside of the QUIC section /
dictionary.

[Ryan Hamilton, 2016-07-08 13:42:38]

On 2016/07/08 13:23:50, mef wrote:
>
https://codereview.chromium.org/2120703003/diff/100001/components/cronet/url_...
> File components/cronet/url_request_context_config_unittest.cc (right):
> 
>
https://codereview.chromium.org/2120703003/diff/100001/components/cronet/url_...
> components/cronet/url_request_context_config_unittest.cc:50:
> "\"race_cert_verification\":true,"
> I think test below fails because this line is NOT inside of the QUIC section /
> dictionary.

Ah, thanks. Why did this fail after the commit, but not via the CQ?

[ramant (doing other things), 2016-07-08 18:18:51]

On 2016/07/08 13:42:38, Ryan Hamilton wrote:
> On 2016/07/08 13:23:50, mef wrote:
> >
>
https://codereview.chromium.org/2120703003/diff/100001/components/cronet/url_...
> > File components/cronet/url_request_context_config_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/2120703003/diff/100001/components/cronet/url_...
> > components/cronet/url_request_context_config_unittest.cc:50:
> > "\"race_cert_verification\":true,"
> > I think test below fails because this line is NOT inside of the QUIC section
/
> > dictionary.
> 
> Ah, thanks. Why did this fail after the commit, but not via the CQ?

It would have been create if CQ built android_cronet_tester also. It was my
fault for not trying that trybot. 

I did a revert of revert in https://codereview.chromium.org/2129263002/.

Made the following change to fix the test failure. Trying the CQ and trybot for
android_cronet_tester on the above CL.

https://codereview.chromium.org/2129263002/diff/1/components/network_session_...

[Ryan Hamilton, 2016-07-08 18:45:35]

On 2016/07/08 18:18:51, ramant wrote:
> On 2016/07/08 13:42:38, Ryan Hamilton wrote:
> 
> It would have been create if CQ built android_cronet_tester also. It was my
> fault for not trying that trybot. 

I don't think that's your fault :> I thought we were not supposed to have any
bots which triggered reverts that were not part of the CQ.

mef: do you have any insight?

[mef, 2016-07-08 18:51:24]

On 2016/07/08 18:45:35, Ryan Hamilton wrote:
> On 2016/07/08 18:18:51, ramant wrote:
> > On 2016/07/08 13:42:38, Ryan Hamilton wrote:
> > 
> > It would have been create if CQ built android_cronet_tester also. It was my
> > fault for not trying that trybot. 
> 
> I don't think that's your fault :> I thought we were not supposed to have any
> bots which triggered reverts that were not part of the CQ.
> 
> mef: do you have any insight?

AFAIK Cronet targets are/were getting built as part of Android build.
I think we should make Cronet tests part of CQ as well.

[ramant (doing other things), 2016-07-08 22:56:29]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
Cr-Commit-Position: refs/heads/master@{#404296}
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
Cr-Commit-Position: refs/heads/master@{#404296}
==========

[ramant (doing other things), 2016-07-08 22:57:42]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
Cr-Commit-Position: refs/heads/master@{#404296}
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

[ramant (doing other things), 2016-07-08 22:58:18]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 22:58:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ramant (doing other things), 2016-07-08 22:59:00]

rtenneti@chromium.org changed reviewers:
- rn31543@gmail.com

[ramant (doing other things), 2016-07-08 22:59:01]

Rebased with tip of the tree and fixed unittests.

[ramant (doing other things), 2016-07-08 23:12:08]

The CQ bit was unchecked by rtenneti@chromium.org

[ramant (doing other things), 2016-07-08 23:12:12]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-07-08 23:12:12]

The patchset sent to the CQ was uploaded after l-g-t-m from rn31543@gmail.com,
mef@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2120703003/#ps120001
(title: "Rebase and fix unittests.")

[ramant (doing other things), 2016-07-08 23:12:24]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-07-08 23:12:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ramant (doing other things), 2016-07-08 23:13:49]

https://codereview.chromium.org/2120703003/diff/100001/components/cronet/url_...
File components/cronet/url_request_context_config_unittest.cc (right):

https://codereview.chromium.org/2120703003/diff/100001/components/cronet/url_...
components/cronet/url_request_context_config_unittest.cc:50:
"\"race_cert_verification\":true,"
On 2016/07/08 13:23:50, mef wrote:
> I think test below fails because this line is NOT inside of the QUIC section /
> dictionary.

Done.

[ramant (doing other things), 2016-07-08 23:19:26]

On 2016/07/08 23:13:49, ramant wrote:
>
https://codereview.chromium.org/2120703003/diff/100001/components/cronet/url_...
> File components/cronet/url_request_context_config_unittest.cc (right):
> 
>
https://codereview.chromium.org/2120703003/diff/100001/components/cronet/url_...
> components/cronet/url_request_context_config_unittest.cc:50:
> "\"race_cert_verification\":true,"
> On 2016/07/08 13:23:50, mef wrote:
> > I think test below fails because this line is NOT inside of the QUIC section
/
> > dictionary.
> 
> Done.

Would like to land this CL before tonight. Will be out of country for few weeks.
thanks.

[commit-bot: I haz the power, 2016-07-09 00:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 00:41:38]

Failed to apply patch for net/http/http_network_session.cc:
While running git apply --index -3 -p1;
  error: patch failed: net/http/http_network_session.cc:129
  Falling back to three-way merge...
  Applied patch to 'net/http/http_network_session.cc' with conflicts.
  U net/http/http_network_session.cc

Patch:       net/http/http_network_session.cc
Index: net/http/http_network_session.cc
diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc
index
081d82903a77748ed82d1f3f277b9846badf913e..9a15244fae0c061d7759a64708bd1b2e65e43ca6
100644
--- a/net/http/http_network_session.cc
+++ b/net/http/http_network_session.cc
@@ -129,6 +129,7 @@ HttpNetworkSession::Params::Params()
       quic_migrate_sessions_on_network_change(false),
       quic_migrate_sessions_early(false),
       quic_disable_bidirectional_streams(false),
+      quic_race_cert_verification(false),
       proxy_delegate(NULL),
       enable_token_binding(false) {
   quic_supported_versions.push_back(QUIC_VERSION_34);
@@ -187,6 +188,7 @@ HttpNetworkSession::HttpNetworkSession(const Params& params)
           params.quic_idle_connection_timeout_seconds,
           params.quic_migrate_sessions_on_network_change,
           params.quic_migrate_sessions_early,
+          params.quic_race_cert_verification,
           params.quic_connection_options,
           params.enable_token_binding),
       spdy_session_pool_(params.host_resolver,
@@ -345,6 +347,8 @@ std::unique_ptr<base::Value>
HttpNetworkSession::QuicInfoToValue() const {
                    params_.disable_quic_on_timeout_with_open_streams);
   dict->SetString("disabled_reason",
                   quic_stream_factory_.QuicDisabledReasonString());
+  dict->SetBoolean("race_cert_verification",
+                   params_.quic_race_cert_verification);
   return std::move(dict);
 }

[commit-bot: I haz the power, 2016-07-09 00:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 00:42:03]

CQ bit was unchecked.

[ramant (doing other things), 2016-07-09 00:57:49]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
Cr-Commit-Position: refs/heads/master@{#404296}
==========

[ramant (doing other things), 2016-07-09 01:11:14]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-07-09 01:11:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rn31543@gmail.com,
mef@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2120703003/#ps140001
(title: "Rebase")

[ramant (doing other things), 2016-07-09 01:11:21]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-07-09 01:11:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 04:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 04:37:53]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[ramant (doing other things), 2016-07-09 04:56:30]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-07-09 04:56:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 06:57:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 06:57:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[ramant (doing other things), 2016-07-09 13:27:14]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/61f8d17a6a2ee893f42f62164a81026c56186c1d
Cr-Commit-Position: refs/heads/master@{#404296}
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

[ramant (doing other things), 2016-07-09 13:27:25]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-07-09 13:27:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 15:28:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-09 15:28:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[ramant (doing other things), 2016-07-09 19:44:28]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-07-09 19:44:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 19:48:55]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

[commit-bot: I haz the power, 2016-07-09 19:48:57]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-07-09 19:51:06]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/74acd6f26ea2e71a06a6d09cd2eb2f6d751627cc
Cr-Commit-Position: refs/heads/master@{#404568}
==========

[commit-bot: I haz the power, 2016-07-09 19:51:08]

Patchset 6 (id:??) landed as
https://crrev.com/74acd6f26ea2e71a06a6d09cd2eb2f6d751627cc
Cr-Commit-Position: refs/heads/master@{#404568}

[Ken Rockot(use gerrit already), 2016-07-10 13:58:29]

On 2016/07/09 at 19:51:08, commit-bot wrote:
> Patchset 6 (id:??) landed as
https://crrev.com/74acd6f26ea2e71a06a6d09cd2eb2f6d751627cc
> Cr-Commit-Position: refs/heads/master@{#404568}

This appears to have net_unittests on lots of bots.

[Ken Rockot(use gerrit already), 2016-07-10 14:59:03]

On 2016/07/10 at 13:58:29, Ken Rockot wrote:
> On 2016/07/09 at 19:51:08, commit-bot wrote:
> > Patchset 6 (id:??) landed as
https://crrev.com/74acd6f26ea2e71a06a6d09cd2eb2f6d751627cc
> > Cr-Commit-Position: refs/heads/master@{#404568}
> 
> This appears to have net_unittests on lots of bots.

Err, broken* :)  This appears to have *broken* net_unittests on lots of bots.

[ramant (doing other things), 2016-07-10 16:32:54]

A revert of this CL (patchset #6 id:140001) has been created in
https://codereview.chromium.org/2137843002/ by rtenneti@chromium.org.

The reason for reverting is: Net unit tests are failing on buildbot.

[ramant (doing other things), 2016-08-02 18:43:49]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/74acd6f26ea2e71a06a6d09cd2eb2f6d751627cc
Cr-Commit-Position: refs/heads/master@{#404568}
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/74acd6f26ea2e71a06a6d09cd2eb2f6d751627cc
Cr-Commit-Position: refs/heads/master@{#404568}
==========

[ramant (doing other things), 2016-08-02 18:51:38]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/74acd6f26ea2e71a06a6d09cd2eb2f6d751627cc
Cr-Commit-Position: refs/heads/master@{#404568}
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/74acd6f26ea2e71a06a6d09cd2eb2f6d751627cc
Cr-Commit-Position: refs/heads/master@{#404568}
==========

[ramant (doing other things), 2016-08-02 18:52:11]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:52:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 18:53:05]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-08-02 20:06:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 20:06:38]

Dry run: This issue passed the CQ dry run.

[ramant (doing other things), 2016-08-03 17:53:48]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)

Committed: https://crrev.com/74acd6f26ea2e71a06a6d09cd2eb2f6d751627cc
Cr-Commit-Position: refs/heads/master@{#404568}
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

[ramant (doing other things), 2016-08-03 17:54:45]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

[ramant (doing other things), 2016-08-03 17:54:54]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-08-03 17:54:55]

The patchset sent to the CQ was uploaded after l-g-t-m from rn31543@gmail.com,
mef@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2120703003/#ps180001
(title: "Minor fix.")

[commit-bot: I haz the power, 2016-08-03 17:55:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ramant (doing other things), 2016-08-03 19:08:42]

The CQ bit was unchecked by rtenneti@chromium.org

[ramant (doing other things), 2016-08-03 19:12:43]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ramant (doing other things), 2016-08-03 19:27:11]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 19:27:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ramant (doing other things), 2016-08-03 21:14:37]

The CQ bit was unchecked by rtenneti@chromium.org

[ramant (doing other things), 2016-08-03 21:14:51]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-08-03 21:14:52]

The patchset sent to the CQ was uploaded after l-g-t-m from rn31543@gmail.com,
mef@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2120703003/#ps220001
(title: "Rebase TOT")

[commit-bot: I haz the power, 2016-08-03 21:15:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:30:54]

Committed patchset #10 (id:220001)

[commit-bot: I haz the power, 2016-08-03 21:32:47]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4a42548bd101adfc284fa6e8da6493a2d89f768a
Cr-Commit-Position: refs/heads/master@{#409625}
==========

[commit-bot: I haz the power, 2016-08-03 21:32:49]

Patchset 10 (id:??) landed as
https://crrev.com/4a42548bd101adfc284fa6e8da6493a2d89f768a
Cr-Commit-Position: refs/heads/master@{#409625}

[ramant (doing other things), 2016-08-03 23:18:29]

A revert of this CL (patchset #10 id:220001) has been created in
https://codereview.chromium.org/2210693002/ by rtenneti@chromium.org.

The reason for reverting is: CQ works ok, but on chromeos build bot the tests
fail..

[ramant (doing other things), 2016-08-03 23:51:16]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4a42548bd101adfc284fa6e8da6493a2d89f768a
Cr-Commit-Position: refs/heads/master@{#409625}
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4a42548bd101adfc284fa6e8da6493a2d89f768a
Cr-Commit-Position: refs/heads/master@{#409625}
==========

[ramant (doing other things), 2016-08-04 00:49:43]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4a42548bd101adfc284fa6e8da6493a2d89f768a
Cr-Commit-Position: refs/heads/master@{#409625}
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

[ramant (doing other things), 2016-08-04 00:52:15]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ramant (doing other things), 2016-08-04 00:52:30]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-08-04 00:52:30]

The patchset sent to the CQ was uploaded after l-g-t-m from rn31543@gmail.com,
mef@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2120703003/#ps230001
(title: "Fix for buildbot failure.")

[commit-bot: I haz the power, 2016-08-04 00:53:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 01:58:52]

Committed patchset #11 (id:230001)

[ramant (doing other things), 2016-08-04 02:02:09]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-04 02:02:21]

Description was changed from

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
QUIC - Race Cert Verification with host resolution if certs are
availiable when race_cert_verification network session param is enabled.

This experiment is not enabled in chromium.

R=eroman@chromium.org, mef@chromium.org, rch@chromium.org,
TBR=eroman@chromium.org (for net-internals changes)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d073dd2ac386ae7893f03cd7659abb66f045e5fa
Cr-Commit-Position: refs/heads/master@{#409701}
==========

[commit-bot: I haz the power, 2016-08-04 02:02:24]

Patchset 11 (id:??) landed as
https://crrev.com/d073dd2ac386ae7893f03cd7659abb66f045e5fa
Cr-Commit-Position: refs/heads/master@{#409701}

[Ryan Hamilton, 2016-08-21 20:50:05]

A revert of this CL (patchset #11 id:230001) has been created in
https://codereview.chromium.org/2267603002/ by rch@chromium.org.

The reason for reverting is: Causes crashes crbug.com/639519.

[ramant (doing other things), 2016-08-22 00:18:36]

LGTM

[Ryan Hamilton, 2016-08-22 19:28:02]

On 2016/08/21 20:50:05, Ryan Hamilton wrote:
> A revert of this CL (patchset #11 id:230001) has been created in
> https://codereview.chromium.org/2267603002/ by mailto:rch@chromium.org.
> 
> The reason for reverting is: Causes crashes crbug.com/639519.

Actually this does not actually cause that crash. Will not be reverting.