Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1543763003: QUIC - added histograms to measure time for proof verification. This is (Closed)

Created:
5 years ago by ramant (doing other things)
Modified:
5 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - added histograms to measure time for proof verification. This is to help find why certificate verfication takes longer on android relative to windows. - Net.QuicSession.VerifyProofTime tracks time for all hosts. - Net.QuicSession.VerifyProofTime.google tracks time for www.google.com. The above two histograms will give if other non www.google.com QUIC servers have similar time to www.google.com. R=asvitkine@chromium.org, rch@chromium.org Committed: https://crrev.com/dd4f1bd74c29486fdfecf2e1760d653b187c1e14 Cr-Commit-Position: refs/heads/master@{#366761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M net/quic/crypto/proof_verifier_chromium.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
ramant (doing other things)
5 years ago (2015-12-23 00:02:57 UTC) #1
Ryan Hamilton
lgtm
5 years ago (2015-12-23 00:25:52 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years ago (2015-12-23 16:13:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543763003/1
5 years ago (2015-12-23 18:10:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-23 19:17:57 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-23 19:19:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd4f1bd74c29486fdfecf2e1760d653b187c1e14
Cr-Commit-Position: refs/heads/master@{#366761}

Powered by Google App Engine
This is Rietveld 408576698