Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1570963003:
QUIC - Log finch field trial options used in net-internals/#quic tab. (Closed)
|
Created:
4 years, 11 months ago by ramant (doing other things) Modified:
4 years, 11 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, arv+watch_chromium.org, mmenke, ianswett Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionQUIC - Log finch field trial options used in net-internals/#quic tab.
R=eroman@chromium.org, rch@chromium.org, mmenke@chromium.org
Committed: https://crrev.com/f4b29d77d077c54c05f09031aa2ab16d5249809d
Cr-Commit-Position: refs/heads/master@{#368635}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Removed the word QUIC from labels #
Depends on Patchset: Messages
Total messages: 21 (9 generated)
The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570963003/1
Description was changed from ========== QUIC - Log finch field trial options used in net-internals/#quic tab. R=eroman@chromium.org, rch@chromium.org ========== to ========== QUIC - Log finch field trial options used in net-internals/#quic tab. R=eroman@chromium.org, rch@chromium.org ==========
Hi Misha, Thanks to Ryan for suggesting that we should print Params that are enabled via experiments. Should we do the same for other (non-QUIC) cronet experiments?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/01/09 00:38:29, ramant wrote: > Hi Misha, > Thanks to Ryan for suggesting that we should print Params that are enabled via > experiments. Should we do the same for other (non-QUIC) cronet experiments? I think that would be great. Does it mean that we need to add a cronet-specific page to net-internals?
lgtm thanks for doing this! https://codereview.chromium.org/1570963003/diff/1/chrome/browser/resources/ne... File chrome/browser/resources/net_internals/quic_view.html (right): https://codereview.chromium.org/1570963003/diff/1/chrome/browser/resources/ne... chrome/browser/resources/net_internals/quic_view.html:13: <li>QUIC Load Server Info Timeout Multiplier: <span jscontent="$this.load_server_info_timeout_srtt_multiplier"></span></li> Since this is #quic, I would remove "QUIC " from all of these options.
rtenneti@chromium.org changed reviewers: + mmenke@chromium.org
Thanks Ryan https://codereview.chromium.org/1570963003/diff/1/chrome/browser/resources/ne... File chrome/browser/resources/net_internals/quic_view.html (right): https://codereview.chromium.org/1570963003/diff/1/chrome/browser/resources/ne... chrome/browser/resources/net_internals/quic_view.html:13: <li>QUIC Load Server Info Timeout Multiplier: <span jscontent="$this.load_server_info_timeout_srtt_multiplier"></span></li> On 2016/01/10 23:16:59, Ryan Hamilton wrote: > Since this is #quic, I would remove "QUIC " from all of these options. Done.
Description was changed from ========== QUIC - Log finch field trial options used in net-internals/#quic tab. R=eroman@chromium.org, rch@chromium.org ========== to ========== QUIC - Log finch field trial options used in net-internals/#quic tab. R=eroman@chromium.org, rch@chromium.org, mmenke@chromium.org ==========
lgtm
The CQ bit was checked by rtenneti@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org Link to the patchset: https://codereview.chromium.org/1570963003/#ps20001 (title: "Removed the word QUIC from labels")
On 2016/01/11 18:14:54, eroman wrote: > lgtm Thanks very much Eric, raman
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570963003/20001
Message was sent while issue was closed.
Description was changed from ========== QUIC - Log finch field trial options used in net-internals/#quic tab. R=eroman@chromium.org, rch@chromium.org, mmenke@chromium.org ========== to ========== QUIC - Log finch field trial options used in net-internals/#quic tab. R=eroman@chromium.org, rch@chromium.org, mmenke@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== QUIC - Log finch field trial options used in net-internals/#quic tab. R=eroman@chromium.org, rch@chromium.org, mmenke@chromium.org ========== to ========== QUIC - Log finch field trial options used in net-internals/#quic tab. R=eroman@chromium.org, rch@chromium.org, mmenke@chromium.org Committed: https://crrev.com/f4b29d77d077c54c05f09031aa2ab16d5249809d Cr-Commit-Position: refs/heads/master@{#368635} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f4b29d77d077c54c05f09031aa2ab16d5249809d Cr-Commit-Position: refs/heads/master@{#368635} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
