Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1567143003: Disable QuicEndToEndTest.LargePostWithNoPacketLoss and (Closed)

Created:
4 years, 11 months ago by ramant (doing other things)
Modified:
4 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable QuicEndToEndTest.LargePostWithNoPacketLoss and QuicEndToEndTest.LargePostWithPacketLoss of net_unittests on TSan bots. BUG=536845 R=rch@chromium.org Committed: https://crrev.com/e3b666d255e31de645cf47df9e2695c96f1379bc Cr-Commit-Position: refs/heads/master@{#368274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M net/quic/quic_end_to_end_unittest.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (4 generated)
ramant (doing other things)
4 years, 11 months ago (2016-01-08 00:57:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567143003/1
4 years, 11 months ago (2016-01-08 00:58:47 UTC) #3
Ryan Hamilton
Thanks, Raman!
4 years, 11 months ago (2016-01-08 01:14:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 01:28:27 UTC) #6
ramant (doing other things)
On 2016/01/08 01:14:29, Ryan Hamilton wrote: > Thanks, Raman! Sorry to bother you Ryan, could ...
4 years, 11 months ago (2016-01-08 01:39:52 UTC) #7
Ryan Hamilton
lgtm Gah! Sorry!
4 years, 11 months ago (2016-01-08 05:03:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1567143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1567143003/1
4 years, 11 months ago (2016-01-08 05:03:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 05:07:35 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e3b666d255e31de645cf47df9e2695c96f1379bc Cr-Commit-Position: refs/heads/master@{#368274}
4 years, 11 months ago (2016-01-08 05:08:59 UTC) #13
davidben
4 years, 11 months ago (2016-01-11 17:08:10 UTC) #14
Message was sent while issue was closed.
Note: This isn't a false positive (though it probably only affects tests). See
discussion on the bug. The fix should just be adding EnsureOpenSSLInit() at the
right point in QUIC. I'm not sure where since I'm not familiar with that code.

Powered by Google App Engine
This is Rietveld 408576698