QUIC - Added a histogram to track number of times session_ is null when

QUIC - Added a histogram to track number of times session_ is null when
QuicHttpStream::DoStreamRequest() is called. This crash was happening in
cronet (b/28676259).

Would like to remove the temporary fix if this crash doesn't happen.

Histogram name: Net.QuicHttpStream::DoStreamRequest.NullSession

BUG=616812
R=rkaplow@chromium.org, rch@chromium.org

Committed: https://crrev.com/9b30853b5857eb16dbbaa2560c04746b8d6f02e6
Cr-Commit-Position: refs/heads/master@{#400792}

[ramant (doing other things), 2016-06-18 00:17:20]

Description was changed from

==========
QUIC - Added a histogram to track number of times session_ is null when
QuicHttpStream::DoStreamRequest() is called. This crash was happening in
cronet (b/28676259).

Would like to remove the temporary fix if this crash doesn't happen.

Histogram name: Net.QuicHttpStream::DoStreamRequest.NullSession

BUG=616812
R=asvitkine@chromium.org, rch@chromium.org
==========

to

==========
QUIC - Added a histogram to track number of times session_ is null when
QuicHttpStream::DoStreamRequest() is called. This crash was happening in
cronet (b/28676259).

Would like to remove the temporary fix if this crash doesn't happen.

Histogram name: Net.QuicHttpStream::DoStreamRequest.NullSession

BUG=616812
R=asvitkine@chromium.org, rch@chromium.org
==========

[Ryan Hamilton, 2016-06-18 14:59:57]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-06-18 14:59:57]

lgtm

[commit-bot: I haz the power, 2016-06-18 15:00:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073323003/1

[commit-bot: I haz the power, 2016-06-18 15:06:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-18 15:06:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ramant (doing other things), 2016-06-20 16:45:24]

Description was changed from

==========
QUIC - Added a histogram to track number of times session_ is null when
QuicHttpStream::DoStreamRequest() is called. This crash was happening in
cronet (b/28676259).

Would like to remove the temporary fix if this crash doesn't happen.

Histogram name: Net.QuicHttpStream::DoStreamRequest.NullSession

BUG=616812
R=asvitkine@chromium.org, rch@chromium.org
==========

to

==========
QUIC - Added a histogram to track number of times session_ is null when
QuicHttpStream::DoStreamRequest() is called. This crash was happening in
cronet (b/28676259).

Would like to remove the temporary fix if this crash doesn't happen.

Histogram name: Net.QuicHttpStream::DoStreamRequest.NullSession

BUG=616812
R=rkaplow@chromium.org, rch@chromium.org
==========

[ramant (doing other things), 2016-06-20 16:45:24]

rtenneti@chromium.org changed reviewers:
+ rkaplow@chromium.org
- asvitkine@chromium.org

[ramant (doing other things), 2016-06-20 16:47:02]

Hi rkaplow@,
  A small change to track the crashes that are happening in cronet. Will delete
the histogram after collecting some data.

thanks
raman

[rkaplow, 2016-06-20 20:19:19]

https://codereview.chromium.org/2073323003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2073323003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:29036: +    enum="BooleanNullSession">
prefer instead of making a custom boolean enum, just use Boolean, and call
metric isNullSession

[ramant (doing other things), 2016-06-20 20:32:14]

https://codereview.chromium.org/2073323003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2073323003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:29036: +    enum="BooleanNullSession">
On 2016/06/20 20:19:18, rkaplow wrote:
> prefer instead of making a custom boolean enum, just use Boolean, and call
> metric isNullSession

Done.

[rkaplow, 2016-06-20 20:33:23]

lgtm

[ramant (doing other things), 2016-06-20 20:34:19]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-06-20 20:34:20]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2073323003/#ps20001
(title: "Fix comments")

[commit-bot: I haz the power, 2016-06-20 20:34:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073323003/20001

[commit-bot: I haz the power, 2016-06-20 21:38:09]

Description was changed from

==========
QUIC - Added a histogram to track number of times session_ is null when
QuicHttpStream::DoStreamRequest() is called. This crash was happening in
cronet (b/28676259).

Would like to remove the temporary fix if this crash doesn't happen.

Histogram name: Net.QuicHttpStream::DoStreamRequest.NullSession

BUG=616812
R=rkaplow@chromium.org, rch@chromium.org
==========

to

==========
QUIC - Added a histogram to track number of times session_ is null when
QuicHttpStream::DoStreamRequest() is called. This crash was happening in
cronet (b/28676259).

Would like to remove the temporary fix if this crash doesn't happen.

Histogram name: Net.QuicHttpStream::DoStreamRequest.NullSession

BUG=616812
R=rkaplow@chromium.org, rch@chromium.org
==========

[commit-bot: I haz the power, 2016-06-20 21:38:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-20 21:42:48]

Description was changed from

==========
QUIC - Added a histogram to track number of times session_ is null when
QuicHttpStream::DoStreamRequest() is called. This crash was happening in
cronet (b/28676259).

Would like to remove the temporary fix if this crash doesn't happen.

Histogram name: Net.QuicHttpStream::DoStreamRequest.NullSession

BUG=616812
R=rkaplow@chromium.org, rch@chromium.org
==========

to

==========
QUIC - Added a histogram to track number of times session_ is null when
QuicHttpStream::DoStreamRequest() is called. This crash was happening in
cronet (b/28676259).

Would like to remove the temporary fix if this crash doesn't happen.

Histogram name: Net.QuicHttpStream::DoStreamRequest.NullSession

BUG=616812
R=rkaplow@chromium.org, rch@chromium.org

Committed: https://crrev.com/9b30853b5857eb16dbbaa2560c04746b8d6f02e6
Cr-Commit-Position: refs/heads/master@{#400792}
==========

[commit-bot: I haz the power, 2016-06-20 21:42:49]

Patchset 2 (id:??) landed as
https://crrev.com/9b30853b5857eb16dbbaa2560c04746b8d6f02e6
Cr-Commit-Position: refs/heads/master@{#400792}