Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1973403002: QUIC - Add back to code to experiment with delay_tcp_race. By default, (Closed)

Created:
4 years, 7 months ago by ramant (doing other things)
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Add back to code to experiment with delay_tcp_race. By default, this experiment is enabled, but this change allows cronet and chromium to disable the delay_tcp_race via an experiment. This is a revert of the following CL, but by making delay_tcp_race enabled (always set to true and tests disable it and test it). https://codereview.chromium.org/1916783003/

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -3 lines) Patch
M chrome/browser/io_thread.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/cronet/url_request_context_config_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 3 chunks +8 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 3 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory.h View 3 chunks +6 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 3 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory_test.cc View 6 chunks +15 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1244073002 Patch 20001

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973403002/1
4 years, 7 months ago (2016-05-13 17:02:58 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/212073)
4 years, 7 months ago (2016-05-13 17:38:55 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973403002/20001
4 years, 7 months ago (2016-05-13 21:24:47 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 22:54:53 UTC) #9 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698