Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1684353002:
QUIC - check for null stream_ before calling stream_'s IsDoneReading (Closed)
|
Created:
4 years, 10 months ago by ramant (doing other things) Modified:
4 years, 10 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionQUIC - check for null stream_ before calling stream_'s IsDoneReading
method.
BUG=585591
R=rch@chromium.org
Committed: https://crrev.com/98f200dee65e6d75bd75f3884255b1a920db5e47
Cr-Commit-Position: refs/heads/master@{#375279}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 24 (13 generated)
The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684353002/1
The CQ bit was unchecked by rtenneti@chromium.org
Description was changed from ========== QUIC - check for null stream_ before calling stream_'s IsDoneReading method. BUG=585591 ========== to ========== QUIC - check for null stream_ before calling stream_'s IsDoneReading method. BUG=585591 R=rch@chromium.org ==========
rtenneti@chromium.org changed reviewers: + rch@chromium.org
Hi Ryan, We are crashing a lot on chromeos (in M48 and M49). It is one of the top crashes. Would like to see if it fixes the problem in M49. I have the following CL to find the root cause for why |stream_| becomes a nullptr. https://codereview.chromium.org/1688003005/ What do you think of this temporary fix for M49 (and possibly M48). thanks raman
lgtm Wacky!
asvitkine@chromium.org changed reviewers: + asvitkine@chromium.org
lgtm
The CQ bit was checked by rtenneti@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684353002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rtenneti@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684353002/1
Message was sent while issue was closed.
Description was changed from ========== QUIC - check for null stream_ before calling stream_'s IsDoneReading method. BUG=585591 R=rch@chromium.org ========== to ========== QUIC - check for null stream_ before calling stream_'s IsDoneReading method. BUG=585591 R=rch@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== QUIC - check for null stream_ before calling stream_'s IsDoneReading method. BUG=585591 R=rch@chromium.org ========== to ========== QUIC - check for null stream_ before calling stream_'s IsDoneReading method. BUG=585591 R=rch@chromium.org ==========
The CQ bit was checked by rtenneti@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684353002/1
The CQ bit was unchecked by rtenneti@chromium.org
Message was sent while issue was closed.
On 2016/02/14 23:26:53, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1684353002/1 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1684353002/1 It was already committed. Not sure why it didn't update the message. https://chromium.googlesource.com/chromium/src.git/+/98f200dee65e6d75bd75f388... Cr-Commit-Position: refs/heads/master@{#375279}
Message was sent while issue was closed.
Description was changed from ========== QUIC - check for null stream_ before calling stream_'s IsDoneReading method. BUG=585591 R=rch@chromium.org ========== to ========== QUIC - check for null stream_ before calling stream_'s IsDoneReading method. BUG=585591 R=rch@chromium.org Committed: https://crrev.com/98f200dee65e6d75bd75f3884255b1a920db5e47 Cr-Commit-Position: refs/heads/master@{#375279} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/98f200dee65e6d75bd75f3884255b1a920db5e47 Cr-Commit-Position: refs/heads/master@{#375279} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
