Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1916783003: QUIC - enable "delay_tcp_race" parameter by default. This feature showed (Closed)

Created:
4 years, 7 months ago by ramant (doing other things)
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - enable "delay_tcp_race" parameter by default. This feature showed positive results in stable channel and it will be enabled by default via finch trial in Stable and Beta (M50 and M51). R=rch@chromium.org,xunjieli@chromium.org Committed: https://crrev.com/634050c3f304a48f62c6ceb022a7f83945ea1968 Cr-Commit-Position: refs/heads/master@{#390468}

Patch Set 1 #

Patch Set 2 : Fix comments for patch set 1 #

Patch Set 3 : Deleted unneeded hanging get calls from unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -154 lines) Patch
M chrome/browser/io_thread.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 1 2 chunks +0 lines, -12 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/url_request_context_config.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M components/cronet/url_request_context_config_unittest.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 1 3 chunks +0 lines, -8 lines 0 comments Download
M net/http/http_network_session.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_network_session.cc View 1 3 chunks +1 line, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 2 24 chunks +5 lines, -54 lines 0 comments Download
M net/quic/quic_stream_factory.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 3 chunks +1 line, -3 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 6 chunks +1 line, -14 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 32 (13 generated)
ramant (doing other things)
4 years, 7 months ago (2016-04-25 18:45:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916783003/1
4 years, 7 months ago (2016-04-25 18:46:55 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/24537)
4 years, 7 months ago (2016-04-25 19:08:22 UTC) #5
Ryan Hamilton
lgtm
4 years, 7 months ago (2016-04-25 20:11:47 UTC) #6
Ryan Hamilton
On 2016/04/25 20:11:47, Ryan Hamilton wrote: > lgtm Or alternatively, just remove the param altogether?
4 years, 7 months ago (2016-04-25 20:12:12 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916783003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916783003/40001
4 years, 7 months ago (2016-04-26 21:04:58 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916783003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916783003/60001
4 years, 7 months ago (2016-04-26 21:41:26 UTC) #12
ramant (doing other things)
Many many thanks for suggesting deleting hanging gets (it saved tons of debugging). Was able ...
4 years, 7 months ago (2016-04-26 21:42:13 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-26 23:30:26 UTC) #15
ramant (doing other things)
Hi Ryan, Can you please take another look at this CL? thanks raman
4 years, 7 months ago (2016-04-27 23:18:29 UTC) #16
Ryan Hamilton
lgtm
4 years, 7 months ago (2016-04-28 05:36:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916783003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916783003/60001
4 years, 7 months ago (2016-04-28 16:58:49 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/174708)
4 years, 7 months ago (2016-04-28 17:07:44 UTC) #21
ramant (doing other things)
Hi Helen, Could you please take a look at cronet changes? thanks raman
4 years, 7 months ago (2016-04-28 17:48:14 UTC) #24
xunjieli
cronet lgtm.
4 years, 7 months ago (2016-04-28 20:31:28 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916783003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916783003/60001
4 years, 7 months ago (2016-04-28 20:35:27 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-04-28 20:42:05 UTC) #29
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/634050c3f304a48f62c6ceb022a7f83945ea1968 Cr-Commit-Position: refs/heads/master@{#390468}
4 years, 7 months ago (2016-04-30 17:20:50 UTC) #30
ramant (doing other things)
4 years, 7 months ago (2016-05-15 22:10:47 UTC) #32
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/1980883002/ by rtenneti@chromium.org.

The reason for reverting is: Reverting this CL so that we could experiment
delay_tcp_race..

Powered by Google App Engine
This is Rietveld 408576698