Landing Recent QUIC changes until 2/12/2016 21:32 UTC

Landing Recent QUIC changes until 2/12/2016 21:32 UTC

relnote: Remove QuicPacketCreator::DebugDelegate from the QuicConnectionDebugVisitor
interface, because it's never implemented in internal server.

No functional change, saves 0.32% CPU.

Chromium does have one implementer, QuicConnectionLogger that will need
to implement QuicPacketCreator::DebugDelegate directly now.

chromium specific changes:
  Updated QuicConnectionLogger and quic_chromium_client_session.cc to
  handle this change.

Merge internal change: 114565016
https://codereview.chromium.org/1712043002/

relnote: Call QUIC's underlying SendAlgorithm's PacingRate() directly
instead of PacingSender's.  No functional change.

Merge internal change: 114534940
https://codereview.chromium.org/1708223004/

QUIC: Add support to decrypt using several keys.

SetKeys could be used to specify a list of encryption keys. The first
key in the list will be used by |Box|, but all supplied keys will be
tried by |Unbox|.

Merge internal change: 114465990
https://codereview.chromium.org/1715593002/

relnote: Deprecate FLAGS_quic_time_wait_list_manager_use_shared_writer.

Merge internal change: 114217654
https://codereview.chromium.org/1710873003/

relnote: Deprecate FLAGS_quic_retransmit_via_onserializedpacket.

Merge internal change: 114161124
https://codereview.chromium.org/1710173002/

R=rch@chromium.org

Committed: https://crrev.com/0dcd785c80a2b74d67a43c1317e316688fa71044
Cr-Commit-Position: refs/heads/master@{#376503}

[ramant (doing other things), 2016-02-18 23:54:23]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 23:58:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714713002/1

[commit-bot: I haz the power, 2016-02-19 01:26:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 01:26:39]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-02-19 03:06:54]

I think it would be a good idea to revert (or un-land) the CL which was
reverted. (And also, please tweak the CL description on the crypto boxer CL).

Thanks so much for doing this so quickly!

lgtm

[ramant (doing other things), 2016-02-19 18:37:18]

Description was changed from

==========
Landing Recent QUIC changes until 2/12/2016 21:32 UTC


relnote: Remove QuicPacketCreator::DebugDelegate from the
QuicConnectionDebugVisitor
interface, because it's never implemented in internal server.

No functional change, saves 0.32% CPU.

Chromium does have one implementer, QuicConnectionLogger that will need
to implement QuicPacketCreator::DebugDelegate directly now.

chromium specific changes:
  Updated QuicConnectionLogger and quic_chromium_client_session.cc to
  handle this change.

Merge internal change: 114565016
https://codereview.chromium.org/1712043002/


relnote: Call QUIC's underlying SendAlgorithm's PacingRate() directly
instead of PacingSender's.  No functional change.

Merge internal change: 114534940
https://codereview.chromium.org/1708223004/


QUIC: obtain source address token keys from internal key server.

We've discovered that the gradual fleet-wide rotation of the internal
server's primary key causes a weekly spike of
SOURCE_ADDRESS_TOKEN_DECRYPTION_FAILURE, because this key is used to
derive QUIC's source address token key.

This CL fixes the problem by fetching the key from internal key server,
and (for backup) changing QUIC to attempt token decryption using several
keys.

Merge internal change: 114465990
https://codereview.chromium.org/1715593002/


relnote: Deprecate FLAGS_quic_time_wait_list_manager_use_shared_writer.

Merge internal change: 114217654
https://codereview.chromium.org/1710873003/


relnote: Deprecate FLAGS_quic_retransmit_via_onserializedpacket.

Merge internal change: 114161124
https://codereview.chromium.org/1710173002/

R=rch@chromium.org
==========

to

==========
Landing Recent QUIC changes until 2/12/2016 21:32 UTC


relnote: Remove QuicPacketCreator::DebugDelegate from the
QuicConnectionDebugVisitor
interface, because it's never implemented in internal server.

No functional change, saves 0.32% CPU.

Chromium does have one implementer, QuicConnectionLogger that will need
to implement QuicPacketCreator::DebugDelegate directly now.

chromium specific changes:
  Updated QuicConnectionLogger and quic_chromium_client_session.cc to
  handle this change.

Merge internal change: 114565016
https://codereview.chromium.org/1712043002/


relnote: Call QUIC's underlying SendAlgorithm's PacingRate() directly
instead of PacingSender's.  No functional change.

Merge internal change: 114534940
https://codereview.chromium.org/1708223004/


QUIC: Add support to decrypt using several keys.

SetKeys could be used to specify a list of encryption keys. The first
key in the list will be used by |Box|, but all supplied keys will be
tried by |Unbox|.

Merge internal change: 114465990
https://codereview.chromium.org/1715593002/


relnote: Deprecate FLAGS_quic_time_wait_list_manager_use_shared_writer.

Merge internal change: 114217654
https://codereview.chromium.org/1710873003/


relnote: Deprecate FLAGS_quic_retransmit_via_onserializedpacket.

Merge internal change: 114161124
https://codereview.chromium.org/1710173002/

R=rch@chromium.org
==========

[ramant (doing other things), 2016-02-19 18:42:33]

On 2016/02/19 03:06:54, Ryan Hamilton wrote:
> I think it would be a good idea to revert (or un-land) the CL which was
> reverted. (And also, please tweak the CL description on the crypto boxer CL).
> 
> Thanks so much for doing this so quickly!
> 
> lgtm

This CL doesn't have stateless reject changes. 

Updated the crypto boxer CL description.

Thanks Ryan.

[ramant (doing other things), 2016-02-19 18:42:43]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2016-02-19 18:45:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714713002/1

[commit-bot: I haz the power, 2016-02-19 18:55:50]

Description was changed from

==========
Landing Recent QUIC changes until 2/12/2016 21:32 UTC


relnote: Remove QuicPacketCreator::DebugDelegate from the
QuicConnectionDebugVisitor
interface, because it's never implemented in internal server.

No functional change, saves 0.32% CPU.

Chromium does have one implementer, QuicConnectionLogger that will need
to implement QuicPacketCreator::DebugDelegate directly now.

chromium specific changes:
  Updated QuicConnectionLogger and quic_chromium_client_session.cc to
  handle this change.

Merge internal change: 114565016
https://codereview.chromium.org/1712043002/


relnote: Call QUIC's underlying SendAlgorithm's PacingRate() directly
instead of PacingSender's.  No functional change.

Merge internal change: 114534940
https://codereview.chromium.org/1708223004/


QUIC: Add support to decrypt using several keys.

SetKeys could be used to specify a list of encryption keys. The first
key in the list will be used by |Box|, but all supplied keys will be
tried by |Unbox|.

Merge internal change: 114465990
https://codereview.chromium.org/1715593002/


relnote: Deprecate FLAGS_quic_time_wait_list_manager_use_shared_writer.

Merge internal change: 114217654
https://codereview.chromium.org/1710873003/


relnote: Deprecate FLAGS_quic_retransmit_via_onserializedpacket.

Merge internal change: 114161124
https://codereview.chromium.org/1710173002/

R=rch@chromium.org
==========

to

==========
Landing Recent QUIC changes until 2/12/2016 21:32 UTC


relnote: Remove QuicPacketCreator::DebugDelegate from the
QuicConnectionDebugVisitor
interface, because it's never implemented in internal server.

No functional change, saves 0.32% CPU.

Chromium does have one implementer, QuicConnectionLogger that will need
to implement QuicPacketCreator::DebugDelegate directly now.

chromium specific changes:
  Updated QuicConnectionLogger and quic_chromium_client_session.cc to
  handle this change.

Merge internal change: 114565016
https://codereview.chromium.org/1712043002/


relnote: Call QUIC's underlying SendAlgorithm's PacingRate() directly
instead of PacingSender's.  No functional change.

Merge internal change: 114534940
https://codereview.chromium.org/1708223004/


QUIC: Add support to decrypt using several keys.

SetKeys could be used to specify a list of encryption keys. The first
key in the list will be used by |Box|, but all supplied keys will be
tried by |Unbox|.

Merge internal change: 114465990
https://codereview.chromium.org/1715593002/


relnote: Deprecate FLAGS_quic_time_wait_list_manager_use_shared_writer.

Merge internal change: 114217654
https://codereview.chromium.org/1710873003/


relnote: Deprecate FLAGS_quic_retransmit_via_onserializedpacket.

Merge internal change: 114161124
https://codereview.chromium.org/1710173002/

R=rch@chromium.org
==========

[commit-bot: I haz the power, 2016-02-19 18:55:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-19 18:57:52]

Description was changed from

==========
Landing Recent QUIC changes until 2/12/2016 21:32 UTC


relnote: Remove QuicPacketCreator::DebugDelegate from the
QuicConnectionDebugVisitor
interface, because it's never implemented in internal server.

No functional change, saves 0.32% CPU.

Chromium does have one implementer, QuicConnectionLogger that will need
to implement QuicPacketCreator::DebugDelegate directly now.

chromium specific changes:
  Updated QuicConnectionLogger and quic_chromium_client_session.cc to
  handle this change.

Merge internal change: 114565016
https://codereview.chromium.org/1712043002/


relnote: Call QUIC's underlying SendAlgorithm's PacingRate() directly
instead of PacingSender's.  No functional change.

Merge internal change: 114534940
https://codereview.chromium.org/1708223004/


QUIC: Add support to decrypt using several keys.

SetKeys could be used to specify a list of encryption keys. The first
key in the list will be used by |Box|, but all supplied keys will be
tried by |Unbox|.

Merge internal change: 114465990
https://codereview.chromium.org/1715593002/


relnote: Deprecate FLAGS_quic_time_wait_list_manager_use_shared_writer.

Merge internal change: 114217654
https://codereview.chromium.org/1710873003/


relnote: Deprecate FLAGS_quic_retransmit_via_onserializedpacket.

Merge internal change: 114161124
https://codereview.chromium.org/1710173002/

R=rch@chromium.org
==========

to

==========
Landing Recent QUIC changes until 2/12/2016 21:32 UTC

relnote: Remove QuicPacketCreator::DebugDelegate from the
QuicConnectionDebugVisitor
interface, because it's never implemented in internal server.

No functional change, saves 0.32% CPU.

Chromium does have one implementer, QuicConnectionLogger that will need
to implement QuicPacketCreator::DebugDelegate directly now.

chromium specific changes:
  Updated QuicConnectionLogger and quic_chromium_client_session.cc to
  handle this change.

Merge internal change: 114565016
https://codereview.chromium.org/1712043002/

relnote: Call QUIC's underlying SendAlgorithm's PacingRate() directly
instead of PacingSender's.  No functional change.

Merge internal change: 114534940
https://codereview.chromium.org/1708223004/

QUIC: Add support to decrypt using several keys.

SetKeys could be used to specify a list of encryption keys. The first
key in the list will be used by |Box|, but all supplied keys will be
tried by |Unbox|.

Merge internal change: 114465990
https://codereview.chromium.org/1715593002/

relnote: Deprecate FLAGS_quic_time_wait_list_manager_use_shared_writer.

Merge internal change: 114217654
https://codereview.chromium.org/1710873003/

relnote: Deprecate FLAGS_quic_retransmit_via_onserializedpacket.

Merge internal change: 114161124
https://codereview.chromium.org/1710173002/

R=rch@chromium.org

Committed: https://crrev.com/0dcd785c80a2b74d67a43c1317e316688fa71044
Cr-Commit-Position: refs/heads/master@{#376503}
==========

[commit-bot: I haz the power, 2016-02-19 18:57:53]

Patchset 1 (id:??) landed as
https://crrev.com/0dcd785c80a2b74d67a43c1317e316688fa71044
Cr-Commit-Position: refs/heads/master@{#376503}