Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1633373002: relnote: moves ProcessPacketInterface from quic_dispatcher.h to (Closed)

Created:
4 years, 11 months ago by ramant (doing other things)
Modified:
4 years, 11 months ago
Reviewers:
Jana, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, danzh1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: moves ProcessPacketInterface from quic_dispatcher.h to quic_packet_reader.h, and updates QuiClient to implement this interface. No functional change to internal server. add an new member function in quic client to read multiple packets per call. FIXED=21846229 Merge internal change: 101790938 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -12 lines) Patch
M net/tools/quic/quic_client.h View 5 chunks +19 lines, -1 line 0 comments Download
M net/tools/quic/quic_client.cc View 5 chunks +25 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 2 chunks +1 line, -8 lines 0 comments Download
M net/tools/quic/quic_packet_reader.h View 1 chunk +8 lines, -1 line 0 comments Download
M net/tools/quic/quic_packet_reader.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1633373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1633373002/1
4 years, 11 months ago (2016-01-27 02:52:08 UTC) #4
ramant (doing other things)
Hi Ryan and Jana, The following CL was my original attempt at porting it and ...
4 years, 11 months ago (2016-01-27 02:58:54 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/170836)
4 years, 11 months ago (2016-01-27 03:01:42 UTC) #7
Ryan Hamilton
I think you need to get this rebased onto master. Can you make it no ...
4 years, 11 months ago (2016-01-27 16:54:00 UTC) #8
ramant (doing other things)
4 years, 11 months ago (2016-01-27 17:34:38 UTC) #9
On 2016/01/27 16:54:00, Ryan Hamilton wrote:
> I think you need to get this rebased onto master. Can you make it no longer
> dependent on a patch set which landed long ago?

Thanks Ryan. Uploaded a new CL https://codereview.chromium.org/1640343002/
Closing this CL.

Powered by Google App Engine
This is Rietveld 408576698