QUIC - When write fails durin sending headers (WriteHeaders call)

QUIC - When write fails durin sending headers (WriteHeaders call)
because of network change, QUIC closes connection and stream, but
QuicHttpStream's continues to process because WriteHeaders returns
the number of bytes written.

Check if stream_ is closed in DoSendHeadersComplete and if so return
the error code (response_status_).

R=rch@chromium.org
BUG=577377
Committed: https://crrev.com/56977819315264e3d021eb316244fe2d3639900d
Cr-Commit-Position: refs/heads/master@{#369808}

[Ryan Hamilton, 2016-01-15 05:02:34]

lgtm

https://codereview.chromium.org/1576353011/diff/20001/net/quic/quic_http_stre...
File net/quic/quic_http_stream.cc (right):

https://codereview.chromium.org/1576353011/diff/20001/net/quic/quic_http_stre...
net/quic/quic_http_stream.cc:453: // If the stream is already closed, don't
request the body.
nit: I'd move this above the if and remove the {}s.

Also I think you want to say "don't read the request body" not "don't request
the body"

[ramant (doing other things), 2016-01-15 18:03:05]

Thanks Ryan
raman

https://codereview.chromium.org/1576353011/diff/20001/net/quic/quic_http_stre...
File net/quic/quic_http_stream.cc (right):

https://codereview.chromium.org/1576353011/diff/20001/net/quic/quic_http_stre...
net/quic/quic_http_stream.cc:453: // If the stream is already closed, don't
request the body.
On 2016/01/15 05:02:34, Ryan Hamilton wrote:
> nit: I'd move this above the if and remove the {}s.
> 
> Also I think you want to say "don't read the request body" not "don't request
> the body"

Done.

[ramant (doing other things), 2016-01-15 18:03:09]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2016-01-15 18:03:10]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1576353011/#ps40001
(title: "fix comments")

[commit-bot: I haz the power, 2016-01-15 18:04:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1576353011/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1576353011/40001

[commit-bot: I haz the power, 2016-01-15 19:27:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-15 19:28:22]

Description was changed from

==========
QUIC - When write fails durin sending headers (WriteHeaders call)
because of network change, QUIC closes connection and stream, but
QuicHttpStream's continues to process because WriteHeaders returns
the number of bytes written.

Check if stream_ is closed in DoSendHeadersComplete and if so return
the error code (response_status_).

R=rch@chromium.org
BUG=577377
==========

to

==========
QUIC - When write fails durin sending headers (WriteHeaders call)
because of network change, QUIC closes connection and stream, but
QuicHttpStream's continues to process because WriteHeaders returns
the number of bytes written.

Check if stream_ is closed in DoSendHeadersComplete and if so return
the error code (response_status_).

R=rch@chromium.org
BUG=577377

Committed: https://crrev.com/56977819315264e3d021eb316244fe2d3639900d
Cr-Commit-Position: refs/heads/master@{#369808}
==========

[commit-bot: I haz the power, 2016-01-15 19:28:22]

Patchset 3 (id:??) landed as
https://crrev.com/56977819315264e3d021eb316244fe2d3639900d
Cr-Commit-Position: refs/heads/master@{#369808}