Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 1506353008: HttpServerProperties - Added a histogram to track the AlternateProtocolServers (Closed)

Created:
5 years ago by ramant (doing other things)
Modified:
5 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, Bence, ianswett
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HttpServerProperties - Added a histogram to track the AlternateProtocolServers that are in memory. R=asvitkine@chromium.org, rch@chromium.org Committed: https://crrev.com/f635e8507d82be6c5e82ab3d145ca0004510f919 Cr-Commit-Position: refs/heads/master@{#364744}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix comments #

Total comments: 2

Patch Set 3 : fixed typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M net/http/http_server_properties_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +16 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
ramant (doing other things)
5 years ago (2015-12-10 19:46:28 UTC) #1
Ryan Hamilton
lgtm
5 years ago (2015-12-10 19:54:45 UTC) #3
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1506353008/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1506353008/diff/1/tools/metrics/histograms/histograms.xml#newcode22722 tools/metrics/histograms/histograms.xml:22722: +<histogram name="Net.CountOfAlternateProtocolServers.Memory"> Add units="servers". https://codereview.chromium.org/1506353008/diff/1/tools/metrics/histograms/histograms.xml#newcode22727 tools/metrics/histograms/histograms.xml:22727: + The ...
5 years ago (2015-12-10 20:35:33 UTC) #4
ramant (doing other things)
Hi Alexei, Would appreciate if you could take another look. thanks raman https://codereview.chromium.org/1506353008/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml ...
5 years ago (2015-12-10 22:54:45 UTC) #5
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1506353008/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1506353008/diff/20001/tools/metrics/histograms/histograms.xml#newcode22727 tools/metrics/histograms/histograms.xml:22727: + The total number of severs (HostPortPairs in ...
5 years ago (2015-12-11 16:28:24 UTC) #6
ramant (doing other things)
Thanks Alexei. https://codereview.chromium.org/1506353008/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1506353008/diff/20001/tools/metrics/histograms/histograms.xml#newcode22727 tools/metrics/histograms/histograms.xml:22727: + The total number of severs (HostPortPairs ...
5 years ago (2015-12-11 16:55:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1506353008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1506353008/40001
5 years ago (2015-12-11 16:58:01 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-11 18:30:39 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-11 18:31:24 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f635e8507d82be6c5e82ab3d145ca0004510f919
Cr-Commit-Position: refs/heads/master@{#364744}

Powered by Google App Engine
This is Rietveld 408576698