HttpServerProperties - Minor reorganization of code in preperation of

HttpServerProperties - Minor reorganization of code in preperation for
saving servers as list of servers instead of dictionary.

AddServersData is the shared code that parses a dictionary
of server/servers.

Minor reordering of function prototype order to match the defintion
in C code.

BUG=568386
R=rch@chromium.org

Committed: https://crrev.com/e4f0e650d8e1540ce5bbaf0ca225f75d4a12fe25
Cr-Commit-Position: refs/heads/master@{#366647}

[ramant (doing other things), 2015-12-21 23:58:58]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-21 23:59:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546493002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546493002/1

[ramant (doing other things), 2015-12-22 00:24:03]

Description was changed from

==========
HttpServerProperties - Minor reorganization of code in preperation of
saving servers as list of servers instead of dictionary.

AddServersData will be the shared code between to parse a dictionary
of servers. In future, it could be a list of server dictionaries.

Minor reordering of function prototype order to match the defintion
in C code.

BUG=568386
R=rch@chromium.org
==========

to

==========
HttpServerProperties - Minor reorganization of code in preperation for
saving servers as list of servers instead of dictionary.

AddServersData is the shared code that parses a dictionary
of server/servers.

Minor reordering of function prototype order to match the defintion
in C code.

BUG=568386
R=rch@chromium.org
==========

[Ryan Hamilton, 2015-12-22 18:25:32]

lgtm

Nice cleanup! One minor nit. But feel free to ignore or do later if it's
cumbersome.

https://codereview.chromium.org/1546493002/diff/20001/net/http/http_server_pr...
File net/http/http_server_properties_manager.h (right):

https://codereview.chromium.org/1546493002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.h:219: typedef std::vector<std::string>
StringVector;
If this is only used for the SPDY server list, then how about "ServerList" as
the data type to describe the function, not the form.

[ramant (doing other things), 2015-12-22 20:00:09]

Thanks much Ryan. Made the change.

https://codereview.chromium.org/1546493002/diff/20001/net/http/http_server_pr...
File net/http/http_server_properties_manager.h (right):

https://codereview.chromium.org/1546493002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.h:219: typedef std::vector<std::string>
StringVector;
On 2015/12/22 18:25:32, Ryan Hamilton wrote:
> If this is only used for the SPDY server list, then how about "ServerList" as
> the data type to describe the function, not the form.

Done.

[ramant (doing other things), 2015-12-22 20:00:23]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2015-12-22 20:00:24]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1546493002/#ps40001
(title: "Use ServerList - fix comments for PatchSet 1")

[commit-bot: I haz the power, 2015-12-22 20:00:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1546493002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1546493002/40001

[commit-bot: I haz the power, 2015-12-22 21:04:06]

Description was changed from

==========
HttpServerProperties - Minor reorganization of code in preperation for
saving servers as list of servers instead of dictionary.

AddServersData is the shared code that parses a dictionary
of server/servers.

Minor reordering of function prototype order to match the defintion
in C code.

BUG=568386
R=rch@chromium.org
==========

to

==========
HttpServerProperties - Minor reorganization of code in preperation for
saving servers as list of servers instead of dictionary.

AddServersData is the shared code that parses a dictionary
of server/servers.

Minor reordering of function prototype order to match the defintion
in C code.

BUG=568386
R=rch@chromium.org
==========

[commit-bot: I haz the power, 2015-12-22 21:04:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-22 21:05:06]

Description was changed from

==========
HttpServerProperties - Minor reorganization of code in preperation for
saving servers as list of servers instead of dictionary.

AddServersData is the shared code that parses a dictionary
of server/servers.

Minor reordering of function prototype order to match the defintion
in C code.

BUG=568386
R=rch@chromium.org
==========

to

==========
HttpServerProperties - Minor reorganization of code in preperation for
saving servers as list of servers instead of dictionary.

AddServersData is the shared code that parses a dictionary
of server/servers.

Minor reordering of function prototype order to match the defintion
in C code.

BUG=568386
R=rch@chromium.org

Committed: https://crrev.com/e4f0e650d8e1540ce5bbaf0ca225f75d4a12fe25
Cr-Commit-Position: refs/heads/master@{#366647}
==========

[commit-bot: I haz the power, 2015-12-22 21:05:07]

Patchset 3 (id:??) landed as
https://crrev.com/e4f0e650d8e1540ce5bbaf0ca225f75d4a12fe25
Cr-Commit-Position: refs/heads/master@{#366647}