Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1679113002: QUIC - Make |visitor_| nullptr check consistent with other nullptr (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Make |visitor_| nullptr check consistent with other nullptr checks in the file. R=glider@chromium.org, rch@chromium.org Committed: https://crrev.com/fbbed02aa35259b84e0ba7f8c964fe3dd11ba029 Cr-Commit-Position: refs/heads/master@{#374421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/quic/quic_connection.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1244073002 Patch 20001

Messages

Total messages: 8 (2 generated)
ramant (doing other things)
4 years, 10 months ago (2016-02-09 00:09:25 UTC) #1
Ryan Hamilton
lgtm
4 years, 10 months ago (2016-02-09 05:25:57 UTC) #2
Alexander Potapenko
lgtm
4 years, 10 months ago (2016-02-09 07:10:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679113002/1
4 years, 10 months ago (2016-02-09 17:12:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 18:37:06 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 18:39:25 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fbbed02aa35259b84e0ba7f8c964fe3dd11ba029
Cr-Commit-Position: refs/heads/master@{#374421}

Powered by Google App Engine
This is Rietveld 408576698