Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2002713003: QUIC - Pass remote_address_ if address is not specified in UDPSocketWin::Write() (Closed)

Created:
4 years, 7 months ago by ramant (doing other things)
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Pass remote_address_ if address is not specified in UDPSocketWin::Write() call. WSASendTo API call requires address and tsvipcli.dll crashes if address is NULL. Revered the changes to disable QUIC when tsvipcli.dll is loaded. https://codereview.chromium.org/1999893002/ BUG=471986 R=rch@chromium.org Committed: https://crrev.com/b01cd3b37e9daff57a621bcd6efd640cddac6d1e Cr-Commit-Position: refs/heads/master@{#395237}

Patch Set 1 #

Patch Set 2 : reverted CL - 1999893002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M net/quic/quic_stream_factory.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M net/udp/udp_socket_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
ramant (doing other things)
4 years, 7 months ago (2016-05-21 01:25:40 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002713003/20001
4 years, 7 months ago (2016-05-21 01:39:19 UTC) #4
Ryan Hamilton
lgtm Woo hoo!
4 years, 7 months ago (2016-05-21 01:53:35 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-21 02:45:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002713003/20001
4 years, 7 months ago (2016-05-21 02:46:54 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-21 02:51:01 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 02:52:29 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b01cd3b37e9daff57a621bcd6efd640cddac6d1e
Cr-Commit-Position: refs/heads/master@{#395237}

Powered by Google App Engine
This is Rietveld 408576698