Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1754813002: Revert of QUIC - instrumentation for testing null QuicSpdyStream. (Closed)

Created:
4 years, 9 months ago by ramant (doing other things)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, ianswett, Buck
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - instrumentation for testing null QuicSpdyStream. (patchset #5 id:100001 of https://codereview.chromium.org/1688003005/ ) Reason for revert: We got the call stack that causes the crash. Reverting this change. Will add the check for nullptr and the unit tests. Original issue's description: > QUIC - instrumentation for testing null QuicSpdyStream. > > BUG=585591 > R=rch@chromium.org,eroman@chromium.org > > Committed: https://crrev.com/100e39060a98afdc80f7a5140f6ba690746261b9 > Cr-Commit-Position: refs/heads/master@{#375804} TBR=rch@chromium.org,eroman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585591 Committed: https://crrev.com/45e15292b538db8e1b60f4e0eeea1c0587e3c190 Cr-Commit-Position: refs/heads/master@{#378582}

Patch Set 1 #

Patch Set 2 : rebase tot #

Patch Set 3 : Rebase TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -53 lines) Patch
M net/quic/quic_http_stream.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_http_stream.cc View 1 2 2 chunks +0 lines, -19 lines 0 comments Download
M net/quic/quic_spdy_stream.h View 1 3 chunks +0 lines, -14 lines 0 comments Download
M net/quic/quic_spdy_stream.cc View 1 2 chunks +0 lines, -17 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (9 generated)
ramant (doing other things)
Created Revert of QUIC - instrumentation for testing null QuicSpdyStream.
4 years, 9 months ago (2016-03-01 19:50:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754813002/1
4 years, 9 months ago (2016-03-01 19:51:28 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/138600) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-01 19:54:59 UTC) #4
eroman
lgtm
4 years, 9 months ago (2016-03-01 20:00:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754813002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754813002/130001
4 years, 9 months ago (2016-03-01 20:20:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/138620) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-01 20:23:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754813002/150001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754813002/150001
4 years, 9 months ago (2016-03-01 20:53:53 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:150001)
4 years, 9 months ago (2016-03-01 22:40:31 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 22:42:34 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/45e15292b538db8e1b60f4e0eeea1c0587e3c190
Cr-Commit-Position: refs/heads/master@{#378582}

Powered by Google App Engine
This is Rietveld 408576698