Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1769713002: Revert of "Revert 'QUIC - check for null stream_ before calling stream_'s IsDoneReading'" (Closed)

Created:
4 years, 9 months ago by ramant (doing other things)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "Revert 'QUIC - check for null stream_ before calling stream_'s IsDoneReading'" Reason for revert: Reverting this change and adding the check for nullptr to fix the crash. Original issue's description: >Revert "QUIC - check for null stream_ before calling stream_'s IsDoneReading" > >This reverts commit 98f200dee65e6d75bd75f3884255b1a920db5e47. > >BUG=585591 >TBR=rch@chromium.org,asvitkine@chromium.org > >Committed: https://crrev.com/4937af0e28fb73a4e6c8bb088cf1be8575ca761d >Cr-Commit-Position: refs/heads/master@{#375789}} BUG=585591 TBR=rch@chromium.org,asvitkine@chromium.org Committed: https://crrev.com/6dd65c042d8100cd5804c96ea0081a408fcb5d5d Cr-Commit-Position: refs/heads/master@{#379424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M net/quic/quic_http_stream.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +13 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769713002/1
4 years, 9 months ago (2016-03-04 23:54:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-05 01:17:53 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 01:18:45 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dd65c042d8100cd5804c96ea0081a408fcb5d5d
Cr-Commit-Position: refs/heads/master@{#379424}

Powered by Google App Engine
This is Rietveld 408576698