Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1977303002: Revert of QUIC - enable "delay_tcp_race" parameter by default. This feature showed (patchset #3 id:… (Closed)

Created:
4 years, 7 months ago by ramant (doing other things)
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of QUIC - enable "delay_tcp_race" parameter by default. This feature showed (patchset #3 id:60001 of https://codereview.chromium.org/1916783003/ ) Reason for revert: Reverting this CL so that we could experiment delay_tcp_race. Original issue's description: > QUIC - enable "delay_tcp_race" parameter by default. This feature showed > positive results in stable channel and it will be enabled by default > via finch trial in Stable and Beta (M50 and M51). > > R=rch@chromium.org,xunjieli@chromium.org > > Committed: https://crrev.com/634050c3f304a48f62c6ceb022a7f83945ea1968 > Cr-Commit-Position: refs/heads/master@{#390468} TBR=rch@chromium.org,xunjieli@chromium.org Committed: https://crrev.com/b8e80fb5d475ac2b98fd87b25a111d3c4b0e28b0 Cr-Commit-Position: refs/heads/master@{#393778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -10 lines) Patch
M chrome/browser/io_thread.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/cronet/url_request_context_config_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 3 chunks +8 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_network_session.cc View 3 chunks +3 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 25 chunks +50 lines, -5 lines 0 comments Download
M net/quic/quic_stream_factory.h View 3 chunks +6 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 3 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory_test.cc View 6 chunks +14 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
ramant (doing other things)
This is same as https://codereview.chromium.org/1980883002/ (which was reverted using "Reverse PatchSet" button). I did a ...
4 years, 7 months ago (2016-05-15 22:36:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977303002/1
4 years, 7 months ago (2016-05-15 22:36:33 UTC) #3
Ryan Hamilton
lgtm Thanks for doing this, Raman
4 years, 7 months ago (2016-05-15 22:59:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-15 23:44:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977303002/1
4 years, 7 months ago (2016-05-16 00:08:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 00:12:20 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 00:13:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8e80fb5d475ac2b98fd87b25a111d3c4b0e28b0
Cr-Commit-Position: refs/heads/master@{#393778}

Powered by Google App Engine
This is Rietveld 408576698