QUIC - cronet - added idle_connection_timeout_seconds and disable experiments

QUIC - cronet - added idle_connection_timeout_seconds  experiment
that could be enabled via finch trials.

- idle_connection_timeout_seconds
  Specifes QUIC idle connection state lifetime. Default value is 30secs.

R=rch@chromium.org, xunjieli@chromium.org

Committed: https://crrev.com/64e809d03a59d44e42960058371035866f8a1038
Cr-Commit-Position: refs/heads/master@{#364545}

[ramant (doing other things), 2015-12-08 02:36:15]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-08 02:37:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505983003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505983003/1

[commit-bot: I haz the power, 2015-12-08 03:21:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 03:21:59]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[ramant (doing other things), 2015-12-08 18:54:42]

Patchset #1 (id:1) has been deleted

[ramant (doing other things), 2015-12-08 18:54:50]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-08 18:56:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505983003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505983003/20001

[commit-bot: I haz the power, 2015-12-08 19:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 19:12:46]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ramant (doing other things), 2015-12-08 23:58:17]

Patchset #1 (id:20001) has been deleted

[ramant (doing other things), 2015-12-08 23:59:29]

Description was changed from

==========
QUIC - cronet - added the following experiments that could be enabled
via finch trials.

- idle_connection_timeout_seconds
  Specifes QUIC idle connection state lifetime. Default value is 30secs.

- disable_preconnect_if_0rtt
  disables PreConnect if QUIC can do 0RTT. Default value is false.
==========

to

==========
QUIC - cronet - added the following experiments that could be enabled
via finch trials.

- idle_connection_timeout_seconds
  Specifes QUIC idle connection state lifetime. Default value is 30secs.

- disable_preconnect_if_0rtt
  disables PreConnect if QUIC can do 0RTT. Default value is false.

R=rch@chromium.org, xunjieli@chromium.org
==========

[ramant (doing other things), 2015-12-08 23:59:29]

rtenneti@chromium.org changed reviewers:
+ rch@chromium.org, xunjieli@chromium.org

[ramant (doing other things), 2015-12-09 00:00:42]

Description was changed from

==========
QUIC - cronet - added the following experiments that could be enabled
via finch trials.

- idle_connection_timeout_seconds
  Specifes QUIC idle connection state lifetime. Default value is 30secs.

- disable_preconnect_if_0rtt
  disables PreConnect if QUIC can do 0RTT. Default value is false.

R=rch@chromium.org, xunjieli@chromium.org
==========

to

==========
QUIC - cronet - added idle_connection_timeout_seconds and disable experiments
that could be enabled via finch trials.

- idle_connection_timeout_seconds
  Specifes QUIC idle connection state lifetime. Default value is 30secs.

- disable_preconnect_if_0rtt
  disables PreConnect if QUIC can do 0RTT. Default value is false.

R=rch@chromium.org, xunjieli@chromium.org
==========

[xunjieli, 2015-12-09 00:07:34]

Paul has a CL that touched some of the files. That CL is probably gonna land
soon. 
Maybe rebased on his? https://codereview.chromium.org/1429863008/

Thanks! I will take a look at this tomorrow.

[ramant (doing other things), 2015-12-09 02:41:22]

On 2015/12/09 00:07:34, xunjieli wrote:
> Paul has a CL that touched some of the files. That CL is probably gonna land
> soon. 
> Maybe rebased on his? https://codereview.chromium.org/1429863008/
> 
> Thanks! I will take a look at this tomorrow.

Sounds great. Will wait for his CL to land and will make changes after his
changes land. thanks.

[xunjieli, 2015-12-09 15:44:38]

On 2015/12/09 02:41:22, ramant wrote:
> On 2015/12/09 00:07:34, xunjieli wrote:
> > Paul has a CL that touched some of the files. That CL is probably gonna land
> > soon. 
> > Maybe rebased on his? https://codereview.chromium.org/1429863008/
> > 
> > Thanks! I will take a look at this tomorrow.
> 
> Sounds great. Will wait for his CL to land and will make changes after his
> changes land. thanks.

Paul's CL just landed. I think the changes that need to be manually merged is in
components/cronet/url_request_context_config_unittest.cc.

[ramant (doing other things), 2015-12-09 21:03:09]

Hi Helen and Misha,
  Does cronet use PreConnect? If cronet doesn't use PreConnect, we don't need to
add that finch trial option.

thanks
raman

[xunjieli, 2015-12-09 21:05:38]

On 2015/12/09 21:03:09, ramant wrote:
> Hi Helen and Misha,
>   Does cronet use PreConnect? If cronet doesn't use PreConnect, we don't need
to
> add that finch trial option.
> 
> thanks
> raman

Are you referring to rel=preconnect ? I don't think we do.

[ramant (doing other things), 2015-12-09 21:06:37]

On 2015/12/09 21:03:09, ramant wrote:
> Hi Helen and Misha,
>   Does cronet use PreConnect? If cronet doesn't use PreConnect, we don't need
to
> add that finch trial option.
> 
> thanks
> raman

BTW: IdleConnectionTimeout wouldn't have an impact when we compare HTTP2 with
QUIC (if connections are made every 1 minute). This experiment option, would
give a way to set the same timeout values for QUIC as HTTP2.

[ramant (doing other things), 2015-12-09 21:21:50]

Description was changed from

==========
QUIC - cronet - added idle_connection_timeout_seconds and disable experiments
that could be enabled via finch trials.

- idle_connection_timeout_seconds
  Specifes QUIC idle connection state lifetime. Default value is 30secs.

- disable_preconnect_if_0rtt
  disables PreConnect if QUIC can do 0RTT. Default value is false.

R=rch@chromium.org, xunjieli@chromium.org
==========

to

==========
QUIC - cronet - added idle_connection_timeout_seconds  experiment
that could be enabled via finch trials.

- idle_connection_timeout_seconds
  Specifes QUIC idle connection state lifetime. Default value is 30secs.

R=rch@chromium.org, xunjieli@chromium.org
==========

[ramant (doing other things), 2015-12-09 21:22:28]

On 2015/12/09 21:05:38, xunjieli wrote:
> On 2015/12/09 21:03:09, ramant wrote:
> > Hi Helen and Misha,
> >   Does cronet use PreConnect? If cronet doesn't use PreConnect, we don't
need
> to
> > add that finch trial option.
> > 
> > thanks
> > raman
> 
> Are you referring to rel=preconnect ? I don't think we do.

Can cronet users call HttpStreamFactoryImpl::PreconnectStreams? ala
PreconnectOnIOThread.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/net...

I am guessing we don't expose that API call.

Deleted Finch Trial for disabling PreConnect as it is not used by Cronet.

[ramant (doing other things), 2015-12-09 21:22:51]

The CQ bit was checked by rtenneti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-09 21:27:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505983003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505983003/80001

[xunjieli, 2015-12-09 21:38:12]

On 2015/12/09 21:22:28, ramant wrote:
> On 2015/12/09 21:05:38, xunjieli wrote:
> > On 2015/12/09 21:03:09, ramant wrote:
> > > Hi Helen and Misha,
> > >   Does cronet use PreConnect? If cronet doesn't use PreConnect, we don't
> need
> > to
> > > add that finch trial option.
> > > 
> > > thanks
> > > raman
> > 
> > Are you referring to rel=preconnect ? I don't think we do.
> 
> Can cronet users call HttpStreamFactoryImpl::PreconnectStreams? ala
> PreconnectOnIOThread.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/net...
> 
> I am guessing we don't expose that API call.
Yes, you are right. They won't be able to make that call. 
> Deleted Finch Trial for disabling PreConnect as it is not used by Cronet.

lgtm if you run the tests locally, because Cronet does not have a trybot yet.

Could you run cronet_unittests as well as QuicTest.java to make sure tests pass?
Three steps listed below.
Thank you.

1. Set up GYP_DEFINES
$ components/cronet/tools/cr_cronet.py gyp
2. Build and run QuicTest
$ components/cronet/tools/cr_cronet.py build-test --test-filter=QuicTest*
3. Build and run cronet_unittests
$ ninja -C out/Debug cronet_unittests_apk
$ build/android/test_runner.py gtest -s cronet_unittests --verbose

[commit-bot: I haz the power, 2015-12-09 23:09:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-09 23:09:20]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2015-12-09 23:31:35]

lgtm

[ramant (doing other things), 2015-12-10 22:18:46]

On 2015/12/09 21:38:12, xunjieli wrote:
> On 2015/12/09 21:22:28, ramant wrote:
> > On 2015/12/09 21:05:38, xunjieli wrote:
> > > On 2015/12/09 21:03:09, ramant wrote:
> > > > Hi Helen and Misha,
> > > >   Does cronet use PreConnect? If cronet doesn't use PreConnect, we don't
> > need
> > > to
> > > > add that finch trial option.
> > > > 
> > > > thanks
> > > > raman
> > > 
> > > Are you referring to rel=preconnect ? I don't think we do.
> > 
> > Can cronet users call HttpStreamFactoryImpl::PreconnectStreams? ala
> > PreconnectOnIOThread.
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/net...
> > 
> > I am guessing we don't expose that API call.
> Yes, you are right. They won't be able to make that call. 
> > Deleted Finch Trial for disabling PreConnect as it is not used by Cronet.
> 
> lgtm if you run the tests locally, because Cronet does not have a trybot yet.
> 
> Could you run cronet_unittests as well as QuicTest.java to make sure tests
pass?
> Three steps listed below.
> Thank you.
> 
> 1. Set up GYP_DEFINES
> $ components/cronet/tools/cr_cronet.py gyp
> 2. Build and run QuicTest
> $ components/cronet/tools/cr_cronet.py build-test --test-filter=QuicTest*
> 3. Build and run cronet_unittests
> $ ninja -C out/Debug cronet_unittests_apk
> $ build/android/test_runner.py gtest -s cronet_unittests --verbose

Thanks Helen for verifying that this change works on Android. Committing.

[ramant (doing other things), 2015-12-10 22:18:52]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2015-12-10 22:20:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1505983003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1505983003/80001

[commit-bot: I haz the power, 2015-12-11 00:26:27]

Description was changed from

==========
QUIC - cronet - added idle_connection_timeout_seconds  experiment
that could be enabled via finch trials.

- idle_connection_timeout_seconds
  Specifes QUIC idle connection state lifetime. Default value is 30secs.

R=rch@chromium.org, xunjieli@chromium.org
==========

to

==========
QUIC - cronet - added idle_connection_timeout_seconds  experiment
that could be enabled via finch trials.

- idle_connection_timeout_seconds
  Specifes QUIC idle connection state lifetime. Default value is 30secs.

R=rch@chromium.org, xunjieli@chromium.org
==========

[commit-bot: I haz the power, 2015-12-11 00:26:29]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-12-11 00:27:37]

Description was changed from

==========
QUIC - cronet - added idle_connection_timeout_seconds  experiment
that could be enabled via finch trials.

- idle_connection_timeout_seconds
  Specifes QUIC idle connection state lifetime. Default value is 30secs.

R=rch@chromium.org, xunjieli@chromium.org
==========

to

==========
QUIC - cronet - added idle_connection_timeout_seconds  experiment
that could be enabled via finch trials.

- idle_connection_timeout_seconds
  Specifes QUIC idle connection state lifetime. Default value is 30secs.

R=rch@chromium.org, xunjieli@chromium.org

Committed: https://crrev.com/64e809d03a59d44e42960058371035866f8a1038
Cr-Commit-Position: refs/heads/master@{#364545}
==========

[commit-bot: I haz the power, 2015-12-11 00:27:38]

Patchset 3 (id:??) landed as
https://crrev.com/64e809d03a59d44e42960058371035866f8a1038
Cr-Commit-Position: refs/heads/master@{#364545}