relnote: Protect against a QUIC crash bug but logging a DFATAL and

relnote: Protect against a QUIC crash bug but logging a DFATAL and
closing the connection instead when a packet cannot be serialized.

This could help fixing Chromium BUG=479880
.

Merge internal change: 98506577

R=rch@chromium.org

Committed: https://crrev.com/0a2dccc01366309f1e55a9b86141137bb649c631
Cr-Commit-Position: refs/heads/master@{#339532}

[ramant (doing other things), 2015-07-20 20:13:32]

Hi Ryan,
  This CL handles QuicFramer::BuildDataPacket returning nullptr. Would like to
land this change separately to see if it fixes the crashes reported in issue
crbug.com/479880. If it fixes, then would like to merge the change to Dev/Beta
branches.

  Will submit another CL that removes the CHECK's added in the following CL.

https://codereview.chromium.org/1217273003/diff/1/net/quic/quic_framer.cc

thanks
raman

[Ryan Hamilton, 2015-07-20 20:39:33]

On 2015/07/20 20:13:32, ramant wrote:
> Hi Ryan,
>   This CL handles QuicFramer::BuildDataPacket returning nullptr. Would like to
> land this change separately to see if it fixes the crashes reported in issue
> crbug.com/479880. If it fixes, then would like to merge the change to Dev/Beta
> branches.
> 
>   Will submit another CL that removes the CHECK's added in the following CL.
> 
> https://codereview.chromium.org/1217273003/diff/1/net/quic/quic_framer.cc
> 
> thanks
> raman

Makes sense. LGTM

[ramant (doing other things), 2015-07-20 20:41:38]

On 2015/07/20 20:39:33, Ryan Hamilton wrote:
> On 2015/07/20 20:13:32, ramant wrote:
> > Hi Ryan,
> >   This CL handles QuicFramer::BuildDataPacket returning nullptr. Would like
to
> > land this change separately to see if it fixes the crashes reported in issue
> > crbug.com/479880. If it fixes, then would like to merge the change to
Dev/Beta
> > branches.
> > 
> >   Will submit another CL that removes the CHECK's added in the following CL.
> > 
> > https://codereview.chromium.org/1217273003/diff/1/net/quic/quic_framer.cc
> > 
> > thanks
> > raman
> 
> Makes sense. LGTM

Many many thanks Ryan for this CL review (and all other CL's reviews).

[ramant (doing other things), 2015-07-20 20:42:43]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2015-07-20 20:43:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1246793002/1

[commit-bot: I haz the power, 2015-07-20 22:04:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-20 22:06:04]

Patchset 1 (id:??) landed as
https://crrev.com/0a2dccc01366309f1e55a9b86141137bb649c631
Cr-Commit-Position: refs/heads/master@{#339532}

[jonross, 2015-07-21 13:52:25]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1248683002/ by jonross@chromium.org.

The reason for reverting is: The test added in this patch is crashing on Chrome
OS.

See crbug.com/512417.