Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2230503003: QUIC - Added histograms to track how cache ie performing when server (Closed)

Created:
4 years, 4 months ago by ramant (doing other things)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, mef
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Added histograms to track how cache ie performing when server configs are stored in the prefs.json file by cronet. The following histrograms are usefule for cronet based apps. Net.QuicDiskCache.APICall.PropertiesBasedCache Net.QuicDiskCache.FailureReason.PropertiesBasedCache BUG=636049 R=asvitkine@chromium.org,rch@chromium.org, rkaplow@chromium.org Committed: https://crrev.com/c79d3f509529c663bc208363ade6441bcfc6b783 Cr-Commit-Position: refs/heads/master@{#411092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -36 lines) Patch
M net/http/disk_cache_based_quic_server_info.h View 1 chunk +0 lines, -30 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/properties_based_quic_server_info.cc View 2 chunks +44 lines, -5 lines 0 comments Download
M net/quic/core/crypto/quic_server_info.h View 1 chunk +32 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (15 generated)
ramant (doing other things)
https://codereview.chromium.org/2230503003/diff/1/net/quic/chromium/quic_stream_factory.cc File net/quic/chromium/quic_stream_factory.cc (right): https://codereview.chromium.org/2230503003/diff/1/net/quic/chromium/quic_stream_factory.cc#newcode1990 net/quic/chromium/quic_stream_factory.cc:1990: std::vector<QuicServerId> server_list; Specifying the size was unnecessary. push_back increases ...
4 years, 4 months ago (2016-08-09 19:50:34 UTC) #3
Ryan Hamilton
lgtm
4 years, 4 months ago (2016-08-09 21:56:40 UTC) #9
gayane -on leave until 09-2017
LGTM for histograms. Need to wait for approval from rkaplow.
4 years, 4 months ago (2016-08-10 18:05:53 UTC) #15
rkaplow
lgtm
4 years, 4 months ago (2016-08-10 18:21:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230503003/20001
4 years, 4 months ago (2016-08-10 18:22:33 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-10 18:35:14 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 18:36:39 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c79d3f509529c663bc208363ade6441bcfc6b783
Cr-Commit-Position: refs/heads/master@{#411092}

Powered by Google App Engine
This is Rietveld 408576698