Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1640343002: relnote: moves ProcessPacketInterface from quic_dispatcher.h to (Closed)

Created:
4 years, 11 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
Reviewers:
Jana, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, danzh1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: moves ProcessPacketInterface from quic_dispatcher.h to quic_packet_reader.h, and updates QuiClient to implement this interface. No functional change to internal server. add an new member function in quic client to read multiple packets per call. TODO: Implement in chromium to read multiple packets per call. FIXED=21846229 Merge internal change: 101790938 relnote: N/A. Moved ProcessPacketInterface to a new file to fix chromium build problems. Moved ProcessPacketInterface class from quic_packet_reader.h into a separate file that could be included by both quic_dispatcher.h and quic_packet_reader.h. In chromium, we build quic_packet_reader.cc on posix platform only becuase it uses mmsghdr which is not supported on other platforms. This fixes the problem with porting the following CL: 101790938 Chromium cl: https://codereview.chromium.org/1640343002/ Will merge this CL into the above CL to fix IOS, mac, windows and android compile problems. Merge internal change: 113186932 R=jri@chromium.org, rch@chromium.org Committed: https://crrev.com/d83f6171799d049ecf7ca5b7b71d9a8b0cae2899 Cr-Commit-Position: refs/heads/master@{#372126}

Patch Set 1 #

Patch Set 2 : Merge internal change: 113186932 #

Patch Set 3 : Removed usage of net/tools/quic/quic_packet_reader.h from quic_client.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -13 lines) Patch
M net/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/net.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_client.h View 1 2 6 chunks +23 lines, -1 line 0 comments Download
M net/tools/quic/quic_client.cc View 1 2 5 chunks +27 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 2 chunks +1 line, -8 lines 0 comments Download
M net/tools/quic/quic_packet_reader.h View 1 2 chunks +1 line, -1 line 0 comments Download
M net/tools/quic/quic_packet_reader.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
A net/tools/quic/quic_process_packet_interface.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (12 generated)
ramant (doing other things)
4 years, 11 months ago (2016-01-27 17:33:26 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640343002/1
4 years, 11 months ago (2016-01-27 17:35:17 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/122592) ios_rel_device_ninja on ...
4 years, 11 months ago (2016-01-27 17:45:48 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640343002/20001
4 years, 11 months ago (2016-01-27 22:57:24 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640343002/40001
4 years, 11 months ago (2016-01-27 23:17:40 UTC) #13
ramant (doing other things)
Hi Jana and Ryan, I am very optimistic this will pass the CQ try bots. ...
4 years, 11 months ago (2016-01-27 23:21:44 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-28 00:52:32 UTC) #16
Ryan Hamilton
lgtm
4 years, 10 months ago (2016-01-28 17:58:00 UTC) #17
ramant (doing other things)
On 2016/01/28 17:58:00, Ryan Hamilton wrote: > lgtm thanks much Ryan. Submitting. Jana: these changes ...
4 years, 10 months ago (2016-01-28 17:59:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640343002/40001
4 years, 10 months ago (2016-01-28 18:00:23 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-01-28 19:16:25 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 19:17:21 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d83f6171799d049ecf7ca5b7b71d9a8b0cae2899
Cr-Commit-Position: refs/heads/master@{#372126}

Powered by Google App Engine
This is Rietveld 408576698