Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
R=sky@chromium.org,xiyuan@chromium.org
TBR=stevenjb@chromium.org

Committed: https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618
Cr-Commit-Position: refs/heads/master@{#422726}

[dcheng, 2016-10-03 20:30:29]

Description was changed from

==========
Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
==========

to

==========
Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
==========

[dcheng, 2016-10-03 20:30:30]

dcheng@chromium.org changed reviewers:
+ sky@chromium.org

[dcheng, 2016-10-03 20:31:09]

dcheng@chromium.org changed reviewers:
+ derat@chromium.org

[dcheng, 2016-10-03 20:32:13]

dcheng@chromium.org changed reviewers:
+ xiyuan@chromium.org
- derat@chromium.org

[dcheng, 2016-10-03 20:32:14]

+sky for //ash and //chrome
+xiyuan for //chromeos and //components

[dcheng, 2016-10-03 20:32:29]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 20:32:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-10-03 21:03:24]

lgtm

[commit-bot: I haz the power, 2016-10-03 21:22:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 21:22:24]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-03 21:48:18]

LGTM

https://codereview.chromium.org/2392693002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/network/tray_sms.cc (right):

https://codereview.chromium.org/2392693002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/network/tray_sms.cc:374:
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
MakeUnique?

https://codereview.chromium.org/2392693002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
(right):

https://codereview.chromium.org/2392693002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:766:
std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue());
MakeUnique

https://codereview.chromium.org/2392693002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:866:
std::unique_ptr<base::DictionaryValue> result_dict(
MakeUnique (I'm not going to mention it anymore).

[dcheng, 2016-10-04 00:48:52]

On 2016/10/03 21:48:18, sky wrote:
> LGTM
> 
>
https://codereview.chromium.org/2392693002/diff/20001/ash/common/system/chrom...
> File ash/common/system/chromeos/network/tray_sms.cc (right):
> 
>
https://codereview.chromium.org/2392693002/diff/20001/ash/common/system/chrom...
> ash/common/system/chromeos/network/tray_sms.cc:374:
> std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
> MakeUnique?
> 
>
https://codereview.chromium.org/2392693002/diff/20001/chrome/browser/chromeos...
> File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
> (right):
> 
>
https://codereview.chromium.org/2392693002/diff/20001/chrome/browser/chromeos...
> chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:766:
> std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue());
> MakeUnique
> 
>
https://codereview.chromium.org/2392693002/diff/20001/chrome/browser/chromeos...
> chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:866:
> std::unique_ptr<base::DictionaryValue> result_dict(
> MakeUnique (I'm not going to mention it anymore).

I'll fix these instances locally and update the tooling, which was written
before auto x = base::MakeUnique<> became generally accepted. Thanks

[dcheng, 2016-10-04 06:12:08]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-10-04 06:12:08]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2392693002/#ps40001
(title: "MakeUnique")

[commit-bot: I haz the power, 2016-10-04 06:12:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 06:22:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 06:22:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-10-04 06:31:26]

Description was changed from

==========
Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
==========

to

==========
Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
R=sky@chromium.org,xiyuan@chromium.org
TBR=stevenjb@chromium.org
==========

[dcheng, 2016-10-04 06:31:26]

dcheng@chromium.org changed reviewers:
+ stevenjb@chromium.org

[dcheng, 2016-10-04 06:31:44]

TBRing noparent owners (already reviewed by sky@ and xiyuan@ overall)

[dcheng, 2016-10-04 06:34:48]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-10-04 06:35:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 07:00:58]

Description was changed from

==========
Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
R=sky@chromium.org,xiyuan@chromium.org
TBR=stevenjb@chromium.org
==========

to

==========
Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
R=sky@chromium.org,xiyuan@chromium.org
TBR=stevenjb@chromium.org
==========

[commit-bot: I haz the power, 2016-10-04 07:01:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 07:03:11]

Description was changed from

==========
Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
R=sky@chromium.org,xiyuan@chromium.org
TBR=stevenjb@chromium.org
==========

to

==========
Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Generated with https://codereview.chromium.org/2056153003/.

BUG=581865
R=sky@chromium.org,xiyuan@chromium.org
TBR=stevenjb@chromium.org

Committed: https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618
Cr-Commit-Position: refs/heads/master@{#422726}
==========

[commit-bot: I haz the power, 2016-10-04 07:03:13]

Patchset 3 (id:??) landed as
https://crrev.com/0e07b19a4535fefbd08d823e891db47737521618
Cr-Commit-Position: refs/heads/master@{#422726}