Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

chrome/browser/chromeos/settings/cros_settings_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 
 #include <map>
 #include <memory>
 #include <string>
 
@@ skipping 104 matching lines @@
 TEST_F(CrosSettingsTest, GetPref) {
   // We didn't change the default so look for it.
   AddExpectation(kAccountsPrefAllowGuest, new base::FundamentalValue(true));
   FetchPref(kAccountsPrefAllowGuest);
 }
 
 TEST_F(CrosSettingsTest, SetWhitelist) {
   // Setting the whitelist should also switch the value of
   // kAccountsPrefAllowNewUser to false.
   base::ListValue whitelist;
-  whitelist.Append(new base::StringValue("me@owner"));
+  whitelist.AppendString("me@owner");
   AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
   AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
   SetPref(kAccountsPrefUsers, &whitelist);
   FetchPref(kAccountsPrefAllowNewUser);
   FetchPref(kAccountsPrefUsers);
 }
 
 TEST_F(CrosSettingsTest, SetWhitelistWithListOps) {
   base::ListValue* whitelist = new base::ListValue();
   base::StringValue hacky_user("h@xxor");
@@ skipping 46 matching lines @@
   SetPref(kAccountsPrefUsers, &whitelist);
   SetPref(kAccountsPrefAllowNewUser, &disallow_new);
   FetchPref(kAccountsPrefAllowNewUser);
   FetchPref(kAccountsPrefUsers);
 }
 
 TEST_F(CrosSettingsTest, SetWhitelistAndNoNewUsers) {
   // Setting the whitelist should allow us to set kAccountsPrefAllowNewUser to
   // false (which is the implicit value too).
   base::ListValue whitelist;
-  whitelist.Append(new base::StringValue("me@owner"));
+  whitelist.AppendString("me@owner");
   AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
   AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(false));
   SetPref(kAccountsPrefUsers, &whitelist);
   SetPref(kAccountsPrefAllowNewUser,
           expected_props_[kAccountsPrefAllowNewUser]);
   FetchPref(kAccountsPrefAllowNewUser);
   FetchPref(kAccountsPrefUsers);
 }
 
 TEST_F(CrosSettingsTest, SetAllowNewUsers) {
   // Setting kAccountsPrefAllowNewUser to true with no whitelist should be ok.
   AddExpectation(kAccountsPrefAllowNewUser, new base::FundamentalValue(true));
   SetPref(kAccountsPrefAllowNewUser,
           expected_props_[kAccountsPrefAllowNewUser]);
   FetchPref(kAccountsPrefAllowNewUser);
 }
 
 TEST_F(CrosSettingsTest, SetEphemeralUsersEnabled) {
   base::FundamentalValue ephemeral_users_enabled(true);
   AddExpectation(kAccountsPrefEphemeralUsersEnabled,
                  new base::FundamentalValue(true));
   SetPref(kAccountsPrefEphemeralUsersEnabled, &ephemeral_users_enabled);
   FetchPref(kAccountsPrefEphemeralUsersEnabled);
 }
 
 TEST_F(CrosSettingsTest, FindEmailInList) {
   base::ListValue list;
-  list.Append(new base::StringValue("user@example.com"));
-  list.Append(new base::StringValue("nodomain"));
-  list.Append(new base::StringValue("with.dots@gmail.com"));
-  list.Append(new base::StringValue("Upper@example.com"));
+  list.AppendString("user@example.com");
+  list.AppendString("nodomain");
+  list.AppendString("with.dots@gmail.com");
+  list.AppendString("Upper@example.com");
 
   CrosSettings* cs = &settings_;
   cs->Set(kAccountsPrefUsers, list);
 
   EXPECT_TRUE(IsWhitelisted(cs, "user@example.com"));
   EXPECT_FALSE(IsWhitelisted(cs, "us.er@example.com"));
   EXPECT_TRUE(IsWhitelisted(cs, "USER@example.com"));
   EXPECT_FALSE(IsWhitelisted(cs, "user"));
 
   EXPECT_TRUE(IsWhitelisted(cs, "nodomain"));
   EXPECT_TRUE(IsWhitelisted(cs, "nodomain@gmail.com"));
   EXPECT_TRUE(IsWhitelisted(cs, "no.domain@gmail.com"));
   EXPECT_TRUE(IsWhitelisted(cs, "NO.DOMAIN"));
 
   EXPECT_TRUE(IsWhitelisted(cs, "with.dots@gmail.com"));
   EXPECT_TRUE(IsWhitelisted(cs, "withdots@gmail.com"));
   EXPECT_TRUE(IsWhitelisted(cs, "WITH.DOTS@gmail.com"));
   EXPECT_TRUE(IsWhitelisted(cs, "WITHDOTS"));
 
   EXPECT_TRUE(IsWhitelisted(cs, "Upper@example.com"));
   EXPECT_FALSE(IsWhitelisted(cs, "U.pper@example.com"));
   EXPECT_FALSE(IsWhitelisted(cs, "Upper"));
   EXPECT_TRUE(IsWhitelisted(cs, "upper@example.com"));
 }
 
 TEST_F(CrosSettingsTest, FindEmailInListWildcard) {
   base::ListValue list;
-  list.Append(new base::StringValue("user@example.com"));
-  list.Append(new base::StringValue("*@example.com"));
+  list.AppendString("user@example.com");
+  list.AppendString("*@example.com");
 
   CrosSettings* cs = &settings_;
   cs->Set(kAccountsPrefUsers, list);
 
   bool wildcard_match = false;
   EXPECT_TRUE(cs->FindEmailInList(
       kAccountsPrefUsers, "test@example.com", &wildcard_match));
   EXPECT_TRUE(wildcard_match);
   EXPECT_TRUE(cs->FindEmailInList(
       kAccountsPrefUsers, "user@example.com", &wildcard_match));
   EXPECT_FALSE(wildcard_match);
   EXPECT_TRUE(cs->FindEmailInList(
       kAccountsPrefUsers, "*@example.com", &wildcard_match));
   EXPECT_TRUE(wildcard_match);
 }
 
 }  // namespace chromeos