Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3137)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 25bb67a21d44d073a39f89d16ab588af56693830..9083cc4c2d823abb255f7fe87c155dab3b197827 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -640,13 +640,13 @@ void BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue* values) {
option_full->AppendInteger(ash::MAGNIFIER_FULL);
option_full->AppendString(l10n_util::GetStringUTF16(
IDS_OPTIONS_SETTINGS_ACCESSIBILITY_SCREEN_MAGNIFIER_FULL));
- magnifier_list->Append(option_full.release());
+ magnifier_list->Append(std::move(option_full));
std::unique_ptr<base::ListValue> option_partial(new base::ListValue);
option_partial->AppendInteger(ash::MAGNIFIER_PARTIAL);
- option_partial->Append(new base::StringValue(l10n_util::GetStringUTF16(
- IDS_OPTIONS_SETTINGS_ACCESSIBILITY_SCREEN_MAGNIFIER_PARTIAL)));
- magnifier_list->Append(option_partial.release());
+ option_partial->AppendString(l10n_util::GetStringUTF16(
+ IDS_OPTIONS_SETTINGS_ACCESSIBILITY_SCREEN_MAGNIFIER_PARTIAL));
+ magnifier_list->Append(std::move(option_partial));
values->Set("magnifierList", magnifier_list.release());
#endif

Powered by Google App Engine
This is Rietveld 408576698