Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: chrome/browser/chromeos/proxy_config_service_impl_unittest.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
diff --git a/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc b/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
index 4443236315667986213c9944207e902a12db999b..e2f4b2719b29a42e8a4ca01030d417c9da4557e6 100644
--- a/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
+++ b/chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
@@ -6,6 +6,7 @@
#include <stddef.h>
+#include <utility>
#include <vector>
#include "base/format_macros.h"
@@ -513,7 +514,7 @@ TEST_F(ProxyConfigServiceImplTest, SharedEthernetAndUserPolicy) {
chromeos::onc::ReadDictionaryFromJson(kEthernetPolicy));
std::unique_ptr<base::ListValue> network_configs(new base::ListValue);
- network_configs->Append(ethernet_policy.release());
+ network_configs->Append(std::move(ethernet_policy));
profile_prefs_.SetUserPref(prefs::kUseSharedProxies,
new base::FundamentalValue(false));

Powered by Google App Engine
This is Rietveld 408576698