chrome/browser/chromeos/extensions/users_private/users_private_api.cc - Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/users_private/users_private_api.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)

Patch Set: MakeUnique Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/input_method_event_router.cc ('k') | chrome/browser/chromeos/extensions/wallpaper_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/users_private/users_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/users_private/users_private_api.cc b/chrome/browser/chromeos/extensions/users_private/users_private_api.cc

index 467cf809e6d650b086a0bbf387e5a610d72ab2e2..2ab884ab43b64eac6f14087b0726538ed6d12c89 100644

--- a/chrome/browser/chromeos/extensions/users_private/users_private_api.cc

+++ b/chrome/browser/chromeos/extensions/users_private/users_private_api.cc

@@ -103,7 +103,7 @@ UsersPrivateGetWhitelistedUsersFunction::Run() {

user_manager->GetUserDisplayEmail(AccountId::FromUserEmail(user.email));

user.is_owner = chromeos::ProfileHelper::IsOwnerProfile(profile) &&

user.email == profile->GetProfileUserName();

- user_list->Append(user.ToValue().release());

+ user_list->Append(user.ToValue());

}

return RespondNow(OneArgument(std::move(user_list)));