Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Issue 2392693002: Rewrite simple uses of base::ListValue::Append(base::Value*) on CrOS. (Closed)
Patch Set: MakeUnique Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h" 5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <map> 10 #include <map>
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 // Fake gmail extension. 367 // Fake gmail extension.
368 base::DictionaryValue manifest_gmail; 368 base::DictionaryValue manifest_gmail;
369 manifest_gmail.SetString(extensions::manifest_keys::kName, 369 manifest_gmail.SetString(extensions::manifest_keys::kName,
370 "Gmail launcher controller test extension"); 370 "Gmail launcher controller test extension");
371 manifest_gmail.SetString(extensions::manifest_keys::kVersion, "1"); 371 manifest_gmail.SetString(extensions::manifest_keys::kVersion, "1");
372 manifest_gmail.SetString(extensions::manifest_keys::kDescription, 372 manifest_gmail.SetString(extensions::manifest_keys::kDescription,
373 "for testing pinned Gmail"); 373 "for testing pinned Gmail");
374 manifest_gmail.SetString(extensions::manifest_keys::kLaunchWebURL, 374 manifest_gmail.SetString(extensions::manifest_keys::kLaunchWebURL,
375 kGmailLaunchURL); 375 kGmailLaunchURL);
376 base::ListValue* list = new base::ListValue(); 376 base::ListValue* list = new base::ListValue();
377 list->Append(new base::StringValue("*://mail.google.com/mail/ca")); 377 list->AppendString("*://mail.google.com/mail/ca");
378 manifest_gmail.Set(extensions::manifest_keys::kWebURLs, list); 378 manifest_gmail.Set(extensions::manifest_keys::kWebURLs, list);
379 379
380 extension3_ = Extension::Create(base::FilePath(), Manifest::UNPACKED, 380 extension3_ = Extension::Create(base::FilePath(), Manifest::UNPACKED,
381 manifest_gmail, 381 manifest_gmail,
382 Extension::NO_FLAGS, 382 Extension::NO_FLAGS,
383 extension_misc::kGmailAppId, 383 extension_misc::kGmailAppId,
384 &error); 384 &error);
385 385
386 // Fake google docs extension. 386 // Fake google docs extension.
387 extension4_ = Extension::Create(base::FilePath(), Manifest::UNPACKED, 387 extension4_ = Extension::Create(base::FilePath(), Manifest::UNPACKED,
(...skipping 3569 matching lines...) Expand 10 before | Expand all | Expand 10 after
3957 app_service_->GetPinPosition(extension_misc::kChromeAppId))); 3957 app_service_->GetPinPosition(extension_misc::kChromeAppId)));
3958 EXPECT_TRUE( 3958 EXPECT_TRUE(
3959 position_1.Equals(app_service_->GetPinPosition(extension1_->id()))); 3959 position_1.Equals(app_service_->GetPinPosition(extension1_->id())));
3960 EXPECT_TRUE( 3960 EXPECT_TRUE(
3961 position_1.Equals(app_service_->GetPinPosition(extension1_->id()))); 3961 position_1.Equals(app_service_->GetPinPosition(extension1_->id())));
3962 EXPECT_TRUE( 3962 EXPECT_TRUE(
3963 position_2.Equals(app_service_->GetPinPosition(extension2_->id()))); 3963 position_2.Equals(app_service_->GetPinPosition(extension2_->id())));
3964 EXPECT_TRUE( 3964 EXPECT_TRUE(
3965 position_3.Equals(app_service_->GetPinPosition(extension3_->id()))); 3965 position_3.Equals(app_service_->GetPinPosition(extension3_->id())));
3966 } 3966 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/ash/chrome_keyboard_ui.cc ('k') | chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698